Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758770AbYABP4z (ORCPT ); Wed, 2 Jan 2008 10:56:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754510AbYABP4p (ORCPT ); Wed, 2 Jan 2008 10:56:45 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:44656 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754173AbYABP4n (ORCPT ); Wed, 2 Jan 2008 10:56:43 -0500 Date: Wed, 2 Jan 2008 10:56:43 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Greg KH cc: Andreas Mohr , Ingo Molnar , Alexey Dobriyan , Andrew Morton , David Woodhouse , "Eric W. Biederman" , Linus Torvalds , "Rafael J. Wysocki" , Pavel Machek , kernel list , netdev , Pavel Emelyanov , "Denis V. Lunev" , USB list Subject: Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage In-Reply-To: <20080102060006.GA27693@kroah.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1789 Lines: 44 On Tue, 1 Jan 2008, Greg KH wrote: > On Mon, Dec 31, 2007 at 11:26:43AM -0800, Greg KH wrote: > > On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: > > > On Sun, 30 Dec 2007, Greg KH wrote: > > > > > > > > It looks like Greg misused the debugfs API -- which is ironic, because > > > > > he wrote debugfs in the first place! :-) > Ok, no, I didn't write that patch, I'm getting very confused here. > > In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. > > In the -mm tree there is a patch, from Tony Jones, that moves some debug > code out of sysfs and into debugfs where it belongs. It does it for > both the ehci and ohci USB host controller drivers, and this is the code > that is incorrect if CONFIG_DEBUGFS is not enabled. My mistake; I got the impression you had written that new code rather than Tony. BTW, I don't recall ever seeing Tony's patch announced on linux-usb or linux-usb-devel. Did I simply miss it? > So, for the 2.6.24 release, nothing needs to be changed, all is good, > and there is no regression. > > Right? Or am I still confused about this whole thing? Correct. The problem exists only in -mm and your development tree. > I will go fix up Tony's patches in the -mm tree that do not handle the > error return values from debugfs properly, but that is not such a rush, > as Tony is on vacation for a few weeks, and those patches are going to > be going in only after 2.6.24 is out. The fix I posted earlier in this thread should simply be merged into Tony's patches. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/