Received-SPF: pass (google.com: domain of linux-kernel+bounces-83152-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: multipart/signed;
 boundary=0b310bada9a22be6bb3934105c69e6dfccfb4490b3887f73dfc6b62fff06;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Tue, 27 Feb 2024 12:58:15 +0100
Message-Id: <CZFUDO8U8WAE.1YDN70AI3JWNQ@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
 <sumitg@nvidia.com>
Subject: Re: [PATCH v2 1/2] clocksource/drivers/timer-tegra186: add
 WDIOC_GETTIMELEFT support
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Pohsun Su" <pohsuns@nvidia.com>, <daniel.lezcano@linaro.org>,
 <tglx@linutronix.de>, <jonathanh@nvidia.com>
References: <CZ96NM6U8O59.3TXG2WKAL7L8F@gmail.com>
 <20240223235126.31004-1-pohsuns@nvidia.com>
In-Reply-To: <20240223235126.31004-1-pohsuns@nvidia.com>

--0b310bada9a22be6bb3934105c69e6dfccfb4490b3887f73dfc6b62fff06
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Sat Feb 24, 2024 at 12:51 AM CET, Pohsun Su wrote:
> Hi Thierry,
>
> >> +static unsigned int tegra186_wdt_get_timeleft(struct watchdog_device =
*wdd)
> >> +{
> >> +     struct tegra186_wdt *wdt =3D to_tegra186_wdt(wdd);
> >> +     u32 timeleft;
> >> +     u32 expiration;
> >> +
> >> +     if (!watchdog_active(&wdt->base)) {
> >> +             /* return zero if the watchdog timer is not activated. *=
/
> >> +             return 0;
> >> +     }
> >> +
> >> +     /*
> >> +      * System power-on reset occurs on the fifth expiration of the w=
atchdog timer and so
> >
> >Is "system power-on reset" really what this is called? Power-on reset
> >sounds like something that only happens after you power the device on,
> >not something that can be triggered by the watchdog.
>
> I will change it from "system power-on reset" to "System POR(Power On Res=
et)" in next patch.
> AFAIK Power On Reset is used for decribing resetting circuits and initial=
ing whatever it needs
> when received a POR signal after powered up. This term should also be app=
licable for
> hardware watchdog reset since the system is already powered up at that mo=
ment and=20

"System POR" isn't an improvement over "system power-on reset". I'm
mainly concerned that somebody might mistake this to somehow mean that
there's an actual power cycle, which, as I understand, there isn't. So
maybe just explain that this type of reset will put the system into the
same state that it would be after a power cycle?

Thierry

--0b310bada9a22be6bb3934105c69e6dfccfb4490b3887f73dfc6b62fff06
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmXdzlgACgkQ3SOs138+
s6FV3A/9E2xaa7fY4Podpe3Oql8JIzZCPAtCtKzCaCy4/GnYEDfspkT44/i1X31D
hbrbmTFeeZi44771obeHv/0A/ookODruAV2ylduv5T1gYdMpjWRvaCsfnasmL0ZU
wunFkLvilQI20ncq/COM30KfLZA6eljfvD9laAS2AHS8GZj2HwRFVvxSsBH/7v1L
GUd3R2TIoChY1pBDVEZPF0ZYl9Dq0O8NoPNfw/g8yhsZOEt8eRQ4IrxC+EKWk/4r
Ju9gLAAXxlnkdpH3P4AhkTzN/fgbJykiSrbxH5rdcpUHheTu373L6V1eaSbe6ZyG
51ngM7OXqBAnXI6d6mXCPfP37InT0xZ9BBjwsboFZ7eYtHA6I7fGpzgTA1+zdjOa
0F4ede8RYEEf3Em46eOAPH3XMv9F1HrsGcaS0vnZRO9LcY5MTGOCpAqTiio92sP0
CQ7QKL0mUeeXi3kjZSHfvbv7M0ZdggNvi3mjgA94aHHauVve793d2xRCwoulbIb5
QZwzVHtBgMAPXwkyj7wWmbzTCAsevPEuu0HWkA7GfW0yKqwhygKInJED/Ql3RXKo
45t8jMGOCdv2yjbu9jNP/zOfl+VN6yGr8XOXQteVaeZvjvC2rCsQ3NE6EWJkVN16
B2BoXjZ1SThXPmInfwO1+KEkkuf7+ZG5vxaJ9j5s2f4vnAdG7Lk=
=Ed17
-----END PGP SIGNATURE-----

--0b310bada9a22be6bb3934105c69e6dfccfb4490b3887f73dfc6b62fff06--