Received-SPF: pass (google.com: domain of linux-kernel+bounces-83150-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 27 Feb 2024 13:55:45 +0200
From: Pekka Paalanen <pekka.paalanen@collabora.com>
To: Arthur Grillo <arthurgrillo@riseup.net>
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>, Melissa Wen
 <melissa.srw@gmail.com>, =?UTF-8?B?TWHDrXJh?= Canal
 <mairacanal@riseup.net>, Haneen Mohammed <hamohammed.sa@gmail.com>, Daniel
 Vetter <daniel@ffwll.ch>, Maarten Lankhorst
 <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>,
 Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>,
 Jonathan Corbet <corbet@lwn.net>, dri-devel@lists.freedesktop.org,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vkms: Add information on how to benchmark
Message-ID: <20240227135545.62dd5f57.pekka.paalanen@collabora.com>
In-Reply-To: <8ac7bf91-fbce-4403-a801-9dfee39ea802@riseup.net>
References: <20240226-bench-vkms-v1-1-515ef91b11c8@riseup.net>
	<20240227111941.061a2892.pekka.paalanen@collabora.com>
	<8ac7bf91-fbce-4403-a801-9dfee39ea802@riseup.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/A2mWu+vSdQNKM_BZwjnjD0Q";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/A2mWu+vSdQNKM_BZwjnjD0Q
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Tue, 27 Feb 2024 08:44:52 -0300
Arthur Grillo <arthurgrillo@riseup.net> wrote:

> On 27/02/24 06:19, Pekka Paalanen wrote:
> > On Mon, 26 Feb 2024 17:42:11 -0300
> > Arthur Grillo <arthurgrillo@riseup.net> wrote:
> >  =20
> >> Now that we have a defined benchmark for testing the driver, add
> >> documentation on how to run it.
> >>
> >> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
> >> ---
> >>  Documentation/gpu/vkms.rst | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst
> >> index ba04ac7c2167..6d07f79f77ff 100644
> >> --- a/Documentation/gpu/vkms.rst
> >> +++ b/Documentation/gpu/vkms.rst
> >> @@ -89,6 +89,12 @@ You can also run subtests if you do not want to run=
 the entire test::
> >>    sudo ./build/tests/kms_flip --run-subtest basic-plain-flip --device=
 "sys:/sys/devices/platform/vkms"
> >>    sudo IGT_DEVICE=3D"sys:/sys/devices/platform/vkms" ./build/tests/km=
s_flip --run-subtest basic-plain-flip
> >> =20
> >> +If you are developing features that may affect performance, you can r=
un the kms_fb_stress =20
> >=20
> > s/can/must/
> >  =20
> >> +benchmark:: =20
> >=20
> > before and after, and report the numbers. =20
>=20
> Did you mean to write the benchmarks logs here?

I mean people should be required tell their before and after numbers in
either commit message (my preference) or in series cover letter (if
benchmarking commits is not useful).

With the addition of YUV support in VKMS, maybe the benchmark needs to
start printing YUV numbers separately as a new case.


Thanks,
pq

>=20
> >  =20
> >> +
> >> +  sudo ./build/benchmarks/kms_fb_stress --device "sys:/sys/devices/pl=
atform/vkms"
> >> +  sudo IGT_DEVICE=3D"sys:/sys/devices/platform/vkms" ./build/benchmar=
ks/kms_fb_stress =20
> >=20
> > Do people need to run both commands? =20
>=20
> No, they don't, just two options.
>=20
> Best Regards,
> ~Arthur Grillo
>=20
> >=20
> > Anyway, a good idea.
> >=20
> > Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>
> >=20
> >=20
> > Thanks,
> > pq
> >  =20
> >> +
> >>  TODO
> >>  =3D=3D=3D=3D
> >> =20
> >>
> >> ---
> >> base-commit: eeb8e8d9f124f279e80ae679f4ba6e822ce4f95f
> >> change-id: 20240226-bench-vkms-5b8b7aab255e
> >>
> >> Best regards, =20
> >  =20


--Sig_/A2mWu+vSdQNKM_BZwjnjD0Q
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAmXdzcEACgkQI1/ltBGq
qqc8SA//bU98zQBK+jIEVhc/aP0I7notpot6B1M0AFjUka9CgrjdKa5KKWjZspUy
uCkPYdDHLqIEq3rhABUlxhIscQZDeNPWbkau6abaf/jhlrRytwwJ9tP2CKhjX6HE
WADwmKjRQwBYyxVmAXA++4abB818zfniZN1VbpgHlHiiZTsM0Y/Ck9PCl2sKhzpp
ANI3HvYyRiYnvYJuIRrGsE6t8JCFglUx8C4yaNlma+N7N7nzel+lMw2RjE7cprNc
1kBXj/fo3RvrhPv6e84YxfzXNSOnKo9PBEgWw2srapFIXf9Y3GnyU2kuX/lsoilv
gekCWYdaDTwraTJOsmLAHTtKFF554Ab1KGx+S5rx6QBPDg5/8F9KDYd43KEGzfkg
mGl0Up0UIqhdb5ioiXrFAkcwQ7+ChpqNj1Tr0dsiyiqWu7T6VQFWK2PBrATJ6ONI
hv/v0GSFzyBOVjSt5J0PbKZkqYYxwbCRjdpAjlxCyCkc3GaJEnRwRjNnVx6foz/m
xs4kLSo1XwRuGz0u6Vjt6xxecMEBulmoHKK+wQsHRThr96BSdPL5OAI86lZOvFrF
sRIycPX+SFR17AiQfyxYByUPrqzr6kHpAosBeEZ6N9gIUGNGSoOBijzRR+HoayoJ
gu6f4ssszr4qskgMqvNSDQnxhtBpJj2JN4IdXTZ2R4FwesuXmFw=
=dsHb
-----END PGP SIGNATURE-----

--Sig_/A2mWu+vSdQNKM_BZwjnjD0Q--