Received-SPF: pass (google.com: domain of linux-kernel+bounces-83267-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240227123602.258190-1-javier.garcia.ta@udima.es>
In-Reply-To: <20240227123602.258190-1-javier.garcia.ta@udima.es>
From: Daniel Baluta <daniel.baluta@gmail.com>
Date: Tue, 27 Feb 2024 14:54:23 +0200
Message-ID: <CAEnQRZD1chD+14iFc=m1zY17rEQXGB9AQTxLZnhcPg7VVmR=PA@mail.gmail.com>
Subject: Re: [PATCH] Convert the Imagination Technologies SPDIF Input
 Controllerto DT schema.
To: =?UTF-8?Q?Javier_Garc=C3=ADa?= <javier.garcia.ta@udima.es>
Cc: daniel.baluta@nxp.com, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

Few comments:

Subject should contain a prefix e.g:

ASoC: dt-bindings: img,spdif-in: Convert Imagination ....

Also do not add a '.' at the end of the subject line.

one more comment inline:

> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/pistachio-clk.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/interrupt-controller/mips-gic.h>
> +    #include <dt-bindings/reset/pistachio-resets.h>
> +    spdif_in: spdif-in@18100e00 {

Node name should be generic:

e.g spdif_in: spdif@18100....