Received-SPF: pass (google.com: domain of linux-kernel+bounces-83273-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 27 Feb 2024 04:59:59 -0800
From: Luis Chamberlain <mcgrof@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: russ.weight@linux.dev, gregkh@linuxfoundation.org, rafael@kernel.org,
	linux-kernel@vger.kernel.org, masahiroy@kernel.org
Subject: Re: [PATCH] firmware_loader: Use init_utsname()->release
Message-ID: <Zd3cz7yYezir-P7e@bombadil.infradead.org>
References: <20240222145819.96646-1-john.g.garry@oracle.com>
 <Zddt-U-6SdxkxqmD@bombadil.infradead.org>
 <51483aaf-d64a-4eee-b256-ab126483ad6c@oracle.com>
 <Zdy9gKO5Q6K4IE8J@bombadil.infradead.org>
 <ZdzGF9bxLn3Slbgi@bombadil.infradead.org>
 <cb0c185c-54f8-4b43-856f-685cc5ed3fc4@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cb0c185c-54f8-4b43-856f-685cc5ed3fc4@oracle.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>

On Mon, Feb 26, 2024 at 05:13:44PM +0000, John Garry wrote:
> On 26/02/2024 17:10, Luis Chamberlain wrote:
> > > > I am running this now, but it does not seem stable on a v6.8-rc5 baseline. I
> > > > am seeing hangs. Are there any known issues?
> > > I tested next-20240108 and so no issues.
> > > 
> > > Lemme upgrade.
> > > 
> > > Note you also need /lib/udev/rules.d/50-firmware.rules removed if
> > > you have it.
> 
> I have this:
> ubuntu@jgarry-ubuntu-bm5-instance-20230215-1843:~/mnt/linux2$ more
> /lib/udev/rules.d/50-firmware.rules
> # stub for immediately telling the kernel that userspace firmware loading
> # failed; necessary to avoid long timeouts with
> CONFIG_FW_LOADER_USER_HELPER=y
> SUBSYSTEM=="firmware", ACTION=="add", ATTR{loading}="-1"
> 
> So I can remove it.

You can keep it on a distro use case, but for testing it is important to
remove it.

> > I don't see any hung tasks on next-20240226. Perhaps its with your
> > config that it is triggered.
> OK, I'll check again when I get a chance, but I am not so keen on checking
> linux-next in general.

What kernel are you seeing this issue on?

  Luis