Received-SPF: pass (google.com: domain of linux-kernel+bounces-83278-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <e88b76c5-1b13-4ad7-a97d-c34722cfde19@oracle.com>
Date: Tue, 27 Feb 2024 13:02:26 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] firmware_loader: Use init_utsname()->release
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: russ.weight@linux.dev, gregkh@linuxfoundation.org, rafael@kernel.org,
        linux-kernel@vger.kernel.org, masahiroy@kernel.org
References: <20240222145819.96646-1-john.g.garry@oracle.com>
 <Zddt-U-6SdxkxqmD@bombadil.infradead.org>
 <51483aaf-d64a-4eee-b256-ab126483ad6c@oracle.com>
 <Zdy9gKO5Q6K4IE8J@bombadil.infradead.org>
 <ZdzGF9bxLn3Slbgi@bombadil.infradead.org>
 <cb0c185c-54f8-4b43-856f-685cc5ed3fc4@oracle.com>
 <Zd3cz7yYezir-P7e@bombadil.infradead.org>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <Zd3cz7yYezir-P7e@bombadil.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?R1lrTjV3MUJNWmtqZWpsSmdhVnU0VENvNnN5R1p0YnJuNGowRkFmZ2NLMWc0?=
 =?utf-8?B?dnQ4Z2ZPL1czSk1YVHZPcHBGTGE3YnRscGN3RnlvWDc0U1FMZVlRM21TYkR2?=
 =?utf-8?B?bDB3ZjBpMVFCZW1ySGxmTGlHaklVcERtTUtCN3E3K1pMVzkya1ZzdXhBRyto?=
 =?utf-8?B?Rno1OENtczJZT25kTG41TVNkZ0pTYnMrOEF2Tm9XbFBWcFhzSXVld1BrZlNH?=
 =?utf-8?B?QkpTQXJZM3RqMzFuUHdmYU1hK3hBRDU5aVJKTVI4dVVoSE5IanZZTnlyZ2Vl?=
 =?utf-8?B?WmhVcWhLR1VYRXdDWnpjZFByR0hCZzVqaU5ET2Jzb2xaL3kyQmRrNkF0SVI5?=
 =?utf-8?B?ZVd4WFJjbys4Um40Nk84c3I0cXB6MUJBaXBuU1dmUmV2bGg3NlFXNThvVzl3?=
 =?utf-8?B?QytZZjZNNVN0c3h3WGVWNk9la0hEblNNbzl1SGRKK3VOT1RuR3JuWVJSc2Z0?=
 =?utf-8?B?NmE3dVY5TmhQQWZKSGgwR1BKQWZ4YjMrV0x6NGhrc0RGM20vU01sK1dmMlo1?=
 =?utf-8?B?Q0hvYzRIaUhtcUpPZGJEd05nTW5SczVYZEx2N3FqYzFZU0JMNEpUT0ROa2tN?=
 =?utf-8?B?Y01IRjJ0ZWRJbEVnR1RXY2dnLzJVY01JeWtLRHBndUdUWS9SVG0xNkNFY0lW?=
 =?utf-8?B?dGpUSXpROE0wck1YWCtpSkpURDNXTFdia1Fvc0RIdDVRNGJsL2tDVldveWY1?=
 =?utf-8?B?UG1ZVXRSdE5RMzV0RktXekJPWnZoV1hUdEFqU2VodEVwMEFDalhZbGsydmRQ?=
 =?utf-8?B?dkdtWGhOQXp1Szd1OUZCYlA3QTJaQ0tLN0tXUUZ5VG5ITUdlR3U1VFNZcWZ0?=
 =?utf-8?B?akJNZWV5cWN6UGRKeEplUnh2NjlsamRVWU82NVovcCtRUzE1UVozUmk2MHFD?=
 =?utf-8?B?dXg3Sm5pdnBCZmgzdFpzZUMrVkwxL2piUDVjdlBkemVyYnovWVRDcHRZVnhh?=
 =?utf-8?B?M3FGTVNXRW1XY1lvUjk4MmlPKzJPRzZlbnAzdisxS2lmdnV4elN5RHBoaWpE?=
 =?utf-8?B?WEZCMStVY0JLZ3MwdDc3U21mZFVXcloxY0gvWXhHdXlDTFNVWG1JOGpKM0lP?=
 =?utf-8?B?Vm1PUysxSWVUZFJKZkZJbFNBOWgzVVhBU084YmtJWUFYRU05S0h6UWNvZEtk?=
 =?utf-8?B?SlBSZm5iU1BGNFBKczJzUWRmNy9nb3dEMng2N0ZyeUdoTmJlTmNRY0pIMG01?=
 =?utf-8?B?aXgzRzhZUzBINGczZkV6RFNVeExRZlJMd3JVUWFuSUJjemJ1UDJBRXJ3b0tq?=
 =?utf-8?B?M0ExbDhaNVpiSCs2cHkwMlNzYlZVZElsYk5BK1NQR0d5Z0V3VmVuTXlDRkk0?=
 =?utf-8?B?dEFMbGxhdkhDWktxWlE5dklCUUt0SWV1QmwzamVsd2tTWm83NXBRMnAvQUcy?=
 =?utf-8?B?OWREVFcxNTRjbVMwTW1HR2lTT1NHWVFGUHVHQ1JjS2xCZXZsTk9UeVF3bEd6?=
 =?utf-8?B?WGJGOXdocXZWdVRHR2k0N0M4TEFMdEVaVWdYTzh0Y2t5RTZXLzRHODJvNkFE?=
 =?utf-8?B?TlhQeVMyemV5MjNGdnBUaXVSdlNEbjBack9xSWVXUC94WXppOTB5UWhUaVU5?=
 =?utf-8?B?V0JIZzFDbm9DSURtN2xJaVM3VVpoRUdUMDhkM1hITDVJcDQyUTJSVjdzdGto?=
 =?utf-8?B?b3NodHZLcDlTZ3lJNHduRGpMUmY3SGM4b2l1WFJTQW8ybEJCbTUrVWRML2Fu?=
 =?utf-8?B?LzR4RGhiTnBham5iOUJCdllNblpOU0NIQ0NTejllZnpteXliRThkeG1xdnZ1?=
 =?utf-8?B?eFBGSFNkaGFnSU4wUHRQYTk2TnE0UmoxczVzR0dBemYySDlaQzBZM2pBQVBC?=
 =?utf-8?B?OG9RbWdpK2V1NmlnNXRtVFBYUTNhOSt6UkljUzg1Q0oxcmhVMWFtbkpqL1J4?=
 =?utf-8?B?Q05TSUw3QXNhd1Z6RUNuSDNGWGtsL2pXcmh6MVpCWGhxbnAxcXlPcDNFM01x?=
 =?utf-8?B?RS9rUzZ2UWIzZGMrbFp1Y3JZNVE1ZWJaN0RUZDFHeDFXa2pGMDZYd1BPVjB6?=
 =?utf-8?B?RUMxQUJLNC82VlMyRVplTXhEdk5wdjVnd2RmZ0xDR3VKT2QrWktKeTBERHl1?=
 =?utf-8?B?VHI3RWhaTVNaSStjSXFLWUdZY1ZkS1pXejE3ZnFoalRDQkdmZWFkcEgxSWpv?=
 =?utf-8?Q?W6ud9+zglLPB91OUlbbq5vs/l?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	JX+rOIzgYpmRdU4ujidsRdTMpeA3VyLgxw9nMoc+H/CE94c/ALH2yvCfLw2LDcDOaOngCgyUtuIBtI8C5IE31ryawJXQaxiBYJXnrbeFwcqu8uPnZuR+CgW2jZQdF9nIoYkmbXQQG1rhG2kKrmU+Uv2RXWY1rAiWtQzXsrSeI6+5Fia2TIjOBppaWS4nylbphwPUn8k/RpPEY2/vksFv4MqWIXA+AT+6TLK6terRxNSSn5O2NHEF+VmUnBOezMOBvh+fhOWFVNA/fIixr3JJFrtqxSusYzPozj8wxRXmr80PzEA3UXOArlw9mOtvOjG8fKP0YlWnADUgZVuIdSjBKd/dagS2ra1dkvu+Nk1WO0zNllVX0P8JhvtTmQJNoIhK31iXpGYKXLUvw8uVpwNoNpHkTneoz0AqWDMqJ3uupVGc8OmxJe4u1lgTc5d249S03zQndb7LqK4RjKcKTparz8FL+RyeTV5PZgKlRgamIgEHLZI0sUwmRraMNxYDQty42d02S6RChzc88dsTdDmCSPAHg0QLO2eoQhg/S1TJTktQ1V2T327Hh9d+7FbmvvFl0kEM17tgbV6AiekUBhnNtShGXaFA8mP+WAy9bCrfk2k=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 309ce7c5-9fbe-4d93-2f5d-08dc37945ac2
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 13:02:29.9177
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UnwpfXf95Y6XdWs2wEWPkwgrjA6irDwX1a9XaDHPkVMHlIlv2ApWg2bEE2wCQ3CJCf6dRIgNOyEKBCj9xqhgzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4763
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-26_11,2024-02-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402270101
X-Proofpoint-ORIG-GUID: pN5lhhNR2Hl-KPwkuqjRAtt_uFC-cFFk
X-Proofpoint-GUID: pN5lhhNR2Hl-KPwkuqjRAtt_uFC-cFFk

On 27/02/2024 12:59, Luis Chamberlain wrote:
> On Mon, Feb 26, 2024 at 05:13:44PM +0000, John Garry wrote:
>> On 26/02/2024 17:10, Luis Chamberlain wrote:
>>>>> I am running this now, but it does not seem stable on a v6.8-rc5 baseline. I
>>>>> am seeing hangs. Are there any known issues?
>>>> I tested next-20240108 and so no issues.
>>>>
>>>> Lemme upgrade.
>>>>
>>>> Note you also need /lib/udev/rules.d/50-firmware.rules removed if
>>>> you have it.
>> I have this:
>> ubuntu@jgarry-ubuntu-bm5-instance-20230215-1843:~/mnt/linux2$ more
>> /lib/udev/rules.d/50-firmware.rules
>> # stub for immediately telling the kernel that userspace firmware loading
>> # failed; necessary to avoid long timeouts with
>> CONFIG_FW_LOADER_USER_HELPER=y
>> SUBSYSTEM=="firmware", ACTION=="add", ATTR{loading}="-1"
>>
>> So I can remove it.
> You can keep it on a distro use case, but for testing it is important to
> remove it.

ok

> 
>>> I don't see any hung tasks on next-20240226. Perhaps its with your
>>> config that it is triggered.
>> OK, I'll check again when I get a chance, but I am not so keen on checking
>> linux-next in general.
> What kernel are you seeing this issue on?

I was testing v6.8-rc5 last week

Thanks,
John