Received-SPF: pass (google.com: domain of linux-kernel+bounces-83304-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 27 Feb 2024 15:18:48 +0200 (EET)
To: Hans de Goede <hdegoede@redhat.com>
cc: Luiz Capitulino <luizcap@redhat.com>, shravankr@nvidia.com, 
    davthompson@nvidia.com, ndalvi@redhat.com, 
    LKML <linux-kernel@vger.kernel.org>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 0/2] platform/mellanox: mlxbf-pmc: Fix module loading
In-Reply-To: <eea32e56-2ea3-4a11-b1b9-8dd46dac7d72@redhat.com>
Message-ID: <4f6169e5-dee6-2188-f0a5-601b516be5fe@linux.intel.com>
References: <cover.1708635408.git.luizcap@redhat.com> <170895404513.2243.14840310263795846559.b4-ty@linux.intel.com> <def1a153-3cfb-431d-a7d2-a13bb7d65f4f@redhat.com> <29863354-4efe-d199-a9d4-7daf83f6cde9@linux.intel.com> <1608d86a-24e8-403b-b199-ce23f8411cfd@redhat.com>
 <eea32e56-2ea3-4a11-b1b9-8dd46dac7d72@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-606387716-1708967518=:1203"
Content-ID: <4d35180d-b1ce-72eb-222c-57381c067c0a@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-606387716-1708967518=:1203
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <79410032-c4ee-96e4-c036-57960da3b45a@linux.intel.com>

On Mon, 26 Feb 2024, Hans de Goede wrote:

> Hi Luiz,
>=20
> On 2/26/24 17:10, Luiz Capitulino wrote:
> > On 2024-02-26 11:04, Ilpo J=E4rvinen wrote:
> >> On Mon, 26 Feb 2024, Luiz Capitulino wrote:
> >>
> >>> On 2024-02-26 08:27, Ilpo J=E4rvinen wrote:
> >>>> On Thu, 22 Feb 2024 15:57:28 -0500, Luiz Capitulino wrote:
> >>>>
> >>>>> The mlxbf-pmc driver fails to load when the firmware reports a new =
but not
> >>>>> yet implemented performance block. I can reproduce this today with =
a
> >>>>> Bluefield-3 card and UEFI version 4.6.0-18-g7d063bb-BId13035, since=
 this
> >>>>> reports the new clock_measure performance block.
> >>>>>
> >>>>> This[1] patch from Shravan implements the clock_measure support and=
 will
> >>>>> solve the issue. But this series avoids the situation by ignoring a=
nd
> >>>>> logging unsupported performance blocks.
> >>>>>
> >>>>> [...]
> >>>>
> >>>>
> >>>> Thank you for your contribution, it has been applied to my local
> >>>> review-ilpo branch. Note it will show up in the public
> >>>> platform-drivers-x86/review-ilpo branch only once I've pushed my
> >>>> local branch there, which might take a while.
> >>>
> >>> Thank you Ilpo and thanks Hans for the review.
> >>>
> >>> The only detail is that we probably want this merged for 6.8 since
> >>> the driver doesn't currently load with the configuration mentioned ab=
ove.
> >>
> >> Oh, sorry, I missed the mention in the coverletter.
> >>
> >> So you'd want I drop these from review-ilpo branch as there they end
> >> up into for-next branch, and they should go through Hans instead who
> >> handles fixes branch for this cycle?
> >=20
> > If that's the path to get this series merged for this cycle then yes,
> > but let's see if Hans agrees (sorry that I didn't know this before
> > posting).
>=20
> Hmm, new hw enablement typically goes through -next and not to
> the current fixes branch. And AFAICT this is new hw enablement,
> not a regression / bug-fix.
>=20
> Is there any special reason why this needs to be in 6.8 ?

To me it sounded like fix to 1a218d312e65 ("platform/mellanox: mlxbf-pmc:=
=20
Add Mellanox BlueField PMC driver") and 423c3361855c ("platform/mellanox:=
=20
mlxbf-pmc: Add support for BlueField-3") although not explicitly marked as=
=20
such.

But I'm fine with taking these through for-next, it's relatively late into=
=20
the cycle already anyway.

> For RHEL kernels you can cherry-pick patches from -next
> as necessary.

It's also possible to send them later directly to stable folks once=20
Linus' tree has them after the next merge window if you feel they're=20
useful for stable inclusion.

> > One additional detail is that this series is on top of linux-next, whic=
h
> > has two additional mlxbf-pmc changes:
> >=20
> > * https://lore.kernel.org/lkml/39be055af3506ce6f843d11e45d71620f2a96e26=
=2E1707808180.git.shravankr@nvidia.com/
> > * https://lore.kernel.org/lkml/d8548c70339a29258a906b2b518e5c48f669795c=
=2E1707808180.git.shravankr@nvidia.com/
>=20
> Hmm, those are not small patches, any other reason
> why this really should go to -next IMHO.

Those two linked patches are totally unrelated.


--=20
 i.
--8323328-606387716-1708967518=:1203--