Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1914339rbb; Tue, 27 Feb 2024 05:26:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX1Zw5oQaulHkb1i813JRxfKInGaBhPK7Kmcn7qq0N8c3SDorD5Hd6DfuzSEXQeRyMwNldkoLrMn88qJR1OR8ffmJYt6JN0bk9I/yBvyA== X-Google-Smtp-Source: AGHT+IE9PQzvqiibZKwkYlYkXT14lURnRLJXTOnuzC02A4jK1LuO3vIqcTM4EBpEe2SeWOXdx9ID X-Received: by 2002:a17:906:408d:b0:a3c:5e17:1635 with SMTP id u13-20020a170906408d00b00a3c5e171635mr8669945ejj.30.1709040416073; Tue, 27 Feb 2024 05:26:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709040416; cv=pass; d=google.com; s=arc-20160816; b=OuhxIw/8CndTSRCUJR2FWNASond+ybbtRL5b3Mx1vsQoezRcqV2xYT2n3VhUtSc/HY v1ma9n5oacZYqZZmuOUQRvM/SrvcEqnmQL20tjXv8iNVCHUAo2HUIjoR78p9K+P2nZEd c+a3iDgrj+7i443jdvcWkFk3KFC9iD0FsXRsj63fNHWZOQi4KJ4Ib5AeIyJItKDgz8En SNWs6/hUdtXnBj1lNNqUUrSnD/Y8VyqfUovlZFxj6HcYRtqcUtOBEv0fkQ5ApkOaS8+o 6WJe3Q63DVs4WkTKCNxC6Dl/RQ++Sc/jUghQ9t8Hukf/4g71MV4EbQakTxFZrXNrmOBB fZEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6O2EJbJdRBLh8O5A756GdN8KsbWfqwHG0TYcwlqCvAY=; fh=ySC+V9JpwA6+rf+LDhTlZMOqdniCJ8wf6poEfnmYRvM=; b=ts4yP5RvEn6R+MK7RF/ariVF/61UZX12SVEALmff/8LJDIcHJHw+3R6N2J9abPFCma SuVWxwZBoaWpGl6gjV6dvFuVCa9btDBWizctoElfErIhnPySej08M/8ZYiNKGzjoMfNG E29fyd1bJU4y6T/jBDwbuJnTuCZXP9Uhko0toa9z5ziJT+xbdNg72LE02+mXt1kfTac4 VOoqZnbcnFGHzLNx6j8l3CcjKoUs4r1TNRxEM+3pd+cnWeWJtWuGYYuKx66Fnh5YoBSa T6a/S4+KsttxJT/H9S7xZJBNITbLXe3hr9yN02KrwoOzuZX70HVFmNOZSmWYcNBzux88 ZpTA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=t1pytJjH; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-82542-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82542-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id hp31-20020a1709073e1f00b00a3ecc630b63si729826ejc.143.2024.02.27.05.26.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 05:26:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82542-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=t1pytJjH; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-82542-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82542-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6B59F1F21BE4 for ; Tue, 27 Feb 2024 01:38:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 201DE6AB6; Tue, 27 Feb 2024 01:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="t1pytJjH" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0FD036E; Tue, 27 Feb 2024 01:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708997910; cv=none; b=T6rVpGWsJ5RKEDSChROuZhonn1Y57bGI6odALOoRYHAZZ/Nx2+zLnxSaimIph1OBxjSzlMftrScePiamotUbRAZmqlK4pwzfsnsTFf4C/6eLC99dHSdE6QlbSHGA/yEJU7b6QkUPsjMGJ7Q69g1waTaAot4oQeZ68ZN+QlVWhCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708997910; c=relaxed/simple; bh=k0H0CJGtSBEjrbnu+t5AAvrqCiCd2uYNjR6AcWRCYDc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IVOg/e2RUbljY3LQWXX6IW/n/NeqRP1bHnzUcwwaX6dTtsOM4VqxVkY1106zaIJ2eVBofoDrEZhzTdMSiMp3Ubkc+LaIPDiqvMtIogf/AZYgqCBtt3VWN+L3CT/xCsJgJAb2Fh8PxR/6ZRvfiV9D3U/B71fu1huOGN134q4N39o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=t1pytJjH; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=6O2EJbJdRBLh8O5A756GdN8KsbWfqwHG0TYcwlqCvAY=; b=t1pytJjHOLRfj/ftDXY5eXf07I aX+bujLMpUynEMOV93t/HESb6QRxs5iqFYUynkwsq0oPUp5LoZXyey7ite1PFep/gpxZINXzdYAVB ldrjbnOPVmIVrni80ws7SY7/srk4Pc7iOIewjPCHtFl5Bu+x2fNgvgWzIqOnHh2U7SI4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1remQa-008mrn-OT; Tue, 27 Feb 2024 02:38:40 +0100 Date: Tue, 27 Feb 2024 02:38:40 +0100 From: Andrew Lunn To: Raju Lakkaraju Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, bryan.whitehead@microchip.com, richardcochran@gmail.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net 1/3] net: lan743x: disable WOL upon resume to restore full data path operation Message-ID: References: <20240226080934.46003-1-Raju.Lakkaraju@microchip.com> <20240226080934.46003-2-Raju.Lakkaraju@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226080934.46003-2-Raju.Lakkaraju@microchip.com> On Mon, Feb 26, 2024 at 01:39:32PM +0530, Raju Lakkaraju wrote: > In order for datapath to be restored to normal functionality after resume > we disable all wakeup events. Additionally we clear all W1C status bits by > writing 1's to them. Just to make sure i'm understanding this correctly, you are just clearing that there was been a WoL wakeup. The WoL configuration is not cleared, so i could suspend the device again and wake it up with WoL. There is no need for me to use ethtool, the WoL configuration is preserved. Andrew