Received-SPF: pass (google.com: domain of linux-kernel+bounces-83401-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 27 Feb 2024 15:29:17 +0100
From: Heiko Carstens <hca@linux.ibm.com>
To: "Jason J. Herne" <jjherne@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        pasic@linux.ibm.com, akrowiak@linux.ibm.com, borntraeger@de.ibm.com,
        agordeev@linux.ibm.com, gor@linux.ibm.com
Subject: Re: [PATCH] s390/vfio-ap: handle hardware checkstop state on queue
 reset operation
Message-ID: <20240227142917.6127-B-hca@linux.ibm.com>
References: <20240215153144.14747-1-jjherne@linux.ibm.com>
 <3b5a812d-3832-6f34-a528-c67e59d76e65@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3b5a812d-3832-6f34-a528-c67e59d76e65@linux.ibm.com>

On Tue, Feb 27, 2024 at 08:25:21AM -0500, Jason J. Herne wrote:
> Polite Ping :)
> 
> Patch already has R-b.
> Thanks for taking a look.
> 
> On 2/15/24 10:31 AM, Jason J. Herne wrote:
> > Update vfio_ap_mdev_reset_queue() to handle an unexpected checkstop (hardware error) the
> > same as the deconfigured case. This prevents unexpected and unhelpful warnings in the
> > event of a hardware error.
> > 
> > We also stop lying about a queue's reset response code. This was originally done so we
> > could force vfio_ap_mdev_filter_matrix to pass a deconfigured device through to the guest
> > for the hotplug scenario. vfio_ap_mdev_filter_matrix is instead modified to allow
> > passthrough for all queues with reset state normal, deconfigured, or checkstopped. In the
> > checkstopped case we choose to pass the device through and let the error state be
> > reflected at the guest level.
> > 
> > Signed-off-by: Jason J. Herne <jjherne@linux.ibm.com>
> > Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
> > ---
> >   drivers/s390/crypto/vfio_ap_ops.c | 35 ++++++++++++++++---------------
> >   1 file changed, 18 insertions(+), 17 deletions(-)

Applied, thanks!