Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbYABRrP (ORCPT ); Wed, 2 Jan 2008 12:47:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751763AbYABRrA (ORCPT ); Wed, 2 Jan 2008 12:47:00 -0500 Received: from az33egw02.freescale.net ([192.88.158.103]:55594 "EHLO az33egw02.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbYABRrA (ORCPT ); Wed, 2 Jan 2008 12:47:00 -0500 Date: Wed, 2 Jan 2008 11:45:58 -0600 From: Scott Wood To: Jochen Friedrich Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, Vitaly Bordug Subject: Re: [PATCH/RFC] Add support for freescale watchdog to CPM serial driver. Message-ID: <20080102174558.GA4398@loki.buserror.net> References: <477513CC.3060109@scram.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <477513CC.3060109@scram.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 14 On Fri, Dec 28, 2007 at 04:18:36PM +0100, Jochen Friedrich wrote: > If a freescale watchdog device node is present, reset the watchdog > while waiting for serial input. Hmm... I don't like combining the watchdog and serial code together. What if some other serial device is used with this watchdog? The serial driver should only have to call an externally provided poke_watchdog() function. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/