To: FUJITA Tomonori <tomof@acm.org>
Cc: David Dillow <dillowda@ornl.gov>, linux-kernel@vger.kernel.org,
       general@lists.openfabrics.org, pw@osc.edu,
       fujita.tomonori@lab.ntt.co.jp
Subject: Re: list corruption on ib_srp load in v2.6.24-rc5
References: <1198273973.9979.34.camel@lap75545.ornl.gov>
	<1198275532.9979.43.camel@lap75545.ornl.gov>
	<20071223014407L.tomof@acm.org>
	<1198689251.25003.2.camel@lap75545.ornl.gov>
From: Roland Dreier <rdreier@cisco.com>
Date: Wed, 02 Jan 2008 09:51:38 -0800
In-Reply-To: <1198689251.25003.2.camel@lap75545.ornl.gov> (David Dillow's message of "Wed, 26 Dec 2007 12:14:11 -0500")
Message-ID: <adaprwkundh.fsf@cisco.com>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.20 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1139
Lines: 29

 > > Can you try this?
 > 
 > That patched oopsed in scsi_remove_host(), but reversing the order has
 > survived over 500 insert/probe/remove cycles.
 > 
 > Tested-by: David Dillow <dillowda@ornl.gov>
 > ---
 > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
 > index 950228f..77e8b90 100644
 > --- a/drivers/infiniband/ulp/srp/ib_srp.c
 > +++ b/drivers/infiniband/ulp/srp/ib_srp.c
 > @@ -2054,6 +2054,7 @@ static void srp_remove_one(struct ib_device *device)
 >  		list_for_each_entry_safe(target, tmp_target,
 >  					 &host->target_list, list) {
 >  			scsi_remove_host(target->scsi_host);
 > +			srp_remove_host(target->scsi_host);
 >  			srp_disconnect_target(target);

Where do we stand on this?  What is the right place to put the
srp_remove_host?  Is there a bug somewhere else?

I'd like to get this fixed before 2.6.24 final comes out...

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/