Received-SPF: pass (google.com: domain of linux-kernel+bounces-83471-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <655ba4a1-4f73-4ef4-aff3-0b439e65a9c9@kernel.org>
Date: Tue, 27 Feb 2024 08:06:35 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Net:cache didn't flush when ipv6 rule changed
Content-Language: en-US
To: =?UTF-8?B?TGVuYSBXYW5nICjnjovlqJwp?= <Lena.Wang@mediatek.com>,
 "davem@davemloft.net" <davem@davemloft.net>,
 "kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com"
 <pabeni@redhat.com>, "edumazet@google.com" <edumazet@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 =?UTF-8?B?U2hpbWluZyBDaGVuZyAo5oiQ6K+X5piOKQ==?= <Shiming.Cheng@mediatek.com>
References: <3efcbaf0872481d1a842eb9e18fa368b4b94d940.camel@mediatek.com>
From: David Ahern <dsahern@kernel.org>
In-Reply-To: <3efcbaf0872481d1a842eb9e18fa368b4b94d940.camel@mediatek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 2/26/24 6:11 AM, Lena Wang (王娜) wrote:

> diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c
> index 7523c4baef35..bec2cf4436e1 100644
> --- a/net/ipv6/fib6_rules.c
> +++ b/net/ipv6/fib6_rules.c
> @@ -449,6 +449,15 @@ static size_t fib6_rule_nlmsg_payload(struct
> fib_rule *rule)
>                + nla_total_size(16); /* src */
>  }
> 
> +static void fib6_rule_flush_cache(struct fib_rules_ops *ops)
> +{
> +       struct net *net = ops->fro_net;
> +       if (!net)
> +               return;
> +       rt_genid_bump_ipv6(net);
> +       return;
> +}

This can be written as a 1-liner - the same way as the IPv4 flush cache:

static void fib6_rule_flush_cache(struct fib_rules_ops *ops)
{
	rt_genid_bump_ipv6(ops->fro_net);
}


> +
>  static const struct fib_rules_ops __net_initconst
> fib6_rules_ops_template = {
>         .family                 = AF_INET6,
>         .rule_size              = sizeof(struct fib6_rule),
> @@ -461,6 +470,7 @@ static const struct fib_rules_ops __net_initconst
> fib6_rules_ops_template = {
>         .compare                = fib6_rule_compare,
>         .fill                   = fib6_rule_fill,
>         .nlmsg_payload          = fib6_rule_nlmsg_payload,
> +       .flush_cache    = fib6_rule_flush_cache,

this should be tabs and the columns should align with existing code.


>         .nlgroup                = RTNLGRP_IPV6_RULE,
>         .owner                  = THIS_MODULE,
>         .fro_net                = &init_net,
> --
> 2.18.0