Message-ID: <477BD517.2090301@kernel.org>
Date: Wed, 02 Jan 2008 10:16:55 -0800
From: "H. Peter Anvin" <hpa@kernel.org>
Organization: Linux Kernel Organization, Inc.
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Mike Frysinger <vapier@gentoo.org>
CC: Adrian Bunk <bunk@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] linux/{socket,stat}.h: change __GLIBC__ cruft to __KLIBC__
References: <200801020937.50770.vapier@gentoo.org> <20080102151335.GA15898@does.not.exist> <200801021047.59006.vapier@gentoo.org>
In-Reply-To: <200801021047.59006.vapier@gentoo.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1185
Lines: 32

Mike Frysinger wrote:
>>>
>>> -#if defined(__KERNEL__) || !defined(__GLIBC__) || (__GLIBC__ < 2)
>>> +#if defined(__KERNEL__) || defined(__KLIBC__)
>>> ...
>> This changes the semantics from "!glibc" to "klibc".
> 
> that's the point
> 
>> I'm a bit worried that such changes might break some of the other
>> libc's people use on Linux.
> 
> such libc's are broken and it isnt the kernel's problem to cater to broken 
> libc's.  the problem is that these headers are breaking things *now* for 
> valid libc's that are not glibc.  removal of __GBLIC__ was already accepted 
> once but reverted for klibc.
> -mike

Either of these really is wrong... it's the userspace which should ask 
for what should be imported; the kernel shouldn't hard-code which libcs 
want what.

I just posted a patch to the netdev list which splits the top of 
<linux/socket.h> out into <linux/sockaddr.h>, userspace can choose to 
include one or the other.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/