Received-SPF: pass (google.com: domain of linux-kernel+bounces-83499-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 27 Feb 2024 15:24:15 +0000
From: Sudeep Holla <sudeep.holla@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Oleksii Moisieiev <oleksii_moisieiev@epam.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v4 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
 protocol basic support
Message-ID: <20240227152415.xpa3y6226vrqfguk@bogus>
References: <20240223-pinctrl-scmi-v4-0-10eb5a379274@nxp.com>
 <20240223-pinctrl-scmi-v4-3-10eb5a379274@nxp.com>
 <CACRpkdZLuWwecacBAimT=Vj67dGabzBH-7aaqzoyj1B1sY6o_A@mail.gmail.com>
 <ZdhYc90uy7yuYrx2@pluto>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZdhYc90uy7yuYrx2@pluto>

On Fri, Feb 23, 2024 at 08:33:55AM +0000, Cristian Marussi wrote:
> On Fri, Feb 23, 2024 at 09:28:12AM +0100, Linus Walleij wrote:
> > On Fri, Feb 23, 2024 at 2:08 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
> > 
> > > From: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > >
> > > Add basic implementation of the SCMI v3.2 pincontrol protocol.
> > >
> > > Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
> > > Tested-by: Cristian Marussi <cristian.marussi@arm.com>
> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > Co-developed-by: Peng Fan <peng.fan@nxp.com>
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > 
> > This looks ripe for merging for me, there are clearly dependencies in the SCMI
> > firmware tree so I can't apply this to the pin control tree, but if
> > someone creates
> > an immutable branch from the SCMI firmware repo (based off v6.8-rc1 or so)
> > I'm happy to also pull the branch into pin control.
> > 
> 
> Well, AFAIK there is another upcoming change in the v3.2 SCMI spec and
> I am not sure if this series accounts for it...indeed the v3.2 -bet4 was
> still pending fr feedback AFAIK (and I doubt latest changes are in since
> they have been discussed like yesterday...)....but I maybe wrong, I will
> chase for the final spec and look into this to verify if it is
> compliant...
> 
> Anyway, given the particularly long history of changes in PINCTRL v3.2
> SCMI I would wait to have the final spec officially frozen at this
> point before merging....
> 

+1, this is one reason I have been avoiding to look at pinmux changes yet.
I want to see the spec changes settle to be comfortable to merge any changes.
I think it should be fine as v6.10 material.

-- 
Regards,
Sudeep