Received-SPF: pass (google.com: domain of linux-kernel+bounces-83567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6962061f-d0c9-f3d3-ca1a-222f63653800@quicinc.com>
Date: Tue, 27 Feb 2024 21:36:19 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] thermal/drivers/tsens: Add suspend to RAM support for
 tsens
Content-Language: en-US
To: Amit Kucheria <amitk@kernel.org>
CC: Konrad Dybcio <konrad.dybcio@linaro.org>,
        Thara Gopinath
	<thara.gopinath@gmail.com>,
        Bjorn Andersson <andersson@kernel.org>,
        "Rafael J
 . Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Zhang Rui <rui.zhang@intel.com>, Lukasz Luba <lukasz.luba@arm.com>,
        <linux-pm@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_manafm@quicinc.com>
References: <20240122100726.16993-1-quic_priyjain@quicinc.com>
 <548e2f24-a51e-4593-9463-09506488c70e@linaro.org>
 <f415a8cd-4cae-d7c3-60fc-674b3e660f6b@quicinc.com>
 <aeae2e69-8407-4d90-9d16-27798e2f3248@linaro.org>
 <be69e0a6-fdc8-c24b-9beb-adaac4a97776@quicinc.com>
 <CAHLCerNx4KxzmQF8HmTTFr+W7xn5vubA=Jcg4Kwyk=cCJ4w+Wg@mail.gmail.com>
From: Priyansh Jain <quic_priyjain@quicinc.com>
In-Reply-To: <CAHLCerNx4KxzmQF8HmTTFr+W7xn5vubA=Jcg4Kwyk=cCJ4w+Wg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 1/28/2024 1:41 AM, Amit Kucheria wrote:
> On Wed, Jan 24, 2024 at 8:55 PM Priyansh Jain <quic_priyjain@quicinc.com> wrote:
>>
>>
>>
>> On 1/24/2024 6:04 PM, Konrad Dybcio wrote:
>>>
>>>
>>> On 1/24/24 11:42, Priyansh Jain wrote:
> 
>>>>
>>>> As part of suspend to RAM, tsens hardware will be turned off and it
>>>> cannot generate any interrupt.Also system doesn't want to abort
>>>> suspend to RAM due to tsens interrupts since system is already going
>>>> into lowest
>>>> power state. Hence disabling tsens interrupt during suspend to RAM
>>>> callback.
>>>
>>> Is that a hardware limitation, or a software design choice? I'm not
>>> sure I want my phone to have thermal notifications disabled when
>>> it's suspended.
>>
>>> Konrad
>>
>> As part of suspend to RAM , entire SOC will be off, this mode (suspend
>> to RAM) is not intended for Mobile product. Tsens interrupts are not
>> disabled as part of suspend to idle(suspend mode for mobile).
> 
> You should hide the callbacks behind the CONFIG_SUSPEND Kconfig option
> so that it only gets enabled when S2R is enabled.

Yes i will take care of this in next version.

Priyansh