Received-SPF: pass (google.com: domain of linux-kernel+bounces-83290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 27 Feb 2024 15:06:37 +0200 (EET)
To: Armin Wolf <W_Armin@gmx.de>
cc: Shyam-sundar.S-k@amd.com, 
    Mika Westerberg <mika.westerberg@linux.intel.com>, 
    sathyanarayanan.kuppuswamy@linux.intel.com, 
    Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] platform/x86: intel_scu_ipcutil: Make scu
 static
In-Reply-To: <20240223163901.13504-3-W_Armin@gmx.de>
Message-ID: <53ba6c16-f0af-44ee-73c5-f6b983ed6420@linux.intel.com>
References: <20240223163901.13504-1-W_Armin@gmx.de> <20240223163901.13504-3-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 23 Feb 2024, Armin Wolf wrote:

> The variable is only used internally and has no external users,
> so it should me made static.
> 
> Compile-tested only.
> 
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> Changes since v1:
> - remove Fixes tag
> - add Reviewed-by tag
> ---
>  drivers/platform/x86/intel_scu_ipcutil.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c
> index b7c10c15a3d6..7d87cbd4b9c6 100644
> --- a/drivers/platform/x86/intel_scu_ipcutil.c
> +++ b/drivers/platform/x86/intel_scu_ipcutil.c
> @@ -22,7 +22,7 @@
> 
>  static int major;
> 
> -struct intel_scu_ipc_dev *scu;
> +static struct intel_scu_ipc_dev *scu;
>  static DEFINE_MUTEX(scu_lock);
> 
>  /* IOCTL commands */

Thanks, I took this 3/3 and 1/3 into review-ilpo.

Please check the comment I raised against 2/3.

-- 
 i.