Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2022653rbb; Tue, 27 Feb 2024 08:18:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXubnmKT4U9VPzfQ8N8iYnFwODWmovjuw3p3H31BaH7X+siOXIeGa+h+bXLeJBybbg4r1vUeyWT1Oa/SWojLn7iz2JZRX/RA3nwDy2Tnw== X-Google-Smtp-Source: AGHT+IHSUTWiTiWksllxeGpqtFieQPuhtdnW/1RVR0K8kiDGHuA8I7qAAJqpr4ZNmvSJKlv9tv6H X-Received: by 2002:a17:906:3507:b0:a43:9f21:1a08 with SMTP id r7-20020a170906350700b00a439f211a08mr1844040eja.63.1709050736864; Tue, 27 Feb 2024 08:18:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709050736; cv=pass; d=google.com; s=arc-20160816; b=CtfP7XFy6vDAX0nZB7aipsYvuQKytfBgQGN5z75eKmeVa66GSINXoH6qO9OVk9yHjf /mK2kYOJ3lNFDDn/DmcjXoQYOm7OWj+iCSONFhPuTJSJmWhvfsXiKIWKYNpS1usA3R5+ TKgXtc255YxHjoDjYFlP/4kwF2EPnStfxg6T2Mbv4+nC9p/OxCx1Ov7TI7hC0tGPUlP/ f9r6R/PB5ZfVpZ5Eaf/t+Fehb2cLpn/mdlHeNQp3jmznArD33XHcZzngc4Uhf6fj864s B1Zxa7p4PI+k+DDTl6rENLvZUIzG+EncFZ7JIEG2VIxZqMAL04PsIdORHS692mJZAI/E 2mWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xy+YBUBt7Fbhm/C9bGcKgBSMqkXQX+ab81pGfZyrjfo=; fh=SqVNk/AEsshgNi9P/J/8peWi9QS/qxYlXeemt/D/8xE=; b=oG5TEoDw2sB97cWBInHNQyNQCGlIwGLTMfHVV3hKu1qYn1iuHGD/PnswCgYcx+RO4I rqK5Ul8IUqhWCTB5moen2SvfZ58h5mOQeRTch+n5k9mNIj4px3oo3RkH/0xBhbjP2HiP sdKBZ5uEWzTBzBNq47wjxDrjCXkxixE8Rv1BH8TCmuLmfpu4RZDK891GXGuCEYXB8eBA VO4/NDRHJxxoZO2WoqnQbstR5/f82KdKJ5X+viDrw7n3CQJT74ba5S3IM3zkq/L7tVKz 1kg+gB8gZ8Crb+ozSgDwyF9NFhT9sEpMu/+FFfrj9gJmWDDIMBGKDBXgZqIk9g4/cyy7 FO2Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=GnAkpX+r; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-83586-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83586-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id d23-20020a170906641700b00a3e19cc0172si820567ejm.1004.2024.02.27.08.18.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 08:18:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83586-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=GnAkpX+r; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-83586-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83586-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9C4AA1F2162E for ; Tue, 27 Feb 2024 16:18:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7016C148FF6; Tue, 27 Feb 2024 16:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="GnAkpX+r" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4EE01482F5; Tue, 27 Feb 2024 16:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709050715; cv=none; b=QIKQFwjv8XuyGzVHFXzJr+/E10tNIh0gatgbwKJxP6ASiP0nGXiu9tD7toUlil5w7A4phgGTpU4DYpyf07P1lOJWV0KOuyAy71AogAhuEGYM5t5vcPISuJF/MoW3wh4HPvhMHV4mfA40JjJjWewcPIMSrK6ge7rnW8C3U6Xb++I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709050715; c=relaxed/simple; bh=8jzB12U7eaeJ7iZKhIrGbomEj2GPEGQMeudR/3OpjlE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LJxozJqaL7OSdHDmWJQAJNnKKWIgJf4ECosuodurGDUapvWz3l3DXSz0CUR/lYRA9DXFiAjTHXYEEfYhWzQc+Q5BMhze8/Oy3/68GcOknDmYvROW/VNhULx5kM3+cIQHTeMC64asMTk+wZjViGG4EHwXH4Dbh2RN4CvuMMVZwkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=GnAkpX+r; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=xy+YBUBt7Fbhm/C9bGcKgBSMqkXQX+ab81pGfZyrjfo=; b=GnAkpX+rSx4xKNsjYNU/5dh8+L ZtcOCzuiRICGQL9fbS0mW5+I5PMioYJUj3Y73l1cEiIM/Qn9/aphayHRnA3v5wQuchh2GvHxdzv7c PHHEkNd+LBOfM1jrPr4sF8yKryKD8iAHKQB6K4Tx2OTtGaoOmviC88Mu3EDFMoTSNq24=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rf0AC-008rvK-Ni; Tue, 27 Feb 2024 17:18:40 +0100 Date: Tue, 27 Feb 2024 17:18:40 +0100 From: Andrew Lunn To: Bastien Curutchet Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pavel Machek , Lee Jones , Richard Cochran , Heiner Kallweit , Russell King , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, Thomas Petazzoni , herve.codina@bootlin.com, maxime.chevallier@bootlin.com, christophercordahi@nanometrics.ca Subject: Re: [PATCH v2 6/6] net: phy: DP83640: Add fiber mode enabling/disabling from device tree Message-ID: References: <20240227093945.21525-1-bastien.curutchet@bootlin.com> <20240227093945.21525-7-bastien.curutchet@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240227093945.21525-7-bastien.curutchet@bootlin.com> On Tue, Feb 27, 2024 at 10:39:45AM +0100, Bastien Curutchet wrote: > The PHY is able to use copper or fiber. The fiber mode can be enabled or > disabled by hardware strap. If hardware strap is incorrect, PHY can't > establish link. > > Add a DT attribute 'ti,fiber-mode' that can be use to override the > hardware strap configuration. If the property is not present, hardware > strap configuration is left as is. How have you tested this? Do you have a RDK with it connected to an SFP cage? Andrew