Received-SPF: pass (google.com: domain of linux-kernel+bounces-83595-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 27 Feb 2024 17:25:46 +0100
From: Maxime Ripard <mripard@kernel.org>
To: Marco Pagani <marpagan@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, 
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, 
	Daniel Vetter <daniel@ffwll.ch>, Guenter Roeck <linux@roeck-us.net>, 
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/test/shmem: set a DMA mask for the mock device
Message-ID: <ut2c26ig4e6pbtvszmfm34h4ev3oflwkz3mwkjtqaxlpethwfk@w3bnhg4iw4mn>
References: <20240226110028.28009-1-marpagan@redhat.com>
 <d65v7jy4natx22lacw6awmg6iecfr2hqk3puuz3qem5dfsvj2x@hh6vp265hm5p>
 <03915b45-94f6-4863-8b11-d0e9dbd0283a@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tlwdh5nyakxrjjyg"
Content-Disposition: inline
In-Reply-To: <03915b45-94f6-4863-8b11-d0e9dbd0283a@redhat.com>


--tlwdh5nyakxrjjyg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Feb 26, 2024 at 04:48:51PM +0100, Marco Pagani wrote:
>=20
> On 2024-02-26 12:26, Maxime Ripard wrote:
> > Hi,
> >=20
> > On Mon, Feb 26, 2024 at 12:00:27PM +0100, Marco Pagani wrote:
> >> Set a DMA mask for the mock device to avoid warnings generated in
> >> dma_map_sgtable().
> >>
> >> Reported-by: Guenter Roeck <linux@roeck-us.net>
> >> Signed-off-by: Marco Pagani <marpagan@redhat.com>
> >=20
> > I've submitted last week this patch:
> > https://lore.kernel.org/all/20240221125324.718192-1-mripard@kernel.org/
> >=20
> > Which should be equivalent, but fixes the issue for all users in the
> > tree.
>=20
> Hi, thanks for letting me know. Fixing this issue for all DRM tests that =
were
> using platform devices through the helpers makes perfect sense to me. I'm=
 a
> little more thoughtful about setting the mask for all KUnit tests that us=
e fake
> devices since there may be specific use cases. Just one curiosity: why se=
tting
> the default mask manually instead of using one of the dma_set_*() functio=
ns?

I think the (well, mine at least) expectation is that a kunit device is
a device that can be used in all reasonable contexts. Setting up the
device to be able to use any DMA-related function (or functions that use
a DMA-related function) makes total sense to me.

But it's a discussion worth having I think, so it would make sense to
raise this point with the kunit maintainers if you feel like it.

Maxime

--tlwdh5nyakxrjjyg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZd4NCgAKCRDj7w1vZxhR
xZ4CAQCcNmBJJDTGi+MxZl1jfrDVmne9K9B9qaLLqBPB1CQWNgEAiFN54hD4kHil
62wFp/FuTUoo21Ua0wrq3nbEqpU+1Qg=
=Y9s/
-----END PGP SIGNATURE-----

--tlwdh5nyakxrjjyg--