Received-SPF: pass (google.com: domain of linux-kernel+bounces-83617-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ac887a4a-5647-468a-9696-4a3909e42561@intel.com>
Date: Tue, 27 Feb 2024 08:36:18 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 0/3] selftests/resctrl: Simplify test cleanup functions
To: <shuah@kernel.org>
CC: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, "Yu, Fenghua" <fenghua.yu@intel.com>, Maciej
 Wieczor-Retman <maciej.wieczor-retman@intel.com>
References: <cover.1709018050.git.maciej.wieczor-retman@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <cover.1709018050.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjhTbjJubFg3dXNIYzE0ZzV5K0R0SEFTN2YrdWV5a05iUHMxaEdkMldLelpQ?=
 =?utf-8?B?L3gyVTE1NXlqZFQyZEZmUHg5NDBkYUhwdmtQYWxJWnFZTnYvcGlFaTFxbUwr?=
 =?utf-8?B?TnlTTVhLeFdqenRKZXc3SHgxdXVqZVFSbGFMRG1TZktUdUxDaVdwZFV2UUsy?=
 =?utf-8?B?NXE1S3Z4ZUk0bTJVdUFnQStoOEo4dUVYVVdXMjRGUEZIZ0xkQmNWK3FYTFVx?=
 =?utf-8?B?djNlbzJxb0lVTk9nOWFtR2RSU0tWMFQ2Vk5aVHhOVGphaVNadUYwRTRFdlo3?=
 =?utf-8?B?UlNqeWtCTEt0SVJvK3pNSHhQUUllN0t3NkpjcWNNTE1DYzRMc0svTSttY0NO?=
 =?utf-8?B?Z0JhYzRCVzJZTWRkY0NKamJlU1lGaHYyWTVibjRGNkFUQnd4TXczOVYrSmwz?=
 =?utf-8?B?UTlqWXhaUndXdDFhYTNoMnhyakx6MHBjWU5IbnFKSXJSNS96VnpGNGEzaG5v?=
 =?utf-8?B?WWVzckszVVNkRk5iNTNvTmRheWptdmhzUWZTdS9ZTXNVckl5MG1EREVyUXZW?=
 =?utf-8?B?WGRwYnhjRk9KR0tiWmpIaTN3Zi96bnB6a2FKcHNxTXFaVk02UGNKS2xwR3Br?=
 =?utf-8?B?VWFBRnNZbXd0Uk1Lb3JGeEdDck9wSHFDUVJNNklYMWgwSERkL25ENXhJb0Vx?=
 =?utf-8?B?Uk1qNVJobHpubVI2UmFKQUk3eG9HR0JLR1BLdFZKbWlwNFkySUhrYTIrSDgy?=
 =?utf-8?B?VzRCdFhnMTVXM0s5UGp4OFROc2R0VFhCaHNGWllsV0JhdHJkeURQTzRFWjR5?=
 =?utf-8?B?UFJvS25jT0VyYjlnaFdKY0hSQ3BwamNTQXRZWExOSUlzbXN6THd2d2dMRjYz?=
 =?utf-8?B?V05jNjRpNWZob1dLWmZTTzdWbzJaRlFKLzRyalpheEJiODc0Q3pKMFdLZGV1?=
 =?utf-8?B?VlJxYmtLdEFHb29pYjF3QmU4STQxTDdFMEREeDM1M0RCYWJpVk1WWkM5K3Ir?=
 =?utf-8?B?MjJGMWFOclJVL0NmcTJIL1NCOUpSQkYrTG5FNEp0clFXWjdkMDF6VFFHUnBH?=
 =?utf-8?B?TUNCTklLTDB0aEcrNzZKK0FlcXBkWDc5Vk5BSjRIWlhBQ3lmOERYY09xRXBk?=
 =?utf-8?B?R1VEWW1SZkhmTEVsQURkUm82UmZ6SC8vYS81Z0hqb3hoTkc1Q1UwM0xvOWJs?=
 =?utf-8?B?aEhaSmlRSFdwMEFBK1BGZEhFbllCcUZmOHUxTStHS0J5Vm9PTGxCZVgzV1Vp?=
 =?utf-8?B?eWFsa1VBUEwrWURXWCtld0FZcE1LcTBicGx1d1RaZ2VMU1RzVTFkN1YvVFg1?=
 =?utf-8?B?VU9mYUw5WXJhNUV3QS8yMHB5ZWVDaS93bzR3MkdHME5SQWlXeXhWN29vQXlS?=
 =?utf-8?B?RWF2c3NyV2dXYjFKWTkwY3JidFc2b2JwN29KeXg4SUJpbHNaUzV1OGdjN0x1?=
 =?utf-8?B?cDVrblZCVHhBa1c3dytYRGNzVmp6RU8ycFZYWHJsRGpNcEpLME50WHp5ZDFZ?=
 =?utf-8?B?QWdoMXJPVUFiNXh1dG9YWFh5SzR2K2hZT2tEZmh3T3dIMU5jSlJNMmpZaEVw?=
 =?utf-8?B?S3MvV1c5QWV4bmxMYnJkd1owWGdoVDUvMnJ6TGcxOXFlTnFDVHVXdER4UmYr?=
 =?utf-8?B?QnhMU3NId1BYaHJyYi93TVcvZDNmMHVlR0ZXYno4MkNPeHdZNEdrQU9vaG9o?=
 =?utf-8?B?bnoydURsQXpZZ0JiTklJa1pvekk3Wkl4c053ZmVONWkvODByVTF3cWVrU0JU?=
 =?utf-8?B?T0xobjZudER0NWFld2dOSWNDcUJLbVJxWDEweUsrRkVCcXh4UFpETndFUVQ2?=
 =?utf-8?B?ZHhFUGc5SGhrNU96dTBKK3hNZjlWNW5zb3FrWXBaRFJQcUJweFQwVXJ1N0dj?=
 =?utf-8?B?QkNDTmFPWWEvWDErcUFxb3FDTjkybm1OaERrQkRkaThtaUMxVjF0WDdSRFNQ?=
 =?utf-8?B?TEZkamVTRkE4ZVNGVFk4ZzZ6b0tUOG9kaEl1TzVRejdxb0d4QWY4UlNpUDE2?=
 =?utf-8?B?ZlNNcTJpWEh4RFB6aXRFeXpxVTB1Z2M2bUVCZXQ5WXg0bmhFMnVDM2VPZ2NK?=
 =?utf-8?B?dnBSZUdubzVpekpJb2lwTlNqa29uZTJ1L2V4ZU1qNTcxYzNPLy81TSs1NmYx?=
 =?utf-8?B?NzF6TzFQOExIeU1DL3VLa0ZqV1NmVWxyVW90TnZ5aFZwWm1ybTZrTTF5Y0h3?=
 =?utf-8?B?N2dGajBGTENrL09YZ1NUT2JyTzIxYVFFYytmRGZSbkFtL0dNWVdMUUJGTHhB?=
 =?utf-8?B?RHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e2e7a8c1-3d4e-418f-392f-08dc37b23a53
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 16:36:20.3753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WWjuFvEEPtot2PxIMP7U4RKA0irsNEwIYtv7hUBUFZrvm/38Qw0MtrTBoqNCIEIqON9WUbnCN4JLiCOm4onUnWzxBfKF9fLD5LOO+wH3NIY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8408
X-OriginatorOrg: intel.com

Hi Shuah,

Could you please consider this series for inclusion? I do admit that
there has been a lot of resctrl selftest work recently. This should be
it for a while as new work is still being worked on. 

Thank you very much.

Reinette

On 2/26/2024 11:21 PM, Maciej Wieczor-Retman wrote:
> Cleaning up after tests is implemented separately for individual tests
> and called at the end of each test execution. Since these functions are
> very similar and a more generalized test framework was introduced a
> function pointer in the resctrl_test struct can be used to reduce the
> amount of function calls.
> 
> These functions are also all called in the ctrl-c handler because the
> handler isn't aware which test is currently running. Since the handler
> is implemented with a sigaction no function parameters can be passed
> there but information about what test is currently running can be passed
> with a global variable.
> 
> Series applies cleanly on top of kselftests/next.
> 
> Changelog v5:
> - Rebase onto kselftests/next.
> - Add Reinette's reviewed-by tag.
> 
> Changelog v4:
> - Check current_test pointer and reset it in signal unregistering.
> - Move cleanup call to test_cleanup function.
> 
> Changelog v3:
> - Make current_test static.
> - Add callback NULL check to the ctrl-c handler.
> 
> Changelog v2:
> - Make current_test a const pointer limited in scope to resctrl_val
>   file.
> - Remove tests_cleanup from resctrl.h.
> - Cleanup 'goto out' path and labels in individual test functions.
> 
> Older versions of this series:
> [v1] https://lore.kernel.org/all/cover.1708434017.git.maciej.wieczor-retman@intel.com/
> [v2] https://lore.kernel.org/all/cover.1708596015.git.maciej.wieczor-retman@intel.com/
> [v3] https://lore.kernel.org/all/cover.1708599491.git.maciej.wieczor-retman@intel.com/
> [v4] https://lore.kernel.org/all/cover.1708949785.git.maciej.wieczor-retman@intel.com/
> 
> Maciej Wieczor-Retman (3):
>   selftests/resctrl: Add cleanup function to test framework
>   selftests/resctrl: Simplify cleanup in ctrl-c handler
>   selftests/resctrl: Move cleanups out of individual tests
> 
>  tools/testing/selftests/resctrl/cat_test.c    |  8 +++-----
>  tools/testing/selftests/resctrl/cmt_test.c    |  4 ++--
>  tools/testing/selftests/resctrl/mba_test.c    |  8 +++-----
>  tools/testing/selftests/resctrl/mbm_test.c    |  8 +++-----
>  tools/testing/selftests/resctrl/resctrl.h     |  9 +++------
>  .../testing/selftests/resctrl/resctrl_tests.c | 20 +++++++------------
>  tools/testing/selftests/resctrl/resctrl_val.c |  8 ++++++--
>  7 files changed, 27 insertions(+), 38 deletions(-)
>