Received-SPF: pass (google.com: domain of linux-kernel+bounces-83627-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 27 Feb 2024 08:38:50 -0800 (PST)
Subject:     Re: [PATCH] riscv: deprecate CONFIG_MMU=n
In-Reply-To: <a49546e8-6749-4458-98da-67fd37b7df18@rivosinc.com>
CC: lohr85@gmail.com, Conor Dooley <conor@kernel.org>, samuel.holland@sifive.com,
  Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
  linux-kernel@vger.kernel.org, Conor Dooley <conor.dooley@microchip.com>, ajones@ventanamicro.com,
  dlemoal@kernel.org, Bjorn Topel <bjorn@rivosinc.com>, Atish Patra <atishp@rivosinc.com>
From: Palmer Dabbelt <palmer@dabbelt.com>
To: cleger@rivosinc.com
Message-ID: <mhng-a3b495e6-aca6-4137-a3c1-8fcacafd8596@palmer-ri-x1c9a>
Precedence: bulk
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

On Tue, 27 Feb 2024 01:11:41 PST (-0800), cleger@rivosinc.com wrote:
>
>
> On 26/02/2024 20:00, Charles Lohr wrote:
>> WOAH! Please DO NOT deprecate NOMMU. I use the NOMMU build constantly
>> and NOMMU Linux on RISC-V is the avenue used by many FPGA soft cores
>> for Linux, as well as some limited systems.

OK.

I just build test this stuff, as I don't really have a use for it 
personally.  I figured if nobody's reporting bugs then probably it's 
broken and nobody's noticed because nobody's using it.

>> I get new copies of the kernel when there are releases and test them
>> frequently to make sure everything is still working as expected.

I'd actually expected it to be broken, but I guess we managed to avoid 
screwing things up ;)

>> For us we just don't care about XIP. I mean if someone did push it
>> through to fruition, I'd also test and use it, but I urge you please
>> do not deprecate this.  While it's sometimes needed a bit of a
>> creative build to get everything working, I've never needed to patch
>> anything in the kernel beyond patching in a custom console for serial
>> output.
>>
>
> Hey Charles,
>
> No worries, we actually did not expected NOMMU to have *so many* users.
> I guess deprecating stuff is a good way to have immediate feedback ;).
> Having FDPIC psABI to be merged upstream could also probably be a
> positive point toward a better NOMMU support.

Ya, that's probably the right way to do it.  Touching anything in the 
psABI is pretty miserable, though, so I don't really want to force 
people to do it...

>> I am happy to discuss the possibility of me and or one of the other
>> RISC-V soft (FPGA) core people stepping up to try to be more active,
>> but so far we've just been very well serviced by the current NOMMU
>> Linux setup.
>
> It could probably be nice to have some feedback/Tested-by: from NOMMU
> users for new releases then.

Having more upstream interaction from users is always appreciated, 
that's the best way to prove people are using the code.  If you guys 
have the time it'd be great to get this into some sort of CI, ideally 
running on some real platform.

> Thanks,
>
> Clément
>
>>
>> Charles
>>
>>
>> On Mon, Feb 26, 2024 at 8:03 AM Conor Dooley <conor@kernel.org> wrote:
>>>
>>> On Mon, Feb 26, 2024 at 04:25:24PM +0100, Clément Léger wrote:
>>>> I guess I could also mark XIP as deprecated.
>>>
>>> I'm not so sure, people recently added XIP support to QEMU (and sent
>>> kernel fixes in December). XIP is also not nearly as much of a problem
>>> to support, there's far less that it does differently, the main barrier
>>> was the inability to test it which is no longer the case.
>>> That said, XIP is gonna kill itself off I feel as it does not support
>>> runtime patching and therefore is extremely limited on extensions, given
>>> we use alternatives for all of that (although I suppose if someone has a
>>> usecase they could make nasty macros worse and implement a compiletime
>>> switch in the alternatives too).
>>>
>>> Cheers,
>>> Conor.
>>>
>>> _______________________________________________
>>> linux-riscv mailing list
>>> linux-riscv@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-riscv