Received-SPF: pass (google.com: domain of linux-kernel+bounces-83601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <b9966efa-8efe-4de7-b962-a6edcf2f6904@intel.com>
Date: Tue, 27 Feb 2024 09:29:20 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dax: remove SLAB_MEM_SPREAD flag usage
Content-Language: en-US
To: chengming.zhou@linux.dev, dan.j.williams@intel.com,
 vishal.l.verma@intel.com
Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
 roman.gushchin@linux.dev, Xiongwei.Song@windriver.com,
 Chengming Zhou <zhouchengming@bytedance.com>
References: <20240224134728.829289-1-chengming.zhou@linux.dev>
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240224134728.829289-1-chengming.zhou@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/24/24 6:47 AM, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.

Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>  drivers/dax/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> index 54e528779877..cff0a15b7236 100644
> --- a/drivers/dax/super.c
> +++ b/drivers/dax/super.c
> @@ -547,7 +547,7 @@ static int dax_fs_init(void)
>  
>  	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
>  			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
> -			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> +			 SLAB_ACCOUNT),
>  			init_once);
>  	if (!dax_cache)
>  		return -ENOMEM;