Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2048757rbb; Tue, 27 Feb 2024 09:04:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW6sqAPWl8eZH1Ob+CGSXfU74hMNaawlDc1q+ZxspMkkBhUvOO771nBPkZmqR5cT7GT/Ea5ZM16/j2rClabhC45pVyC2UXhez+gu1pOaA== X-Google-Smtp-Source: AGHT+IFbd3yC1gf7IUaSZj46yyJ5JIVP1pyjGfEaGUKEYefuz/+eJRKSin2fgjHP9OidvwssFluO X-Received: by 2002:a9d:4f11:0:b0:6e2:e138:f98 with SMTP id d17-20020a9d4f11000000b006e2e1380f98mr10816326otl.6.1709053475078; Tue, 27 Feb 2024 09:04:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709053475; cv=pass; d=google.com; s=arc-20160816; b=IpkouSq1BS/HFoH3h+ECl+Wr9pqv86cA4AbN0Prl+wwAUGT4CmmJIftit5bcy2RiGs t5AHjJ3EO53mgUEomBC8yaS7KeuYKop3UhmQ11e8oX/MhEHafJ/W00ihN7EnXjqptaGv DmPKcNyEJ3NsVXav1SvBmeFDCFuRpawz06QsZ6afaYtYBiZ9OHXFzUy7YEdttfUyCy/f zWoOAkDxQ4xZqdGyW438T9hqsDlAbZ00p74pmEfuAjrqXYeLAihdG0fLS8ZQAnHRdjt6 4iRAyb3Q1RewdRbx0kpqliilkwyHPl/eefwguU6muIP4P6wgZm9kW/WRAoRbdTpkVq8d 41Zg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=ieaqldWYxlts8vxb1oirRiS9OuCsnlGmA+e1W7mof58=; fh=0dA75fUpNZ+fiLfs+Sd6Hv8SvT9w0JX/d/SdVD0s4eg=; b=QkRdFO6+1Q3FMsPJD0mIuJz4wRiZIRwhctvZXkY9wurM0MzLYgFJ96+3Dhb1eNfZvu uQdTE/eaMSnUqq0GUrv9E15r8D/QBSfyAtnlv3oHyYpP/RDkXOcg+SUloelvESTkOWOu zVW1suwj5aXp4s352WQv9sDqvvppX/ayijtSSlZQpHmVp081RpV0ORAwOl/g1ZKQ3YrX DVDOzImnN9uNzfJnodMa1BEmjBD4thMCcHg1RVoAunbELGsQx+0dE5s5jE9xQgrFLqVH rQAKtXj7P3z/jp8ml54PxMO/KMMnF+oPV8PQX5lMjnMoAPYO60Vr79dQB+u+vX+QBri1 TR3Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=FNRfL+9U; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-83600-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83600-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id k7-20020aa79d07000000b006e47a6d1068si5759847pfp.201.2024.02.27.09.04.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 09:04:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83600-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=FNRfL+9U; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-83600-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83600-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id ED6E6B29AD2 for ; Tue, 27 Feb 2024 16:28:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 790DE149DEA; Tue, 27 Feb 2024 16:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="FNRfL+9U" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D18FB148300; Tue, 27 Feb 2024 16:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709051298; cv=none; b=adqVTe2OF4WQP9WkAwQhKZ5KhW0zbm2U8230rXEdU/R/hB63JQj/TMCS/6CfxHPLt3gNmjwmw8EtyauA8fdUCSTpxa+/4jA8zBXgExVogbxzfA3mSp+ayfnqbY7uaubw0xkwbXr82C1y0BDcw5iMzBsNYw8zDpIw84oUT4lqsn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709051298; c=relaxed/simple; bh=zBoRncRpaabg/PphISSG21C84uO5bjeWeT18G6pOYKI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LvCvLblF8Ni5w0hRxmXZaBWhRzaKLhbkbWREN+dFk2BfdEgzwCxPcKSwDkPUTbr63VHnkkelv6mWOFI2Hmgk2+RCUc8JiOYyQxLALnVCRog5zTmjJBF3WiXAKlUtj0LW+ahK/57+cxVikynlUOxm4Yz7Nx0CSf4nwsBwD/GVxdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=FNRfL+9U; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ieaqldWYxlts8vxb1oirRiS9OuCsnlGmA+e1W7mof58=; b=FNRfL+9UCjzORcduefVPxbH4Zp mAgLGcE0Gz4hkr4nWBKxWYtIgwbszvE1/Q1mR+pSTZMTIdnI0077bhHaP/vWk5ojJ8W5VIxgxPxjq UDtOqr8DMn0PKTSxpryfZqw7IwmVuHF7TKC/NK+054c/s3EjmbNMp3Jaax5u3IG2EfBRwb4omu91c 0BdLh6R+LtdhQOnuwwNK3I0i3nGWlJbTzdTLi9JiSRx6b/u0+NbJ7o/J40upfEXE0nxRCPLq2ruNV BcGapW0kpYiC0pZOcyIZdPDdOpqHiHTGnXOo3dIj5C/pMeBfem8dpixeQ3mHVKBYkrip+u3w9EHDO QVzgxMRQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50536) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rf0JN-0000eA-1d; Tue, 27 Feb 2024 16:28:09 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rf0JM-0007Wi-JB; Tue, 27 Feb 2024 16:28:08 +0000 Date: Tue, 27 Feb 2024 16:28:08 +0000 From: "Russell King (Oracle)" To: Robert Marko Cc: andrew@lunn.ch, hkallweit1@gmail.com, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, ansuelsmth@gmail.com Subject: Re: [PATCH net-next 1/2] net: phy: qcom: qca808x: add helper for checking for 1G only model Message-ID: References: <20240227162030.2728618-1-robimarko@gmail.com> <20240227162030.2728618-2-robimarko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240227162030.2728618-2-robimarko@gmail.com> Sender: Russell King (Oracle) On Tue, Feb 27, 2024 at 05:19:28PM +0100, Robert Marko wrote: > + if (QCA808X_PHY_CHIP_TYPE_1G & ret) > + return true; > + else > + return false; return !!(QCA808X_PHY_CHIP_TYPE_1G & ret); is a shorter way to write that. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!