Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2052586rbb; Tue, 27 Feb 2024 09:09:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV8cddpcVfUMsKEUNgL7C31O3DlzzpiD+odMjmzyWNG55V6LxWlJhYHIHTW5G7kk3Wu0mfcQSQsZEAAnVkGyed3lsLiz5qhxg5OrBDdww== X-Google-Smtp-Source: AGHT+IFIPS+GT6rsw5BksuQzFVpFFm7mFasarshOJRyqbJLCz2KCYv5mBXf8ncWxh2daFN/NMAC0 X-Received: by 2002:a05:6512:3d1b:b0:513:bba:3acf with SMTP id d27-20020a0565123d1b00b005130bba3acfmr1693137lfv.25.1709053775046; Tue, 27 Feb 2024 09:09:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709053775; cv=pass; d=google.com; s=arc-20160816; b=ApYONfLAhLnuwXrvJhFDh16bQP0BWrPmAN4pEdf5Yy1AAa43adQQJt0MdOhK9+TFW+ 8St5BfksJfVX2l8+Zuvqj8HyoDuEZbrCud3RjJLAgqYaSVK5EKfHdG3D7u5xw92xZ0KM OGyy4BteHqOSSzeWrO/R89OSegg9v59b99s+gN/FQ25LKcefqkyKvPYD7FphA4f+HzRp odSqvv6CXxda802YHCTjhozZbKETYzmk9VJ4githAokRr9rAoMZS4Rd8tp1wOhYY2eD2 Yb/g9VCKSz9J5QTwWK8q6Z2719bscHQrhqyYRAC5XnAgAuqBc9XpDQMgj2OjORSerk85 2mhQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lmc3sjc8em17oChCJSQpaOzbhd1qpZMy7Z0nwlTPyEc=; fh=G6DPp9GVGW4Zl2OLoqzWfvW+H4Wd2BVdOoUGC4XV3Jg=; b=NT5dvbnaK5A4+pb5cq1dRXsyiP2fqiDNL+Ed5NXs7rbaLyd4P/j5z81PCC65x4KwHE lKgMH0QGlyMEcSvnAKhtaSDHklg3sHHAmYBp5fUxDnhbxikj4D0KwH4/8KXpRUcbcMAo TdzscnEsvOEU56N2VSBDx+FRt7MuaC9A5ouT5tIAzcH+RnmS9W63fP8PWpxUnhf9Eqqp TKmpzv6nnUHq9I7belC5iYubF28ssR5B0G1wMreb+sqCQ5o2fSMxHP8bZQUHzR9Sb7IN vfF5ZnXf4orYRZnj5RU7gsqWHus2czonJOy+mlmQkWZOiaAx274rb4yyaOWBRBKoJZhT Kvjw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OV1FbHlu; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-83680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83680-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id k17-20020a508ad1000000b0056399fb0ce8si857515edk.36.2024.02.27.09.09.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 09:09:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OV1FbHlu; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-83680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83680-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9603C1F284C4 for ; Tue, 27 Feb 2024 17:09:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BFD174E1C3; Tue, 27 Feb 2024 17:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OV1FbHlu" Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D3233E480 for ; Tue, 27 Feb 2024 17:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709053731; cv=none; b=Tgc3Kk9B5gi7Y5qCAhFIszIVV+FmZ8X1iZ3sodZbiPZiOlukeZwvSkpYYfAYTF1BxdFWUtmQc0OarOLmJLWVHGxj0rYwK6BbPd/THIKb6/EIWsLmWeCe+JMKw6kmYBybAQwAG2b/8MvEcFomsKr1wDwuflsVqLZpdzz8u0XjyPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709053731; c=relaxed/simple; bh=LyIC2a8YCi8H35J3OmUP2FanwA/jMrbgvLb5jpkEIFM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BdH2Or2FQoovkqmysLcIXDLS234t4Fr2WL++hbjkH8GHd5gItHHYRdUZTYHtIBt7nMtN3BVbOLvK0yyJlR0koB9X/tNcRskClGkoz62gSDZJqiXZlSL7thvCmQbSeLwbc2YX74i9XIcoINquw0kw2CFxQQwuyq+3LsPJz7+z0Nw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OV1FbHlu; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-5d8b276979aso3506354a12.2 for ; Tue, 27 Feb 2024 09:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709053729; x=1709658529; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=lmc3sjc8em17oChCJSQpaOzbhd1qpZMy7Z0nwlTPyEc=; b=OV1FbHluXUQPzO7NWQ4faDtrR1AkKEeiRAfRi/Yoqt1b9ql8Ne85nQy1UPWVbl91lv AdZpy+i78t4JRIivHJDth32osYdT9Nv+OJ7DCro5zZFlHp0+9cj7raWYuD5wgfgW4w6B 0e5ONboExYxPEjlR//w5nvSveC7Nn1DlZBcu73j35kPznjlDSAu5ezY9HNxOp+P29rNZ Nw4Xm5SJTlxNtawSsP6ZJqqlclKODCgezbhSLwy/CEnSZxJO7H9yTNSFc9MsT9u0aOKB ONoyzPGs8Ab+kTrRnrbwdGLc3kT6/tVW4HnEcnKyN9I6le7xE6uGOAhxTdWi1xdDEChi bSFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709053729; x=1709658529; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lmc3sjc8em17oChCJSQpaOzbhd1qpZMy7Z0nwlTPyEc=; b=Nd7YvdRpqUGASH7ned9OgPzOw3JaIZawTtFga/4oLOQENGFWss1+KbmmE1kMLCia9F sB5qN+pJWZLF4BMcYrtQ1vR1ZR6NtnMqg+VUkhXRO/FWg9CD3YuJMaiagNxrWWqt9L8S g2qp326t6V4igaBT+hw7hw3YT+wV6zClJPJdNcrezfsAQbQ0mLGf+b4xsdSokKN5Eaz/ U535UoUbSVQrwXiXudMnl5R8vhJ1IQ+F9Yt7+3czG2HlyEZnZnTxtyjrTqpDatpRd8Pm 0FWCpuLWgsVz8NNv85WM9SIRKyXCa4qWwPoLzUVoPWzUUGb7zeN6lkx0XQG+RSFSMnfP FNjA== X-Forwarded-Encrypted: i=1; AJvYcCW6+z8FmHTL9DNvZft2tzSbNCGNZhohaEDv9PlLZHiwxgMd9z6j9g5EC54CGsOUoArbJW0RVLuIiAkCBZz2TmzDPCdjmIacndUuRLj9 X-Gm-Message-State: AOJu0YySSpJd0Bz2nh2NGtvdLmmtdKfP/kApEsLrTKAy6a80sZDcN9ua 8NmJfslsKBs1eO59yLy/lkWgjVkDfXurY77d2mFpUqvMUgwlnmqA+FEnRSczKQ== X-Received: by 2002:a17:902:6b49:b0:1d9:8832:f800 with SMTP id g9-20020a1709026b4900b001d98832f800mr9202931plt.8.1709053729485; Tue, 27 Feb 2024 09:08:49 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id d1-20020a170902c18100b001c407fac227sm1765279pld.41.2024.02.27.09.08.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 09:08:48 -0800 (PST) Date: Tue, 27 Feb 2024 22:38:40 +0530 From: Manivannan Sadhasivam To: Bjorn Helgaas Cc: Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Lukas Wunner , Mika Westerberg , quic_krichai@quicinc.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3] PCI: Add D3 support for PCI bridges in DT based platforms Message-ID: <20240227170840.GR2587@thinkpad> References: <20240227073057.GF2587@thinkpad> <20240227162535.GA239073@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240227162535.GA239073@bhelgaas> On Tue, Feb 27, 2024 at 10:25:35AM -0600, Bjorn Helgaas wrote: [...] > > Ok, I got the issue. TBH, I added the device tree property based on > > the existing quirks for the ACPI devices. But none of the DT based > > platforms I'm aware of (even the legacy Qcom MSM8996 chipset > > released in early 2016) doesn't have any issue with D3hot. But I'm > > just nervous to assume it is the case for all the DT based platforms > > in the wild. > > > > But to proceed further, what is your preference? Should we ammend > > the DT property to make it explicit that the propery only focuses on > > the D3hot capability of the bridge and it works as per the spec > > (PMCSR) or bite the bullet and enable D3hot for all the non-ACPI > > platforms? > > > > We can add quirks for the bridges later on if we happen to receive > > any bug report. > > I would assume all devices support D3hot via PMCSR per spec. We can > add quirks if we discover something that doesn't. > When you say "all devices", are you referring to bridges in DT platforms or the bridges across all platforms? - Mani > If we add annotations that "this device works correctly", we're > digging a hole for ourselves because it's impossible to remove those > annotations and they complicate all future maintenance. > > Bjorn -- மணிவண்ணன் சதாசிவம்