Received-SPF: pass (google.com: domain of linux-kernel+bounces-83706-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Frank Li <Frank.Li@nxp.com>
Date: Tue, 27 Feb 2024 12:21:54 -0500
Subject: [PATCH 2/5] dmaengine: fsl-edma: add safety check for 'srcid'
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240227-8ulp_edma-v1-2-7fcfe1e265c2@nxp.com>
References: <20240227-8ulp_edma-v1-0-7fcfe1e265c2@nxp.com>
In-Reply-To: <20240227-8ulp_edma-v1-0-7fcfe1e265c2@nxp.com>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, Peng Fan <peng.fan@nxp.com>
Cc: imx@lists.linux.dev, dmaengine@vger.kernel.org, 
 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, 
 Frank Li <Frank.Li@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YWxqL1h6VHluTDJndG85NkNZOHE3aG1sdmQ1Z0JHU0puRGYzVHljM0ZWdlZT?=
 =?utf-8?B?T3NsVjdISGM2MFE5Ly9xNDdKMkVFdUdWdTBGYmJ0RjBrZGxSY0JKOERoQ01T?=
 =?utf-8?B?MkpGWTFSSnpWdjhZMFgvRDNLbTA1V0VDMi96aUJtKzJlODBncEN3T3hTV2RF?=
 =?utf-8?B?dDFHOG5nT3JOcHFva1BkdDZIaFc2QU5wS0RnYWhjOGpTeUpNV2hXMFZtUmZF?=
 =?utf-8?B?Nk9zb0V3ODhMdUxCUmk0OUt0VFpUV2JPZHhvblRteEJFUnc3emY1T1h4cFh3?=
 =?utf-8?B?L2oySjd3NzNFVksrOXp2b2R6ZTdiNTB4V3Z3UzhvWGpXYU9JNXNyY2JwQ1Jk?=
 =?utf-8?B?T052Rk9zY3o5K0c5cTZPcDdsRXJnRFVxZTJ5aEFyUkxIemFmOC9LaFNHNnFU?=
 =?utf-8?B?T2tMVnlwUUdnY3RRU1ZETXROdjNoejNVOUdsWVJ5eHNnTkVMK0R3UlQxWlZn?=
 =?utf-8?B?ckxSQ2Jra0NDM09WSTZQRXNqNWRuS0tQbFJYOHIyMXJBU080UnpJMDFZaE9T?=
 =?utf-8?B?YTZZeDBqbXF6Z2dVQnpPVitnS1VSTVFmZTVqbzZaK2JQVE8wbXBEUU9ocWVU?=
 =?utf-8?B?K2Npb2NWaUlHZjFwYjdyVThCbDBVc0NpNzB4bGZpWWg1cDFRRm9HK1ZsaG8y?=
 =?utf-8?B?bmdVTlR3dS8vaXpOZFBsVHlpclVMdkIraGp1UU9XVjBJT0Q4M05hYmhYbi96?=
 =?utf-8?B?ZERwTjdMWTFSRCtNMW9SMEJVSGEreE1PUmdhU0JWVHdzN0hIdHRMS0R5ZmZq?=
 =?utf-8?B?VHgyVVA2VFBaWVcxZmtCY0pabUExZFBNcVMrbUNqb1VSbFV6U3hsdGk4S2VB?=
 =?utf-8?B?UVpFWGpFYXRpVTJ1NEdHdDFEUkV1TWlqUHpGYjJIZXFUN3Y4M21LZlN4RGNt?=
 =?utf-8?B?NTF6YnBRZ1NzVXNrekU5aW13YWxJTGdhZnpwRC9GK01mejJ2dzAvTDR0d1dz?=
 =?utf-8?B?WkN4VVBOOEhjcXB5WENFYmpyU3Rha1Q3aGRVaThveXljTjRNSUlIUWxFdWo1?=
 =?utf-8?B?Zk13RUhYblBRUVZpak5MZ3NOUlExM0kxZElkRDNNM0Y5SlNvWjhGNi9GQ3Aw?=
 =?utf-8?B?MkcxTWMwV2swZm42MUFDeCt6TjJ1a045VWQrcGJXZndMN255RU5lVFA3WDJ3?=
 =?utf-8?B?aU92VGhwZkxIREZqTGFPeVhkb2h4c0lkUDk0aDlLR21YT0Uzbyt3SFVwbnFh?=
 =?utf-8?B?VnlhUys0VWNQSDNTTFdiS09VUDR4amVsdGYvaStqTVNpMU0rSzlMaTNsUGpt?=
 =?utf-8?B?M2k2VW1ZSDRKdWQwSVdBUGV3VHhJcVd0emoyeGcwYkhmZW9weTRkTDRoeXdQ?=
 =?utf-8?B?b1R3ZVBxMjdiVTVjeUd5SFJCOFBmK2lsV1d6Uk4raXRWUnpvd1NEdFFjNkd5?=
 =?utf-8?B?UnlPR3lLd21Ec2xhS0ozbWZDTWlXS28vR1RmZnd0U2hJT3FMV05NUTk0T25i?=
 =?utf-8?B?c3E5bExUcEdaaDMzbnJvaWk0a1RFU3RONmtZU2lLck93aW9QMDFNQ3FKSWNM?=
 =?utf-8?B?c3ZSeGdmcG9JMDh1dmQ3a1dVMmZrbWVkNXg3dWMvcXp0cmZlRENGb3FFYXRr?=
 =?utf-8?B?b3hWTWZPd2lBcVZlMXpYL3d4N0I2bnRHQVBHWDNybFZIYkRaNWNzY3JUd3Uv?=
 =?utf-8?B?bE5VdVlKQm5FZ0RubnFBVmx6QmN0NnVWQzJoMGFDWldyYmZURUZtbTB6QXJy?=
 =?utf-8?B?b2w5SXdVN2NyMXdUQTJFYzNaK2xzZ2pyZ3B2Skh4dVZyRUdINFBzV1ZidUZn?=
 =?utf-8?B?aHNYSU5yTHE4M0ZpL2FDbEs3SUdBNEJiYTZoMEFZWEpjNEtwZUF6QnlXQTFj?=
 =?utf-8?B?TVo2RDBKRURBK2pVeGxSb2lWekFXdDBTRkNmbkdwMU00bXBENVgvbW5sdFlD?=
 =?utf-8?B?SjM4cm5oTTZSQkIvYWVGRThOUzBDSVZmdEVobUR0SXQ4eHcrVGJ0V2FCKzNo?=
 =?utf-8?B?R2hoOUxicXZKR1VoUUltaFlUZ0NpdVpqS1FORzFJTlRLT0xTaTc4NU9lZ3dL?=
 =?utf-8?B?ZjFkWmg1bFBCWlJaN2YwbXN0NnI4ZkpxSmhYbVNwQll4cTlRdTZDQkNDd0hX?=
 =?utf-8?B?UXJ0eThwakpZbk01VW1PZjROdXVIc1F4ZWlpOFlpSGhNRlhrdUNpaXpDTVJU?=
 =?utf-8?Q?WhNImIni60WS73eWlyIlrd4gM?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18ecc72e-7ce6-428a-7423-08dc37b8a5d0
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 17:22:17.6074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6w1LFTRIkZ+ZXYp58HsAkcKsVTraj6Z2nS7WKim559ZQ0SeOMfRYdtqXq9wlzKmzIZ64giZy0yiYwra3gux2lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9408

Ensure that 'srcid' is a non-zero value to avoid dtb passing invalid
'srcid' to the driver.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/dma/fsl-edma-main.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index 0a6e0c4040274..2148a7f1ae843 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -115,6 +115,13 @@ static struct dma_chan *fsl_edma_xlate(struct of_phandle_args *dma_spec,
 				chan->device->privatecnt++;
 				fsl_chan = to_fsl_edma_chan(chan);
 				fsl_chan->srcid = dma_spec->args[1];
+
+				if (!fsl_chan->srcid) {
+					dev_err(&fsl_chan->pdev->dev, "Invalidate srcid %d\n",
+						fsl_chan->srcid);
+					return NULL;
+				}
+
 				fsl_edma_chan_mux(fsl_chan, fsl_chan->srcid,
 						true);
 				mutex_unlock(&fsl_edma->fsl_edma_mutex);

-- 
2.34.1