Received-SPF: pass (google.com: domain of linux-kernel+bounces-83764-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
 <15fcf98c-58c5-fa08-2e21-f3b0baf058e6@amd.com> <87zfvtg2mh.ffs@tglx>
 <f1a5fe09-f4bc-0dc5-edda-6b3e690bc0e3@amd.com> <87ttm0dwhk.ffs@tglx>
 <87bk87c1n7.fsf@oracle.com> <f32b90fe-2d56-4e9e-8f44-c7ee662af43d@amd.com>
 <cd56eb4e-520e-4ab2-a041-0a580cb42e1e@amd.com>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Raghavendra K T <raghavendra.kt@amd.com>
Cc: Ankur Arora <ankur.a.arora@oracle.com>,
        Thomas Gleixner
 <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        peterz@infradead.org, torvalds@linux-foundation.org,
        paulmck@kernel.org, akpm@linux-foundation.org, luto@kernel.org,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
        mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org,
        willy@infradead.org, mgorman@suse.de, jpoimboe@kernel.org,
        mark.rutland@arm.com, jgross@suse.com, andrew.cooper3@citrix.com,
        bristot@kernel.org, mathieu.desnoyers@efficios.com,
        geert@linux-m68k.org, glaubitz@physik.fu-berlin.de,
        anton.ivanov@cambridgegreys.com, mattst88@gmail.com,
        krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com,
        jon.grimm@amd.com, bharata@amd.com, boris.ostrovsky@oracle.com,
        konrad.wilk@oracle.com
Subject: Re: [PATCH 00/30] PREEMPT_AUTO: support lazy rescheduling
In-reply-to: <cd56eb4e-520e-4ab2-a041-0a580cb42e1e@amd.com>
Date: Tue, 27 Feb 2024 09:45:42 -0800
Message-ID: <87h6ht94xl.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?kKIZWWSTRObFYdW6aZwbUI9PCez/4pkXX/rUkxPeoqXSv+I6FpuiK98J9vUn?=
 =?us-ascii?Q?c9ZJmv5Ch8zPYkvBm3+E+Eqt1w/qIL1FtUDnj6zWRFAOKM9UELw/IelHIZMz?=
 =?us-ascii?Q?kknSUDHRtsmwUfdMPPQcZpAtKmKmbTgDl5R8OQfsLc0cNdVgPfMDI3E9B/Db?=
 =?us-ascii?Q?tDmFEzj8I9514c3o6aoXKD30tmyxh9hHHFwMoo7CCCaXaQkKkHa6rB6Oiwva?=
 =?us-ascii?Q?LI2ptfSWNk9pSxjwDnALfHfbF/hMyjM25p83G9MTpqsK7Kn0msucbWne5X0P?=
 =?us-ascii?Q?C2lTqcUw9L0mKDz19gC0DTEAIubqq13b4UCd4LFjcXjxkDLSd12XLjxXfzdL?=
 =?us-ascii?Q?ngpMDGnWuXB3FBs3F9Gk9F3hmQIvicdAzPN4Ua9RDJIB/DZnGv487vPMtmbZ?=
 =?us-ascii?Q?G+sZE6q0biG4RItq+pkodJ2dH0A+768V097Rn8sTWd4A2MmVvEmjLYybpinS?=
 =?us-ascii?Q?3oAxD4xvosE/YeuXBBDMVG3qL4rkhoOg1qRTZvssReg8sTdxYRTLoNFkfE/Z?=
 =?us-ascii?Q?iRRFpfO0r3uxJKJ/E7Y4etQFHxgIRLV107SysAg2xIzGCy7/iPLtiZE7PxSy?=
 =?us-ascii?Q?gVOBKbvdaeZrLJjG7wv//Nz6nZqiiizWZf88Hy7ClYOMOQddKxB2fvWOGNlb?=
 =?us-ascii?Q?ziIqjUS50HRz7mRnl9r1leY9Ns+F6Sxlp4yBghweRM1RfqJQY76NwoWXlQzT?=
 =?us-ascii?Q?allozLRO6M2Ke5/8gNGrVSuACYLaqGbLYqCq2L3QLVrQLYzm8AXk4b6aabgB?=
 =?us-ascii?Q?ocWEaRm4EdRzZEj4nYfguucCo4+u1AL+b1gddgaDPJ456zZtWXlXXRxYBFZ9?=
 =?us-ascii?Q?xRoV9L9h3yApTPpuZooz1egwuo/eHi64IzLCQ41/LwPL1rkAOPcbbqf3uQYu?=
 =?us-ascii?Q?xrWURmNEMfgd0MwJs0Qo53Dr7OTL3KjJnWmZy5sCue90zaowrvhw007Bs/rL?=
 =?us-ascii?Q?eTKS37X3NfwY9ZCJEFiNwHuatmlxv8mYwJdcEhSGkxw5TnIyb+1TWumAeTac?=
 =?us-ascii?Q?fTwYl4Aw7iiE8XT76635JraiEY1LUXXQfzPXZt4JMElo3gfU9x9niH1K5HMu?=
 =?us-ascii?Q?XWpOBGzEIgxmwtkqVJUQtUbVRHAPq9X7j6v5GDiLwTvp/NqI2jTCrSToO3r4?=
 =?us-ascii?Q?ZvgpTHsK3ZAJ1NvUhq9XzdvtJa1b9jIG0fFBgFG2AqGme98WvpLZ+su+AwWX?=
 =?us-ascii?Q?8YI54au04P8vymJJgPXyA7jV+cSvi8WEVnhVxJTbWktlVpVMnBiS70qEAVUW?=
 =?us-ascii?Q?vuWQErS3IjCstHms0rHsHXjORC5K0Wy/QFOTNdw0/BMmpEWk4xqF9HMNRzEP?=
 =?us-ascii?Q?veou+0dUahVqMelNuOt5wes+v/M/C6UpJA8XOPFEzhpZ0Qs7vmiqbYmJiNwV?=
 =?us-ascii?Q?YnHuZDlQM67ikncSCExYyVtPGGF8XQn1fTwhDwWzNnpAnIhVhjetiJWy2Wbo?=
 =?us-ascii?Q?LQaBkyk307titLPPUkZCO4/PNJYbbdzZHS9llodf1QkWCPEeNAxdCfQ4TT/O?=
 =?us-ascii?Q?yhBeQIuoyiJMaLL34imrmUmWuKfsPUzjvdVlz0pmKPyYRVkgQ/W/WNmTsEJg?=
 =?us-ascii?Q?sx7/Kl7So4KoK3KRnBNUbRyKWqscC+JJH3JP1Vm0Mg1p8oPa4zdVbqa+UM0n?=
 =?us-ascii?Q?5Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	nOE32Lv+uvGjF4/QsrGEIsKe6KzD0KBPXTmi/ydPMRNTNKgl6C7Oy8+CC9FHIJSU1/XEpY9hThrfclLtVvNjvdV4eNwYXFQSIXzQfy+zB1oHIYTDWO8atKfBwDPCrIz60G/E66BgWq86xrXfd2NG/o1FlFJO6bkf5IofWf2htp2NKhbsYYVsjhLLT9igHRmqim0asUogC2v0UFX4S0WYM+Nt/lhKFrLZsVM2f9T6MieYwLXBoQrTGOlUuI1CD3cWcDLeSqY3g5b6gSIZkCruM5yaae4CgSAIFSV2agBEgzBiXgaQCzwIg+nK3yZIvGTU8/4nOkVoBhTbv2io+3qj2nm74fqnnIPx/eYVLZ6anrb89NheFAMVWJ6W2LkDD4wbjRp7VNMvdJHohYNwStj36PTXSU3qBoGSSCHOEkeeqC6upLlzrD8K0sqLSRkokPUxOOL4QtTpYV+TxpK3omqRolClpN8QnTAJI9fdDpg6bPiviDemfdJ9uicbWSrcPa7vWXG2EmRiNgmwqiTJD5bQQh08b2FWqsUIXiSWagpXXobK6Dstm6jGCr/y+8X2anKIM5q8eqisrmMv9t6Hi++63b9p/yi24Gs+R8qQ/XXlDoI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8a0ec36-10a9-4f77-cf64-08dc37bbdcf8
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 17:45:18.7605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /VXHMBgU03M72qoI7pQPgV2QeiPe+V3CP3u3IP5sDoET7ZWCfeu74e8zjPqXWiHeljxsINbk9nhRkfExCbhwruXRFflFqy+u2D+CCYplASE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5126
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-27_05,2024-02-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 spamscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402270137
X-Proofpoint-ORIG-GUID: 4cEfYNBeGj1F2CH-LpO491M5kkwAceCy
X-Proofpoint-GUID: 4cEfYNBeGj1F2CH-LpO491M5kkwAceCy


Raghavendra K T <raghavendra.kt@amd.com> writes:

> On 2/23/2024 11:58 AM, Raghavendra K T wrote:
>> On 2/23/2024 8:44 AM, Ankur Arora wrote:
>>>
>>> Thomas Gleixner <tglx@linutronix.de> writes:
>>>
>>>> On Wed, Feb 21 2024 at 22:57, Raghavendra K T wrote:
>>>>> On 2/21/2024 10:45 PM, Thomas Gleixner wrote:
>>>>>> On Wed, Feb 21 2024 at 17:53, Raghavendra K T wrote:
>>>>>>> Configuration tested.
>>>>>>> a) Base kernel (6.7),
>>>>>>
>>>>>> Which scheduling model is the baseline using?
>>>>>>
>>>>>
>>>>> baseline is also PREEMPT_DYNAMIC with voluntary preemption
>>>>>
>>>>>>> b) patched with PREEMPT_AUTO voluntary preemption.
>>>>>>> c) patched with PREEMPT_DYNAMIC voluntary preemption.
>>>>
>>>> Which RCU variant do you have enabled with a, b, c ?
>>>>
>>>> I.e. PREEMPT_RCU=?
>>>
>>> Raghu please confirm this, but if the defaults were chosen
>>> then we should have:
>>>
>>>>> baseline is also PREEMPT_DYNAMIC with voluntary preemption
>>> PREEMPT_RCU=y
>>>
>>>>>>> b) patched with PREEMPT_AUTO voluntary preemption.
>>>
>>> If this was built with PREEMPT_VOLUNTARY then, PREEMPT_RCU=n.
>>> If with CONFIG_PREEMPT, PREEMPT_RCU=y.
>>>
>>> Might be worth rerunning the tests with the other combination
>>> as well (still with voluntary preemption).
>>>
>>>>>>> c) patched with PREEMPT_DYNAMIC voluntary preemption.
>>> PREEMPT_RCU=y
>> Hello Thomas, Ankur,
>> Yes, Ankur's understanding is right, defaults were chosen all the time so
>> for
>> a) base 6.7.0+ + PREEMPT_DYNAMIC with voluntary preemption PREEMPT_RCU=y
>> b) patched + PREEMPT_AUTO voluntary preemption. PREEMPT_RCU = n
>> c) patched + PREEMPT_DYNAMIC with voluntary preemption PREEMPT_RCU=y
>
>> I will check with other combination (CONFIG_PREEMPT/PREEMPT_RCU) for (b)
>> and comeback if I see anything interesting.
>>
>
> I see that
>
> d) patched + PREEMPT_AUTO=y voluntary preemption CONFIG_PREEMPT, PREEMPT_RCU = y
>
> All the results at 80% confidence
> 		case (d)
> HashJoin         0%
> Graph500         0%
> XSBench          +1.2%
> NAS-ft           +2.1%
>
> In general averages are better for all the benchmarks but at 99%
> confidence there seem to be no difference.
>
> Overall looks on par or better for case (d)

Thanks for running all of these Raghu. The numbers look pretty good
(better than I expected honestly).

--
ankur