Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2102891rbb; Tue, 27 Feb 2024 10:38:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVgxd8yuoPccFiHEX2Pcr9Yjoi/SHRlMH4MCIAVsfbJiw/ViGCP/l6YBCQIBzwpsQS8sIVHh6A7rAyBsXuHhNOBDoQCVbwixxjaPzdnpg== X-Google-Smtp-Source: AGHT+IEuExgjcoUDqegRKlu2p+WRv02ow+3U+e0wLY3EqXT+HkISaLUun4yyYLD7bw219GKE4N2+ X-Received: by 2002:a17:906:d150:b0:a42:e819:e663 with SMTP id br16-20020a170906d15000b00a42e819e663mr151909ejb.27.1709059097251; Tue, 27 Feb 2024 10:38:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709059097; cv=pass; d=google.com; s=arc-20160816; b=Gr6Yst1Xdg10q+dvoTf1piiKUtxqHMBY3ZribGt7zrym7JG0ZovD16XeULoa66V3df We9/3a/rPWjyaIJzUFrdXtMwvo30FhBRj+GeMJKsM4/W0KkZArIve0w+I1eURZa+1rz+ YJKJAZN+09g1myK9InG/86wIdAF5TXwyPBfjMprldN1CFy7TAvUrvHuPD+UBN3YciUMZ aEcrVB/1QCjTl23Mtynmo43QM9ZlfUIQ9ogN7QjtZrndX8Yt3Neg7cILZej0u1upSFyt kvfYFqVvTkGrNAMCV8GnLwtz66F6vkFL28N1+TRwDWKiU+KMqSRERSzV6jgClEO5e/Ec Pwqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zaG4Gr4Kx+0i0zsq6oXYlyOK6u158LHOb5Hpg9y9dtA=; fh=OsHy4wu7Ox2e6jBNTtOkrqWIVTccv8/Cykexl+craGY=; b=SbRi34tIEyFx7nIGi7kmvl+L7VwW6T1Av3A82afzYou9kgufsxQkKqjRUgo+Fi9V2/ fjVFnoJoR2YzicjetXjBG+FPcnHmTgYO/p0AB9Kx+G2rpKT+A8I6RVwe14+W6756XBOU rwn1esq0ri67WD8QCuuT8gwTyxMalExC08WaBRq1FgBq8ZzCrmj+Fnq016OGazZ/LjA3 bkLxtSaIUCARfeqle2mNzQTaBqztIwtgej7wbgVLpGQNtTVe0yhdEjLSmB0V7mVbA9Mi JYgntHsMwyoGHJn+2opHI3U0yQf1VM6ptr+BPGbpfcynhjyZ3oJ2rJrzpi+wcF4NuCQ2 cFWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bJJp9EJt; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-83849-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83849-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u26-20020a1709060b1a00b00a43c1f37dc9si480525ejg.20.2024.02.27.10.38.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 10:38:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83849-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bJJp9EJt; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-83849-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83849-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B79581F2B516 for ; Tue, 27 Feb 2024 18:38:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A165947F72; Tue, 27 Feb 2024 18:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bJJp9EJt" Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3355B1F61D for ; Tue, 27 Feb 2024 18:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709059086; cv=none; b=esFN/DAuC7gjuNhE3uAqtAxmNaGmVElByxb5VSrZLd/0VhAgihROYYWRvX9yRlyazsRSVuWyMlImGo3hWS8pidZtm93TMJkzR1aChd1vyRvZsrbkbBNV00iPrAretwmf9FWHs9E27TtG7u4nnNJrcmuhbc0fXqTn/6ZAXzjZk8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709059086; c=relaxed/simple; bh=kESpsdO4FlnESQiL59fX61xhGswvPE38dgcnrNXEDQU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BQf1UQ5DxfeDkOycQFoxe5PfbJuTW9aBO4+jLToZedU2ZpHv5cG8AFxa717UWlTqXmecIpHQFg6bimdRmaVATjRKeT+8wwk6K+ydMdit1Z96m2P72to4NCIQCmtJJdV/Xt0omjsHqOM61cLE4BmO1IZVkEsLQR7LY3Xn0T8kxV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=bJJp9EJt; arc=none smtp.client-ip=209.85.166.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-7c7701f95b6so1661339f.1 for ; Tue, 27 Feb 2024 10:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709059084; x=1709663884; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zaG4Gr4Kx+0i0zsq6oXYlyOK6u158LHOb5Hpg9y9dtA=; b=bJJp9EJt0C9GtT/FF6xYbLoDj0BaS1oxph3hsJXy87XlarRb1sV1RO3UV1NfAFSGm6 yx0snscqczTNlqXsGty1Rz4EjSAYneiG0geLEGPGY4Kh0wzswLQXZVtpXojUXmKiKqtd twXpwSNJzrpEFB5J9fTV7MRmL9XNW4THXHvfU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709059084; x=1709663884; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zaG4Gr4Kx+0i0zsq6oXYlyOK6u158LHOb5Hpg9y9dtA=; b=jQJ8tyInH9eqcDDsadZUJjyahiU1YBbk2pteqdbuLhzuofmDFSl9NBpkWGuGZznGr0 71xBM0NMaiCaeRwNnjc/2BxWcU+MBXN1ty4Hyn7TN8jxeO+6nZC93josiI1AHs9N3zmP NWyMfhHX+PrYa+WMOrlmzSvwsuuxDzlIvmMPUfN8iXUADt6IhcYX/LZFgmBCeRHXVY6O K+uyCs7fXuLS+9NBo2xRYxyAaXHxg3vX2PW9u06zdq++3jdDc9rlAb0eKUnjzeqBwfcS kIYgjZqXFqr1YL8rFsmIENw6xvbINsEszvx4+kIfgXT7cXA30shR5qmx7YxOMg/7KdKg CVGg== X-Forwarded-Encrypted: i=1; AJvYcCUqhhRag1xGeUuqfMxNaWM16PP1NnPA/8/Vj/cebqAcJAi+G9iwfe7pw4TWNHGN7SDpq1aJ2J+ndpZZn+MiHRX4y0k8nLBSbQotvtVZ X-Gm-Message-State: AOJu0Yw/uuv/zw4pSZHSzSB/TGZe/cNUeqw70cGSWIeKbO/mRzUEsyVo zSAXISyPja63zlflEu2BF5OTkngQfjqmHF6ScK9y8ErJ2zo+46WUIHfrJ/JBNg== X-Received: by 2002:a92:cb0b:0:b0:365:616a:72da with SMTP id s11-20020a92cb0b000000b00365616a72damr143131ilo.7.1709059084386; Tue, 27 Feb 2024 10:38:04 -0800 (PST) Received: from localhost (147.220.222.35.bc.googleusercontent.com. [35.222.220.147]) by smtp.gmail.com with UTF8SMTPSA id f5-20020a056e0212a500b00363ea1209basm2294457ilr.11.2024.02.27.10.38.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 10:38:03 -0800 (PST) Date: Tue, 27 Feb 2024 18:38:03 +0000 From: Matthias Kaehlcke To: Macpaul Lin Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Bear Wang , Pablo Sun , Macpaul Lin , Chunfeng Yun , Yow-shin Liou , MediaTek Chromebook Upstream , Chen-Yu Tsai Subject: Re: [PATCH 2/2] usb: misc: onboard_usb_hub: Add support for TI TUSB8020B Message-ID: References: <20240227090228.22156-1-macpaul.lin@mediatek.com> <20240227090228.22156-2-macpaul.lin@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240227090228.22156-2-macpaul.lin@mediatek.com> On Tue, Feb 27, 2024 at 05:02:28PM +0800, Macpaul Lin wrote: > The TI TUSB8020B is a 2-port USB 3.0 hub. Add support for > this hub in the driver in order to bring up reset, and supply > dependencies. > > Power-up: Issue a GPIO reset (GRSTz) 3ms after VDD and VDD33 stabilize. > > Signed-off-by: Macpaul Lin Generally this looks good to me, but it should probably wait for "usb: misc: onboard_dev: use device supply names" [1] to land and use a device specific supply name instead of 'vdd'. [1] https://lore.kernel.org/linux-usb/20240220-onboard_xvf3500-v4-6-dc1617cc5dd4@wolfvision.net/