Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757764AbYABTqj (ORCPT ); Wed, 2 Jan 2008 14:46:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753764AbYABTqc (ORCPT ); Wed, 2 Jan 2008 14:46:32 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:37496 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753621AbYABTqb (ORCPT ); Wed, 2 Jan 2008 14:46:31 -0500 Date: Wed, 2 Jan 2008 11:45:56 -0800 (PST) From: Linus Torvalds To: Pekka Enberg cc: Hugh Dickins , Ingo Molnar , Andi Kleen , Christoph Lameter , Peter Zijlstra , Linux Kernel Mailing List Subject: Re: [PATCH] procfs: provide slub's /proc/slabinfo In-Reply-To: Message-ID: References: <84144f020801021109v78e06c6k10d26af0e330fc85@mail.gmail.com> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 32 On Wed, 2 Jan 2008, Linus Torvalds wrote: > > Actually, I'd much rather just do this instead (on top of your patch) Side note - and I didn't do this - this also allows you to disable slabinfo for those people who think it is pointless. In particular, you could just make that > +config SLABINFO > + bool > + depends on PROC_FS > + depends on SLAB || SLUB > + default y Kconfig entry use something like bool "Enable /proc/slabinfo support" (perhaps adding an "if EMBEDDED" at the end), and now people can decide whether they actually want it or not (independently of whether they use SLUB or SLAB or whatever). But I left it hardcoded to on, just because I'm not sure it's worth it. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/