Received-SPF: pass (google.com: domain of linux-kernel+bounces-83237-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 27 Feb 2024 13:31:46 +0100
From: Jiri Pirko <jiri@resnulli.us>
To: Lin Ma <linma@zju.edu.cn>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, idosch@nvidia.com, razor@blackwall.org,
	lucien.xin@gmail.com, edwin.peer@broadcom.com, amcohen@nvidia.com,
	pctammela@mojatatu.com, liuhangbin@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] rtnetlink: fix error logic of IFLA_BRIDGE_FLAGS
 writing back
Message-ID: <Zd3WMs8-nw5SPTZE@nanopsycho>
References: <20240227121128.608110-1-linma@zju.edu.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240227121128.608110-1-linma@zju.edu.cn>

Tue, Feb 27, 2024 at 01:11:28PM CET, linma@zju.edu.cn wrote:
>In the commit d73ef2d69c0d ("rtnetlink: let rtnl_bridge_setlink checks
>IFLA_BRIDGE_MODE length"), an adjustment was made to the old loop logic
>in the function `rtnl_bridge_setlink` to enable the loop to also check
>the length of the IFLA_BRIDGE_MODE attribute. However, this adjustment
>removed the `break` statement and led to an error logic of the flags
>writing back at the end of this function.
>
>if (have_flags)
>    memcpy(nla_data(attr), &flags, sizeof(flags));
>    // attr should point to IFLA_BRIDGE_FLAGS NLA !!!
>
>Before the mentioned commit, the `attr` is granted to be IFLA_BRIDGE_FLAGS.
>However, this is not necessarily true fow now as the updated loop will let
>the attr point to the last NLA, even an invalid NLA which could cause
>overflow writes.
>
>This patch introduces a new variable `br_flag` to save the NLA pointer
>that points to IFLA_BRIDGE_FLAGS and uses it to resolve the mentioned
>error logic.
>
>Fixes: d73ef2d69c0d ("rtnetlink: let rtnl_bridge_setlink checks IFLA_BRIDGE_MODE length")
>Signed-off-by: Lin Ma <linma@zju.edu.cn>
>---
>v1 -> v2: rename the br_flag to br_flags_attr which offers better
>          description suggested by Nikolay.

https://www.kernel.org/doc/html/v6.6/process/maintainer-netdev.html?highlight=network#tl-dr

"don't repost your patches within one 24h period"