Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2113086rbb; Tue, 27 Feb 2024 11:00:47 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV14mBUJKau/bEbUaEcZKe3K/BEE9mBzgWFPrAvQ/gw58CyDlMmqEZBTNCKnwHBMqSFGJ02YhMQcRjKkqscGU3MPtYTfAV+Y0jVe1zK/Q== X-Google-Smtp-Source: AGHT+IGsdgQGgrYZhtsgLH07hLvDlxnKmGIZQH0HNwDrnyp3ECCKyf7xrSrdbwNjAnA878goIVqf X-Received: by 2002:a17:906:271b:b0:a43:67c9:8c99 with SMTP id z27-20020a170906271b00b00a4367c98c99mr3638369ejc.40.1709060447690; Tue, 27 Feb 2024 11:00:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709060447; cv=pass; d=google.com; s=arc-20160816; b=ZSPLPYGLNITMKAzFoASDnRbaNZyeEeagFyPNU6xID3uyrnQPS5QbcLb/TDLy7giE60 OUFhgeBnTwY6FZRDgUwlL422dBoTjfAm6aI+Yx+lQ4G6sqJoBLALKSdAHO6cRiTQGtDk ey/bd2kRirC9FinvD3B5ZDT/iysEs20vMuR7ID2vsCYdy++uVvu5heF/Mm8CXxjNhUK5 f0rLU2rrpDtSA1TJ4vdeG67rk5dbjOLn1hxwTkplJjeMB3EiSM+xPIl9FfRl11IPkrTJ 1gj9r/MgygCJaP0UVd3ERBdK1Rx4uV5k1vkqHmoeXdX9/oyVB8xnosR4bD9ODI+7THlP aacg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=J95vWGrA/itCKF08JGf7hvGbO2rEbVzRQpPI5oQMvNY=; fh=dOrNcrMx5nFsXWJYpwLcpGpWEqachZHuwLK6Y9hA89k=; b=ttx3wDfuIzh7lsQ2LLI8+61liWM3gFy7ek6oblmGYBcVlod4deJ71H/KmAR/uxJXMJ I1k5ufPKI55b9PA4Fzi2QEkxbujld4cf8POYs0JKx9AnmEwVh+P9qKYKEpygiCT0Tciu NQDabfSnv9X4NfpLOqSswgfUHWdol82D5iXlt2NMI2fY2xdbbI9amUWNE36Vx+gwTb2q BFEVlmTUXGGtq7Z618tjY6AiQaXguoAzr4DzUix3SH7dV6uMBfQI/i3gApuonDC78WcG GouqbKtdWuIRFErPt5U3CvlXjHRww+el4deUkexSeXFRYjmNodLpUka/tVxwJEc2PYxy vBOg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=OyZ0imUF; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-83879-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83879-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id bk12-20020a170906b0cc00b00a43532c219asi957618ejb.271.2024.02.27.11.00.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 11:00:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83879-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=OyZ0imUF; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-83879-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83879-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7088B1F2F1CE for ; Tue, 27 Feb 2024 19:00:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6EE2F50277; Tue, 27 Feb 2024 19:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="OyZ0imUF" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 275F951C5A for ; Tue, 27 Feb 2024 19:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709060428; cv=none; b=SRZMVo2ApZuzcOLMlgfg2kgvV2oSGW6Pn++hH23zgzVkt2RaIxAkfmxAIbmnlgDws5tPEEH9EbswpfVxiv9Gaw1kv7WthMKnHyvlMR7Ie+frS2inr9MTTIuH6xG7JIeRy120JCDpJSDsDwPFm4TbaoMVh+EGLyzdbUViOZ8a4Q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709060428; c=relaxed/simple; bh=CQ7eH1Ilnoxrau6+WbQBd2Hi25j8nR7jSGSsru+q38w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I6+ei6v6FXVDsEazuL1IGtFNcxMIgKUK1dZ4O4kUDA2YmzVQsyl4onderU+i6i7BV8pWDQXVQJW7KwYWB4n8BbPDfQoFtGuLGkd+JJQWKeq0vtVqU4tIjT9dTR0fKcl8b5W8EBBHOzvtclxQoEGg6IKZG1qwQeJN/0YiMJUE5Wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=OyZ0imUF; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J95vWGrA/itCKF08JGf7hvGbO2rEbVzRQpPI5oQMvNY=; b=OyZ0imUFdwOp/UeqVRt3hYUlLQ 7NOCiitMox7FOpFW9S70Ih1iO25dq61wq+1Htm1+YaCEhJoLe2vP+RbVZpAU1eXzOQRskP+Jax0lY Iu7JlA5zENVoM4gSSRBJKSFm/HQ7lthI113D18lIW6ofixyG6feBDzv7LvsCHJxtqOnskqZFJ7lXo SQwlvPv/iA+NOsCBV8iiqxVBNqpHNa5BX4HneRgZHMiuYpqrTQtr8EwOe5HY83uRvH95psjJxAr/1 URBknVaxxOcuQP9DZnmKZqylEWNiqgUbnMthalmg7DB1V3RdUe9Cam3cp7c49mWY9wJ2/JJBN+jC0 Es2dkCxg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf2gh-000000038TL-2iOj; Tue, 27 Feb 2024 19:00:23 +0000 Date: Tue, 27 Feb 2024 19:00:23 +0000 From: Matthew Wilcox To: Jianfeng Wang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, sidhartha.kumar@oracle.com Subject: Re: [PATCH] mm/cma: convert cma_alloc() to return folio Message-ID: References: <20240227181338.59932-1-jianfeng.w.wang@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240227181338.59932-1-jianfeng.w.wang@oracle.com> On Tue, Feb 27, 2024 at 10:13:38AM -0800, Jianfeng Wang wrote: > Change cma_alloc() to return struct folio. This further increases the > usage of folios in mm/hugetlb. I love the idea, but I don't think this works. The memory returned from cma_alloc() isn't set up to be a folio, is it? That is, it doesn't have compound_head initialised so that page_folio() on consecutive pages will return the same pointer. Or have I misunderstood?