Received-SPF: pass (google.com: domain of linux-kernel+bounces-83886-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240227024050.244567-1-21cnbao@gmail.com> <Zd4HEjS6vpIvwfR9@infradead.org>
In-Reply-To: <Zd4HEjS6vpIvwfR9@infradead.org>
From: Barry Song <21cnbao@gmail.com>
Date: Wed, 28 Feb 2024 08:01:40 +1300
Message-ID: <CAGsJ_4xTtLzUKSY7EzEK0Ho61mWH35kHkidBRpjLd+_3_yOaUQ@mail.gmail.com>
Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might
 need it
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org, Barry Song <v-songbaohua@oppo.com>, 
	Lance Yang <ioworker0@gmail.com>, Ryan Roberts <ryan.roberts@arm.com>, 
	David Hildenbrand <david@redhat.com>, Yin Fengwei <fengwei.yin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 28, 2024 at 5:00=E2=80=AFAM Christoph Hellwig <hch@infradead.or=
g> wrote:
>
> On Tue, Feb 27, 2024 at 03:40:50PM +1300, Barry Song wrote:
> > From: Barry Song <v-songbaohua@oppo.com>
> >
> > madvise and some others might need folio_pte_batch to check if a range
> > of PTEs are completely mapped to a large folio with contiguous physcial
> > addresses. Let's export it for others to use.
>
> It doesn't look exported to me in the patch (and that's a good thing!).
>
> But even for making it non-static you probably want to include that in
> the series actually making use of it.

at least two parallel jobs[1][2] (maybe more ) need it right now.
Getting this one pulled in early
will help build a common base for them and avoid duplicates&conflicts in th=
em.

[1] https://lore.kernel.org/linux-mm/20240118111036.72641-7-21cnbao@gmail.c=
om/
[2] https://lore.kernel.org/linux-mm/20240225123215.86503-1-ioworker0@gmail=
com/
>
> > +extern int folio_pte_batch(struct folio *folio, unsigned long addr,
> > +             pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags,
> > +             bool *any_writable);
>
> no need for the extern here.

Yes. this has been moved to internal.h as "static inline" in v2:
https://lore.kernel.org/linux-mm/20240227104201.337988-1-21cnbao@gmail.com/

Thanks
Barry