Received-SPF: pass (google.com: domain of linux-kernel+bounces-83896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\))
Subject: Re: [PATCH] workqueue: Introduce from_wq() helper for cleaner
 callback declarations
From: Allen Pais <apais@linux.microsoft.com>
In-Reply-To: <Zd4xhvh9Drl4qrCV@slm.duckdns.org>
Date: Tue, 27 Feb 2024 11:06:28 -0800
Cc: jiangshanlai@gmail.com,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FDCF9C39-1696-4FE1-9728-31FE879AC36F@linux.microsoft.com>
References: <20240227185628.5336-1-apais@linux.microsoft.com>
 <Zd4xhvh9Drl4qrCV@slm.duckdns.org>
To: Tejun Heo <tj@kernel.org>

>=20
>=20
> On Tue, Feb 27, 2024 at 06:56:28PM +0000, Allen Pais wrote:
>> To streamline the transition from tasklets to worqueues, a new helper
>> function, from_wq(), is introduced. This helper, inspired by existing
>> from_() patterns, utilizes container_of() and eliminates the =
redundancy
>> of declaring variable types, leading to more concise and readable =
code.
>>=20
>> The modified code snippet demonstrates the enhanced clarity achieved
>> with from_wq():
>>=20
>>  void callback(struct work_struct *w)
>>   {
>>     - struct some_data_structure *local =3D container_of(w,
>> 						       struct =
some_data_structure,
>> 						       work);
>>     + struct some_data_structure *local =3D from_wq(local, w, work);
>=20
> I'm not necessarily against it but it's a bit meh in terms of how much =
it
> saves. Also, can you please name it from_work()?

  I agree :). It does help a little in conversion. Sure, will send out a =
v2 right away.

Thanks.

>=20
> Thanks.
>=20
> --=20
> tejun