Received-SPF: pass (google.com: domain of linux-kernel+bounces-83919-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 27 Feb 2024 19:23:08 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Marco Felsch <m.felsch@pengutronix.de>, lars@metafoo.de,
 robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 hns@goldelico.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: add
 spi-max-frequency binding
Message-ID: <20240227192308.52fd3a57@jic23-huawei>
In-Reply-To: <29cc9d21-6fb5-40fc-abba-c0913cd175af@linaro.org>
References: <20240221174305.3423039-1-m.felsch@pengutronix.de>
	<91f29265-36fd-4d0e-99b1-61eaada59601@linaro.org>
	<20240226124036.zzj5p7tlubc332r3@pengutronix.de>
	<29cc9d21-6fb5-40fc-abba-c0913cd175af@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 26 Feb 2024 14:18:00 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 26/02/2024 13:40, Marco Felsch wrote:
> > On 24-02-26, Krzysztof Kozlowski wrote:  
> >> On 21/02/2024 18:43, Marco Felsch wrote:  
> >>> Make use of the common spi-peripheral-props.yaml to pull in the common
> >>> spi device properties and limit the spi-max-frequency to 10 MHz as this
> >>> is the max. frequency if VDDIO >= 1.62V.  
> >>
> >> The example uses i2c, so I would expect to see in commit msg explanation
> >> which devices are SPI devices.  
> > 
> > All listed devices can either operate in I2C or in SPI mode.  
> 
> Such information in commit msg would be enough.
> 
> with the changes:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

Added the note whilst applying.

Applied to the togreg branch of iio.git and pushed out (briefly given
timing) as testing for 0-day to take a first look.

Thanks,

Jonathan