Received-SPF: pass (google.com: domain of linux-kernel+bounces-83923-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 27 Feb 2024 13:25:24 -0600
From: John Allen <john.allen@amd.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>, kvm@vger.kernel.org,
	weijiang.yang@intel.com, rick.p.edgecombe@intel.com, bp@alien8.de,
	pbonzini@redhat.com, mlevitsk@redhat.com,
	linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 5/9] KVM: SVM: Rename vmplX_ssp -> plX_ssp
Message-ID: <Zd43JFPI6cTykK7t@AUS-L1-JOHALLEN.amd.com>
References: <20240226213244.18441-1-john.allen@amd.com>
 <20240226213244.18441-6-john.allen@amd.com>
 <Zd4mf5Z1N4dFjFU7@google.com>
 <1f95281e-f8a9-4ff2-8959-162a192e48bd@amd.com>
 <Zd41wDpl4K6j+iU+@AUS-L1-JOHALLEN.amd.com>
 <Zd42tc61Epo3REK0@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zd42tc61Epo3REK0@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?caT1T+W+2E2nUpHcB3ATQe1KIj+14anoOc6SFaT6TlmZ5oN5D0uJqUatMmNW?=
 =?us-ascii?Q?FC8zuMJygeF+dUOcvwOA5WlDSV6L1ySxjMcuJhaO0XwpRpOtyc9+TBS5q/cO?=
 =?us-ascii?Q?kxqbgGtNtfekbtAXSv+4V5XhBcCCYO6gKiApAPk1zDR382go5bJvlTw8eBxg?=
 =?us-ascii?Q?ngVeTEc9GZUL4SAJ3iOWdAnqJIyjDAawtETR5YUbRPRikfiDX93veQud10yn?=
 =?us-ascii?Q?K/1ewGTjnxUQQOyaaf0UiW2oChc3o8LLru/elNGI2rt8v3pYhXlYuNd/v2jg?=
 =?us-ascii?Q?7sUF2gqjgAzS8WBN5j36k9oUU+egPRgMY91NDA6NruxoqUUraL+wwfiL7pF8?=
 =?us-ascii?Q?/bIHXvGOtPVxaiilBKKZ7B1u8gykw0aUgtHFyRw9fNGTGehgvOdt+bDmWd0M?=
 =?us-ascii?Q?/QebAIVZQDmfi+JTCIATZbR/SxSNp63d9MuKU6y8X1kW8edI5zHhV5GtOPm/?=
 =?us-ascii?Q?YgJj0kEoEnM04+t8cgPLwGhWlqgNnVKni2TZ2U19cd3T8FvkH9mMlZpv/jQC?=
 =?us-ascii?Q?4gu4AP1M1mGMNrE7NrFjAMF/26tKCgD9rmuApEObaiYwtDi4hETm6qpAvZix?=
 =?us-ascii?Q?+sxc55794/OUiHX8TaTpauEWyClL/Zo5HwCpREihzSdPdIH2LM62S0R5k6Uy?=
 =?us-ascii?Q?BN9lmAcpgL5TdLw+5whqwG63fql3VUy5CkFg2+WSD/C8WDguGc8yoxE0z0Ca?=
 =?us-ascii?Q?gliD3Fv9nNnwgkpJ7QxUIEjOzyCdg6AQu926vibY12iTYt1qe3A3m6bHu6gV?=
 =?us-ascii?Q?0f4uk0rRfAlz6WYJfzjc57FUoIx8AR2C3jv0v/MQbUJT0sUQSBTs+nw7HdGZ?=
 =?us-ascii?Q?P3jBfLt6s7XBD+JHOasHBHzJKgNOxo4K59NOuxS2qUHZTn2/QYu9qUUn9VRZ?=
 =?us-ascii?Q?nFTzWLfDlduDr8s/llHTq9OxUn9PQdTmDiB5xuy3VNVGa3D6HMNA5FYOUx3j?=
 =?us-ascii?Q?hq9DZOe8FqQ24pcUGVVcDMo5UszOxI6KjocLtnWM1iye+/SMI4bg2CS4IUbC?=
 =?us-ascii?Q?EHleNKbkviijqtp+q3rYaLxkzO4aXJpkB+WE7R3T8iXD4OM8yBqi0lQS2sGp?=
 =?us-ascii?Q?7qHKc7VsCZHr9CU3a+dsBKPCOpr1nfJ31EfDEkEQUQfuEVXOblv9qih1/5QY?=
 =?us-ascii?Q?k93SIUaYncM+FrWbfwKMTP33c/JQar+Djh/YL1guKFuXZKT4nbi01Y17W1W+?=
 =?us-ascii?Q?C0FBphH56yf+7LwAUjcf3IXSf2i7PD9pzTok+uSRLMbn2v57lGU4Rw2awX1f?=
 =?us-ascii?Q?f1efkfXw4vOsQ0ZGOIAhbedgxUiV24H1Y9wyw2Qs31YIUjCL+ovTU7wm8GD+?=
 =?us-ascii?Q?BBT1FWKpS8wgCOjtB9KJife0JtSyBvABzPhna8xQFt0SpfGkqEflKDzpPMpY?=
 =?us-ascii?Q?v8ZMBV/Bv6i3FBmbAnZaImj+eqjdMTovBjWPrYNWu9ckjbB1U24CCPzwQA3S?=
 =?us-ascii?Q?WmmqT0Ng9tlGkehtTCGFm+/zRAG+zuvqzLYT+SGCrJveSiuOULp7D3oIbaWR?=
 =?us-ascii?Q?gZBnRjhf0nvdesvo6fT1B+dQdY4rYk4h1Ic67ZR/Q0opc8Z2lLAEi/dQYJi8?=
 =?us-ascii?Q?7G16szNhNBmZIaD41e4iIdMlX49LdUDMwZAjULYZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fca5778-5a75-494d-afd8-08dc37c9daff
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5995.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 19:25:28.3363
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: phhoZvpgMj9eEcVEzwlVcfkYm5e42ixkxuMormoxHylQMfrnM9tNpTWeWLe3+8ZBNqezCsWMGzeHM21+RqzUxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6535

On Tue, Feb 27, 2024 at 11:23:33AM -0800, Sean Christopherson wrote:
> On Tue, Feb 27, 2024, John Allen wrote:
> > On Tue, Feb 27, 2024 at 01:15:09PM -0600, Tom Lendacky wrote:
> > > On 2/27/24 12:14, Sean Christopherson wrote:
> > > > On Mon, Feb 26, 2024, John Allen wrote:
> > > > > Rename SEV-ES save area SSP fields to be consistent with the APM.
> > > > > 
> > > > > Signed-off-by: John Allen <john.allen@amd.com>
> > > > > ---
> > > > >   arch/x86/include/asm/svm.h | 8 ++++----
> > > > >   1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > 
> > > > > diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
> > > > > index 87a7b917d30e..728c98175b9c 100644
> > > > > --- a/arch/x86/include/asm/svm.h
> > > > > +++ b/arch/x86/include/asm/svm.h
> > > > > @@ -358,10 +358,10 @@ struct sev_es_save_area {
> > > > >   	struct vmcb_seg ldtr;
> > > > >   	struct vmcb_seg idtr;
> > > > >   	struct vmcb_seg tr;
> > > > > -	u64 vmpl0_ssp;
> > > > > -	u64 vmpl1_ssp;
> > > > > -	u64 vmpl2_ssp;
> > > > > -	u64 vmpl3_ssp;
> > > > > +	u64 pl0_ssp;
> > > > > +	u64 pl1_ssp;
> > > > > +	u64 pl2_ssp;
> > > > > +	u64 pl3_ssp;
> > > > 
> > > > Are these CPL fields, or VMPL fields?  Presumably it's the former since this is
> > > > a single save area.  If so, the changelog should call that out, i.e. make it clear
> > > > that the current names are outright bugs.  If these somehow really are VMPL fields,
> > > > I would prefer to diverge from the APM, because pl[0..3] is way to ambiguous in
> > > > that case.
> > > 
> > > Definitely not VMPL fields...  I guess I had VMPL levels on my mind when I
> > > was typing those names.
> > 
> > FWIW, the patch that accessed these fields has been omitted in this
> > version so if we just want to correct the names of these fields, this
> > patch can be pulled in separately from this series.
> 
> Nice!  Can you post this as a standalone patch, with a massage changelog to
> explain that the vmpl prefix was just a braino?
> 
> Thanks!

Will do.

Thanks,
John