Received-SPF: pass (google.com: domain of linux-kernel+bounces-83924-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <cf6c758a-42a9-4d4c-a1f7-71f4fc09e8a0@oracle.com>
Date: Tue, 27 Feb 2024 11:26:02 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm/cma: convert cma_alloc() to return folio
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, sidhartha.kumar@oracle.com
References: <20240227181338.59932-1-jianfeng.w.wang@oracle.com>
 <Zd4xR9sojA-4Mdwm@casper.infradead.org>
Content-Language: en-US
From: Jianfeng Wang <jianfeng.w.wang@oracle.com>
In-Reply-To: <Zd4xR9sojA-4Mdwm@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?YldTeUtiVjZESG5oUFRHRUo0dzFNNWF6c1k4ZGhKL0ZmbWZrbXA4OXphUkxs?=
 =?utf-8?B?WEhBa0dIT1Nsc2xyZWtCTWNuODV3MXNmSHczMStobWtMOHhza1gyWWYrRDZM?=
 =?utf-8?B?YTJkN3ZXbzhOdXBBRGcrRC9hQVV6OHQ0aVk4Z2tOZGZBcjloWHJUb2grQXVW?=
 =?utf-8?B?Q1NHUzBkbU9KdzRPZDQwSlBuQjVsT3Z4R29tMmJoV01TVkJjbGpzTjN4YlRn?=
 =?utf-8?B?ZFJ2Y3lWYVh2ekVoYkkzUDFHWmRueThnaHUzdjVlakVJYzNSSUZrdURGYk9y?=
 =?utf-8?B?MDJSUjZBRGZUajZuYVRKSDlIRjVPdzgyVnRyeFBpSHdibHc4cVVHalFWNWdx?=
 =?utf-8?B?eVd2WXBPY2ZsdmREbXI4Myt5TGxRSEh1clNCaUJWV0E5RzF4Yld2YmliaHJQ?=
 =?utf-8?B?MWszY2tQek4yM3BXOUtEb3BCS3hRNVlHakNHNEV2UW9qWUFTN1pTeitQVzdj?=
 =?utf-8?B?a2UvQWMzc0RGZXUrakF3aVNpWW5qTk5tamdDbzF5QWdmZmo5MFJiY2FRMEoz?=
 =?utf-8?B?T2duQUpSMW1XdFA1VnF2OENxcGRsOUh1enZmRHE5WVFDNnlLV0l6cW1IM0hO?=
 =?utf-8?B?aGxVQldrYTl5WlplSUp1M1dOaENwSGdOSmVEZ2dzb1NISWdidi9HMzUrK01M?=
 =?utf-8?B?eVA3Q1Nwb3M0SUNxZkg0NHcyQVA4QTRNU1ZUK1QwMjVWdjc4SU5lUU1kUEF4?=
 =?utf-8?B?ekZOaVBtVHdQNCt0dlVhSEllTVJzL0dKUW9XN29CZ2FvUTN2S1k3c1JyekFk?=
 =?utf-8?B?T0t4M01mQzhMU0VJcWlodEhJcGtCeHV1MFEzSWlmUHhUa0lmN1dqK1UrbmFm?=
 =?utf-8?B?dGR6SHV5QVh3aGhQbFgzN1l1YmlqazFVcGorZGZZKyt2RTU3K0NxbjZJS0xa?=
 =?utf-8?B?RmJQOXlzMWtVUlRVN2hDcDdsNkR1Q2lrL043TlFwVk9jUXphWkcwTCtnN0xi?=
 =?utf-8?B?UGpvU3BBUVByM2k3R1dFUm56M29hb0l5YmhzVE40blFtYXFYeHp3ZUNoTUVC?=
 =?utf-8?B?QkpCRENUNWFteGRUck1JWGVhUVdrMHVRL1N5M3J4SmZ2YUJ1UVBEUmxyT0d0?=
 =?utf-8?B?b2k5Q1NvcUFjUjFwYnpUYVdNRGNjaFc5M0lXVWUyMEJuN2hWNUdMOXJoWjli?=
 =?utf-8?B?dFpWQVJNUFJhcm5aYlcxc2xwakJNQnk3SmRtSDU2eW9MSm5zZlVNVXRyM0cy?=
 =?utf-8?B?WVFObzhhTjdyaWtTcUsrQlZWVEdWTlRidkFLemcwUHIxZ2J5bXdhckZNcEk5?=
 =?utf-8?B?Q1NQSnJOK0dUQ05KcHRyWHpTaXdQMHFDMDRLTlI3eWZBT3JJNlo0SHdQS2ZX?=
 =?utf-8?B?VzlzRVM5dnBDaGVwaGFnNHVVbDdFTkhibzA3N0c1dFFjaHY3KzZ5cC9Sc3VQ?=
 =?utf-8?B?amNvNzBaY09zQlh5K1RoUFozOTV2djloU3lmdXRYYWg4a0Z2N0pJYlM2MmFT?=
 =?utf-8?B?UjU5QnpPeXhwQVRyVm9nTjdnbEpUb252TUYxM3ZpNDdvQ3JzaUlvemI0eXlO?=
 =?utf-8?B?SFdoT3pxWHBuNEZXcTBSdjdYaDBGQ0JFVVBKU2xSL0V0aUM4V0t3ckwxdXJM?=
 =?utf-8?B?UjI5U3pJTUlTU3l1SEVqWmtOTkdYYkJoakpXZE01QUNIb2hWOENxQWRDVVRs?=
 =?utf-8?B?VzFvellSbDFYTC9pS3BCeHNzVk95U2JzbjdXV2lPRkxXZk02YmhDN2FCK28y?=
 =?utf-8?B?MDdLcXJFclpmUy9DbDhOVU4xUFdNQ3M2ZlUrME4xSlQ4ekQ0U1FrQWdKdWV2?=
 =?utf-8?B?emxyb09ieStrbTl6OHIyMitteHM1MmxmcVB5TytkVXh3SG5iWG5DaEtCTW9K?=
 =?utf-8?B?bFovSDZ5aWtsMmF5UHpiVlZuY1gwakFYQi94TEZ4UE9VWkN6b2FLakVDZWRQ?=
 =?utf-8?B?ZXNLbmFWNVBnbUFMeTJKbGxVY1NOMWpDZ1FIY2VXeDk0dG9sOFlzTkYzb3po?=
 =?utf-8?B?bGdNNmFnWmRhQUVMZ3czM0RrV0UxNzczZ3pWSjV3TXorMklRR1dXWUlGTmdL?=
 =?utf-8?B?Z1g5YmhKYkJKUjhudHYrVDFMQmVMK3M2STZRellyQjhCWEhjTjRBcXpER0JR?=
 =?utf-8?B?Tlg5bEVXcVEvc1p5aTYzNXZqQnhMZTRwaTVNTXl4bWUyZ3phZWl6MGMwQlYz?=
 =?utf-8?B?VTJ2TEdremVYcHlpckdrZU5ZSExsdkFMb1FqVElWZk5PelZZcHNOUi8xOC9Y?=
 =?utf-8?B?Wnc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Z9PT1zEBHjrP9GX7Kgx1gDa94kyVyvJzUxBAAEEuc3EfktO81CBtnk5a1/mGd3Szat18Rxu2b3Yg4Xg9VTPziMTp12YWwZV4wWQCrYPTVfefpwoIJK3wxFX29A5vumxLQmKVvxFmt/uPfroY5iTd3zgvTeqZrLq3G8uk6g7hgve20z+VG/ap+dxHFlsD/xP/qASajTWY3cQFub99dTPxA+gGddafa9E1JxLTaxFv+rA6surnh2lX85upSb5Ffce2fWpiIarUUK8vWvlH0rq7EjrCF/wtri1PNm7Dl2QWufOHuhMylynAr5+BptBtMYLk5Fpn51HRxlWao/+/nwkWXWiKmm066QY2s4xpquXUwPMKwHD+IcwVmvpqU+ond0HolSn9f069hw6w4IXpfM/58QZ+y/pstvtm6C5GYePOO3AIkbh0ow5+eF/YbTWFRznZ9ooW8xwe+bsZjfvHBNt9rnmm+5LL61++2YJpRnBmBepOGK4T1d2fjfR8etzO/W2Y0l246FTTNaWnAGvj75m3+nWQsoDrGfev74IWS9NPcXuL5C9NPNnw/rLUOlnKv95yerY6bliGFZNfV9KXX94Nn2+lVLOZNkjSXVc1534TIqA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65fc6962-9aed-4355-7838-08dc37c9f0f3
X-MS-Exchange-CrossTenant-AuthSource: SN7PR10MB6382.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 19:26:05.1342
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L5pJfz3Xz1INQ8TR9EESV2bKek4IoY6U3CuEh0qM6WDsFGgmncEU+vjMK9HMlvIzyjWjilzL/o0j1FXTQq1hOYvvRT0fIShUYCQpYTiGLxc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6638
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-27_06,2024-02-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 spamscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402270151
X-Proofpoint-GUID: 8Zzp7IBUT1iGHpBmJZJl0ynRlRzlOlB4
X-Proofpoint-ORIG-GUID: 8Zzp7IBUT1iGHpBmJZJl0ynRlRzlOlB4


On 2/27/24 11:00 AM, Matthew Wilcox wrote:
> On Tue, Feb 27, 2024 at 10:13:38AM -0800, Jianfeng Wang wrote:
>> Change cma_alloc() to return struct folio. This further increases the
>> usage of folios in mm/hugetlb.
> 
> I love the idea, but I don't think this works.  The memory returned
> from cma_alloc() isn't set up to be a folio, is it?  That is, it
> doesn't have compound_head initialised so that page_folio() on
> consecutive pages will return the same pointer.
> 

Thanks for review.
cma_alloc() returns an array of order-0 pages. So, this commit makes
cma_alloc() return an array of folios (each an order-0 page) rather
than a compound page. Functions that use cma_alloc() do not expect
a compound page as well.

> Or have I misunderstood?