Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2137970rbb; Tue, 27 Feb 2024 11:46:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWp0ybYd8cERh3h00O5vtvCKPp+LewpyxPeNnCItchfZoDGn43XKGK6+f5JGQsqV5IyVdB+chbtIHizA25Ry/4Q9KflXexLpKiNVV2kdw== X-Google-Smtp-Source: AGHT+IGQgYFpX4SSs357VasdGx1IPh16PNuJ/HybuU5EAmgO2TWvRGzHM1ONE7VmK/VumCOnI2Bd X-Received: by 2002:a17:906:488c:b0:a43:6136:f1f2 with SMTP id v12-20020a170906488c00b00a436136f1f2mr307885ejq.25.1709063203788; Tue, 27 Feb 2024 11:46:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709063203; cv=pass; d=google.com; s=arc-20160816; b=mIGq6OlsIzM9L6YFSe7mQSjvBwLrwDqzTrs54fH8D6oh40q8UtSUAJp9EHNMpYFnM7 Ox4LnQYdrzQHp6/uGDipZ17h/5HW6b7cVToTFYKtiv8/LfH+38t3iAosq6oFfj81VIoG k3b+GYWxASf19mufYeruAp1BeIgi1nxnPEXgxGhI10WDT1Dvfnl6e683pSME3BMD4w7R 9zyuIlo2OqjZKRHIgKT4SR8rUJeBMiHQzqUSTMmJfmCsXKlazUef0GIDWis449YTVifG CLE2n2i70ZmI1lvQpogPmiu1Szb10DnIQDKsntpNOsQhusrPGQEaaXkLEbZvA412ITeo W92g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gjl5DhImKtXFO2OnbyFX2WAmTlM7Sa7herXxx57PDGI=; fh=hK9az9t+ZYtEffSqxlt3Oy7aCFSL8legez2YtzTE24E=; b=ovqB/E6lsX+ijj5EhH2uXkCMgA7+F3k1WQVrecme0d9ePELpiiCcPQzM55dXsIsxBc tX5ku3lxZT3bPRLAuY94WAA6BGqMwV+tV8ntj6G4wgYMl3HgIMnVMfwgUokLVHtN5XLI VNr9yrO2egA6Coh/3i7QdAyrR67o7O7Wf9db4KWKsuiP8SAPsfADII1TfFdf2/QzfOQq rwxqMEidHvv223GhRRVhoEw3iVycgunVDdz48lqY6PNRIQ7OVQXBvZ5uaK73jUmJ3Yvg qzmIJi7FXACz0R/D944IYf8AdiwZPAPDRCX1xXqI6nKoygKF9MW07bLD/2lwlsJDloRT BfFg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=Ee1shJSH; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-83948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83948-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id mj11-20020a170906af8b00b00a3f21ca2030si966404ejb.907.2024.02.27.11.46.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 11:46:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=Ee1shJSH; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-83948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83948-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D39C21F24BF4 for ; Tue, 27 Feb 2024 19:46:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 08168146908; Tue, 27 Feb 2024 19:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="Ee1shJSH" Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC87C4F896; Tue, 27 Feb 2024 19:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709063183; cv=none; b=UNUuXUn3yX3tKwAtL9Ep3WLSghBlQ7T+qS9mBHtvKJ+SgqsRRK0NSNae7+qZxhaqUFfhBK/3HS5MZlguXvf5MpYlp/hsSm5AV2tA3fjjBRO81ez6l0rt1xAJXBc8ql+GBItNLSY0AQIm63bINU4KIWOp+7Qsjn0MlywcjnNqBGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709063183; c=relaxed/simple; bh=N7KwRP5bKOkxPnEHeYIOMj734ueqXgEYKkuX+3PGk9o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N9gSMBPOPpKElJXuFBE84ESuLqzeU991tqigP9RYkq6RwXoXSm/DiILXrdHihuJRvAETWgPryUcofKWrZMwdn96OVX36hEv+I7ckTlViV/pNsK5TsVjHi+ZscLRS6Jf/qXoHfXCzF9rvsahsU9lzzILtN3mWtAiQdSst6qvIBhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=Ee1shJSH; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 5D0FE40E0192; Tue, 27 Feb 2024 19:46:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RP2JviedFxYr; Tue, 27 Feb 2024 19:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1709063172; bh=gjl5DhImKtXFO2OnbyFX2WAmTlM7Sa7herXxx57PDGI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ee1shJSHTTY77pOxeV6lX9PhBW24vkwAZu1GFfbSQP/GOp+n9e88TWmMrHM6I6Pcn K+xsMh0aZ5ciPX/htrgTf0j5HaW7jV8fq46EsCFW+MAYBJGZxzw5lBn9q9gnodbJEv 9g7Ep60KgsioFQh5meWvdWoExXXn54F/xKVh+xLln8b+R5D+6y8w9ql+dFhIyqEgTk f42MS0vJBDbRzPoHNQWmlyabBldRkPD32sJ7AWxbuwM8PW6ZoJA1dMNas9qBYpb76O E1xusY43RPH7sqn8NHjQpYta/17NCgYYRNsseeZkoVP6YSkwlZng1U/ikvMqQZ0CgK EaPQPmWOQPhfKobeoKoW9YKsuYOzHprbwikeCihCjq3uM8YdvuhbF+aW+s10MoflO9 LBsIhQ9SZ/yw6sF2If+XaPDx7jxJw+X6oqCid05j45b1w7MHOz0lCjr4436ANuN9sS yA5QrBqN6THK3K0Qpp9MqjvkJLIimKUz0bQNXkGzrq4HXjo79BNVsTDpC64igo3USi jKie2nDQgidmsrIKf2Y9Hyw6Ig/YJuUpVqGy58IShs7d2uUAJCVqRpYhBtmmuh3nmA iWhtTzdX4XuYhpQJzkgfC7zzSO4lKBQdEsIzC52VAG4jjaD1phKnCRlNi4CnZKUqd0 qDnDpTaJh6f8X/9BAzKur2B0= Received: from zn.tnic (pd953021b.dip0.t-ipconnect.de [217.83.2.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4D71740E016B; Tue, 27 Feb 2024 19:46:02 +0000 (UTC) Date: Tue, 27 Feb 2024 20:45:56 +0100 From: Borislav Petkov To: John Allen Cc: kvm@vger.kernel.org, weijiang.yang@intel.com, rick.p.edgecombe@intel.com, seanjc@google.com, thomas.lendacky@amd.com, pbonzini@redhat.com, mlevitsk@redhat.com, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 1/9] x86/boot: Move boot_*msr helpers to asm/shared/msr.h Message-ID: <20240227194556.GEZd479Ek_lSfMf30b@fat_crate.local> References: <20240226213244.18441-1-john.allen@amd.com> <20240226213244.18441-2-john.allen@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240226213244.18441-2-john.allen@amd.com> On Mon, Feb 26, 2024 at 09:32:36PM +0000, John Allen wrote: > The boot_rdmsr and boot_wrmsr helpers used to reduce the need for inline > assembly in the boot kernel can also be useful in code shared by boot > and run-time kernel code. Move these helpers to asm/shared/msr.h and > rename to raw_rdmsr and raw_wrmsr to indicate that these may also be > used outside of the boot kernel. > > Signed-off-by: John Allen > --- > v2: > - New in v2 > --- > arch/x86/boot/compressed/sev.c | 10 +++++----- > arch/x86/boot/cpucheck.c | 16 ++++++++-------- > arch/x86/boot/msr.h | 26 -------------------------- > arch/x86/include/asm/shared/msr.h | 15 +++++++++++++++ > 4 files changed, 28 insertions(+), 39 deletions(-) > delete mode 100644 arch/x86/boot/msr.h Acked-by: Borislav Petkov (AMD) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette