Received-SPF: pass (google.com: domain of linux-kernel+bounces-83880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Sender: Tejun Heo <htejun@gmail.com>
Date: Tue, 27 Feb 2024 09:01:26 -1000
From: Tejun Heo <tj@kernel.org>
To: Allen Pais <apais@linux.microsoft.com>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: Introduce from_wq() helper for cleaner
 callback declarations
Message-ID: <Zd4xhvh9Drl4qrCV@slm.duckdns.org>
References: <20240227185628.5336-1-apais@linux.microsoft.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240227185628.5336-1-apais@linux.microsoft.com>

On Tue, Feb 27, 2024 at 06:56:28PM +0000, Allen Pais wrote:
> To streamline the transition from tasklets to worqueues, a new helper
> function, from_wq(), is introduced. This helper, inspired by existing
> from_() patterns, utilizes container_of() and eliminates the redundancy
> of declaring variable types, leading to more concise and readable code.
> 
> The modified code snippet demonstrates the enhanced clarity achieved
> with from_wq():
> 
>   void callback(struct work_struct *w)
>    {
>      - struct some_data_structure *local = container_of(w,
> 						       struct some_data_structure,
> 						       work);
>      + struct some_data_structure *local = from_wq(local, w, work);

I'm not necessarily against it but it's a bit meh in terms of how much it
saves. Also, can you please name it from_work()?

Thanks.

-- 
tejun