Received-SPF: pass (google.com: domain of linux-kernel+bounces-83906-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <1f95281e-f8a9-4ff2-8959-162a192e48bd@amd.com>
Date: Tue, 27 Feb 2024 13:15:09 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 5/9] KVM: SVM: Rename vmplX_ssp -> plX_ssp
Content-Language: en-US
To: Sean Christopherson <seanjc@google.com>, John Allen <john.allen@amd.com>
Cc: kvm@vger.kernel.org, weijiang.yang@intel.com, rick.p.edgecombe@intel.com,
 bp@alien8.de, pbonzini@redhat.com, mlevitsk@redhat.com,
 linux-kernel@vger.kernel.org, x86@kernel.org
References: <20240226213244.18441-1-john.allen@amd.com>
 <20240226213244.18441-6-john.allen@amd.com> <Zd4mf5Z1N4dFjFU7@google.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
Autocrypt: addr=thomas.lendacky@amd.com; keydata=
 xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1
 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn
 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN
 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb
 aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez
 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA
 udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6
 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg
 hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U
 NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj
 a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK
 CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmWDAegFCRKq1F8ACgkQ
 3v+a5E8wTVOG3xAAlLuT7f6oj+Wud8dbYCeZhEX6OLfyXpZgvFoxDu62OLGxwVGX3j5SMk0w
 IXiJRjde3pW+Rf1QWi/rbHoaIjbjmSGXvwGw3Gikj/FWb02cqTIOxSdqf7fYJGVzl2dfsAuj
 aW1Aqt61VhuKEoHzIj8hAanlwg2PW+MpB2iQ9F8Z6UShjx1PZ1rVsDAZ6JdJiG1G/UBJGHmV
 kS1G70ZqrqhA/HZ+nHgDoUXNqtZEBc9cZA9OGNWGuP9ao9b+bkyBqnn5Nj+n4jizT0gNMwVQ
 h5ZYwW/T6MjA9cchOEWXxYlcsaBstW7H7RZCjz4vlH4HgGRRIpmgz29Ezg78ffBj2q+eBe01
 7AuNwla7igb0mk2GdwbygunAH1lGA6CTPBlvt4JMBrtretK1a4guruUL9EiFV2xt6ls7/YXP
 3/LJl9iPk8eP44RlNHudPS9sp7BiqdrzkrG1CCMBE67mf1QWaRFTUDPiIIhrazpmEtEjFLqP
 r0P7OC7mH/yWQHvBc1S8n+WoiPjM/HPKRQ4qGX1T2IKW6VJ/f+cccDTzjsrIXTUdW5OSKvCG
 6p1EFFxSHqxTuk3CQ8TSzs0ShaSZnqO1LBU7bMMB1blHy9msrzx7QCLTw6zBfP+TpPANmfVJ
 mHJcT3FRPk+9MrnvCMYmlJ95/5EIuA1nlqezimrwCdc5Y5qGBbbOwU0EVo1liQEQAL7ybY01
 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb
 r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I
 bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2
 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO
 lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9
 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M
 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8
 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob
 pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+
 LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe
 /5rkTzBNUwUCZYMCBQUJEqrUfAAKCRDe/5rkTzBNU7pAD/9MUrEGaaiZkyPSs/5Ax6PNmolD
 h0+Q8Sl4Hwve42Kjky2GYXTjxW8vP9pxtk+OAN5wrbktZb3HE61TyyniPQ5V37jto8mgdslC
 zZsMMm2WIm9hvNEvTk/GW+hEvKmgUS5J6z+R5mXOeP/vX8IJNpiWsc7X1NlJghFq3A6Qas49
 CT81ua7/EujW17odx5XPXyTfpPs+/dq/3eR3tJ06DNxnQfh7FdyveWWpxb/S2IhWRTI+eGVD
 ah54YVJcD6lUdyYB/D4Byu4HVrDtvVGUS1diRUOtDP2dBJybc7sZWaIXotfkUkZDzIM2m95K
 oczeBoBdOQtoHTJsFRqOfC9x4S+zd0hXklViBNQb97ZXoHtOyrGSiUCNXTHmG+4Rs7Oo0Dh1
 UUlukWFxh5vFKSjr4uVuYk7mcx80rAheB9sz7zRWyBfTqCinTrgqG6HndNa0oTcqNI9mDjJr
 NdQdtvYxECabwtPaShqnRIE7HhQPu8Xr9adirnDw1Wruafmyxnn5W3rhJy06etmP0pzL6frN
 y46PmDPicLjX/srgemvLtHoeVRplL9ATAkmQ7yxXc6wBSwf1BYs9gAiwXbU1vMod0AXXRBym
 0qhojoaSdRP5XTShfvOYdDozraaKx5Wx8X+oZvvjbbHhHGPL2seq97fp3nZ9h8TIQXRhO+aY
 vFkWitqCJg==
In-Reply-To: <Zd4mf5Z1N4dFjFU7@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R2V0ZThSYkNXMGVZZnhwNFMxMGRxTUgwYUpJQllTNnJka2ZZeUoxVHloZDYy?=
 =?utf-8?B?L2k5RnFxL3pSU2ptRFg1ZmZBdU9rSUdNU0tKQjB5a0F2eDFoUkFWNk16RVp2?=
 =?utf-8?B?Zk5FS2xibXhzaEtFdDFFWVpjc2pYK0ozQWt4Z0NTdEZtV2JMVUVXQm90blZz?=
 =?utf-8?B?Y1JUUWl6VEJiQUdkRS9uU2JoNklpamw3cHN3SzBxWEI1ZTFlKzZMZFZmb1J5?=
 =?utf-8?B?Y0hVTUh1NHFXdGdHbFlQMzhUQUxyN3dVRlEzSXgxbWZwa2QrdkU2MnFBaEQ4?=
 =?utf-8?B?bkkyL0Y2UVVHMHZPUWZZdnhnMFAwWU9nRlpTS1FjaU1BejJBRVJkRXExVG1l?=
 =?utf-8?B?L0JQNytTVVpRVCt1WEVqNTE2bE9iSlNRUVBiYmFzdmZRbFpoeVdKVWlWa2dn?=
 =?utf-8?B?RlBHZUF0RjM1ejlpYkFYRVIyNjZNTS9Ydm5ZS2kxeEVrQjNOTWNkNjh4enQv?=
 =?utf-8?B?bXVyN0VITng5Z05XcWVndGNqVTVEd09SY2t4TjZ4Q0t1S05JV2tZcHdGSW9K?=
 =?utf-8?B?OFpoM2NJeks5NkZJTGw0eXByOGhkZTBNNW5NTnBxcG41MmRZdDJRVWJyUG44?=
 =?utf-8?B?UTRlS1U2K3B2Q3F0aXgvWSt1N3RBWWIvRTJSb0NGeEsyakRoS0dLNEdLUWZG?=
 =?utf-8?B?Qm9KYWxWVElmKzk5ZHp6SjFaMCtCVE9uckN6ZStJTjJ2L2hKVm5ndTJKNWph?=
 =?utf-8?B?QWJVcVA0MW12NVJtUDBSNVAxS3NCK01BNkNsTmp2WXh4cThWK0w1MjlIb2g4?=
 =?utf-8?B?OEMrblpONXFTL3l2cTRRRmhIOXBJNW9KZTR4TlRpYjBrOWxzemhiL25lVGNq?=
 =?utf-8?B?TDRTTEp3bndVam1MTEE3bHd1UE0xTkU2SDRxaWU2VUhLR0VnVUVpRFRZK1lm?=
 =?utf-8?B?dG1yRXhuWmFNazNZU0NSNFA2amkrcTFRWEprTEV6by91UG9FekRrMGpuS3dp?=
 =?utf-8?B?ZkFTcDhrQTJoNTJJT0x2L3NYazhaaUdkU0UvYmRpL29YKzZvY1c2SW9rZ3RT?=
 =?utf-8?B?cCtvRDRpVHE0Tk1MNU5XbHdxZkcvbVIrc1BPWlE2c0JpVEJyVWl1dXFZbnp1?=
 =?utf-8?B?a29BNzJlaHkxeXhZRkVjenBpc1Y0aVBmcCtrdnI1UVduOS9JM1hmbThFTEtG?=
 =?utf-8?B?TTQvN0xRQXdoZEZwVzZPQlFZcWlVYUdzNFhzK2ZOd2tSK0YraXRzY2xFY2J2?=
 =?utf-8?B?a09BaTZ6SzNJMEZGZmExSmh4UXpCbjMvaTlWbkYxclN2ckVaSUpZalBnejZL?=
 =?utf-8?B?Y3h2c0xRNWxuUDFBbTFlTWhtSDRRVnVQM0haYmxiNVZIMFpUejNJaFdYY2Yr?=
 =?utf-8?B?eXJ6ZWFZbXY2clhWSW5HanBsRjFjaDBLTTJOcUpaSjE4VDY2YWpUWVY1WFpO?=
 =?utf-8?B?b2tONXBJQUtXTHRrc2NnU2FYU0doa2RlaXNmaXlDeWN0Mmp4TTVTaEI1UXZh?=
 =?utf-8?B?bndHSG9KN2MzdDlrN1lFOUpKWnpVNjZoc3YvV3pQdFFoNDVRSzV0YklscndZ?=
 =?utf-8?B?NWkwK25kUktHRGMvUlY5WFZVODZwMXg4eVN4bDdONUQ3cUxWUTY1SW9GSFBK?=
 =?utf-8?B?aVVGR21ybU5kZjRoZHlqTG05S0ZOU1VScmpCdlhiVHdGbk9kZmtHZ1FhT0FX?=
 =?utf-8?B?UjdINGJabW9QMmlNdVpYanBFbjV6anhRWnZ1SnAvaHl0OGdQWVFnV1kwYnFB?=
 =?utf-8?B?SUdPNGZxSlg2ZnhjbnJvWXErZG1vY0ZOQzBVZS9tOVVjMjZuci9CMGYzMHZy?=
 =?utf-8?B?SHd4TzFTajBhT2kwWnVDRmcvenUxV3dxNkVpemx0SnNDYS96UHduVHNRMnEw?=
 =?utf-8?B?TTBqWWtSU3BCK1hCQm5WeWpwYlk2Y1ljbjhvK1dOMlZnaXQ3WHJsN29LN2ND?=
 =?utf-8?B?aXhEQnlpYzRkSEVMckVVZCtUR3ZnMENMcmZKd01mclVUZy9hbHNrc1RmbCtO?=
 =?utf-8?B?eUYvZnBQVGpYQ1htU1JRaFpBVFNGUm13ZEYvRy9BU1JjWXVuQW54cHh6bFBK?=
 =?utf-8?B?eGZ0bFZvSHAzeEdhYVlESmFldHg5OExKM0p3YnhzQ2YrNXlvenVDTEtGdjJu?=
 =?utf-8?B?dnBQNm1Ed0V1Qkk1WWFYcEwzb2xMMm5WWnhzSlhqTEJUVmY4UmFJaUtrL1JZ?=
 =?utf-8?Q?QeVDlcC3bzoH6apwShX6mHoaH?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ceeead23-f961-4eef-8055-08dc37c86b68
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 19:15:11.6138
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v0H2jEWliESEAApKH20iwzOgRIVxabOHrN+93HN/Irs7hgx5rdZCzSScFYbKs2cM/lZK0OhSYJxMVYP1+A5Arg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7973

On 2/27/24 12:14, Sean Christopherson wrote:
> On Mon, Feb 26, 2024, John Allen wrote:
>> Rename SEV-ES save area SSP fields to be consistent with the APM.
>>
>> Signed-off-by: John Allen <john.allen@amd.com>
>> ---
>>   arch/x86/include/asm/svm.h | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
>> index 87a7b917d30e..728c98175b9c 100644
>> --- a/arch/x86/include/asm/svm.h
>> +++ b/arch/x86/include/asm/svm.h
>> @@ -358,10 +358,10 @@ struct sev_es_save_area {
>>   	struct vmcb_seg ldtr;
>>   	struct vmcb_seg idtr;
>>   	struct vmcb_seg tr;
>> -	u64 vmpl0_ssp;
>> -	u64 vmpl1_ssp;
>> -	u64 vmpl2_ssp;
>> -	u64 vmpl3_ssp;
>> +	u64 pl0_ssp;
>> +	u64 pl1_ssp;
>> +	u64 pl2_ssp;
>> +	u64 pl3_ssp;
> 
> Are these CPL fields, or VMPL fields?  Presumably it's the former since this is
> a single save area.  If so, the changelog should call that out, i.e. make it clear
> that the current names are outright bugs.  If these somehow really are VMPL fields,
> I would prefer to diverge from the APM, because pl[0..3] is way to ambiguous in
> that case.

Definitely not VMPL fields...  I guess I had VMPL levels on my mind when I 
was typing those names.

Thanks,
Tom

> 
> It's borderline if they're CPL fields, but Intel calls them PL[0..3]_SSP, so I'm
> much less inclined to diverge from two other things in that case.