Received-SPF: pass (google.com: domain of linux-kernel+bounces-83994-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 27 Feb 2024 20:51:12 +0000
From: Matthew Wilcox <willy@infradead.org>
To: Jianfeng Wang <jianfeng.w.wang@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, sidhartha.kumar@oracle.com
Subject: Re: [PATCH] mm/cma: convert cma_alloc() to return folio
Message-ID: <Zd5LQHoSAqC9HFv8@casper.infradead.org>
References: <20240227181338.59932-1-jianfeng.w.wang@oracle.com>
 <Zd4xR9sojA-4Mdwm@casper.infradead.org>
 <cf6c758a-42a9-4d4c-a1f7-71f4fc09e8a0@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cf6c758a-42a9-4d4c-a1f7-71f4fc09e8a0@oracle.com>

On Tue, Feb 27, 2024 at 11:26:02AM -0800, Jianfeng Wang wrote:
> 
> 
> On 2/27/24 11:00 AM, Matthew Wilcox wrote:
> > On Tue, Feb 27, 2024 at 10:13:38AM -0800, Jianfeng Wang wrote:
> >> Change cma_alloc() to return struct folio. This further increases the
> >> usage of folios in mm/hugetlb.
> > 
> > I love the idea, but I don't think this works.  The memory returned
> > from cma_alloc() isn't set up to be a folio, is it?  That is, it
> > doesn't have compound_head initialised so that page_folio() on
> > consecutive pages will return the same pointer.
> 
> Thanks for review.
> cma_alloc() returns an array of order-0 pages. So, this commit makes
> cma_alloc() return an array of folios (each an order-0 page) rather
> than a compound page. Functions that use cma_alloc() do not expect
> a compound page as well.

No, this is not the way.