Received-SPF: pass (google.com: domain of linux-kernel+bounces-83560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 27 Feb 2024 08:00:18 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Barry Song <21cnbao@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Barry Song <v-songbaohua@oppo.com>,
	Lance Yang <ioworker0@gmail.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	David Hildenbrand <david@redhat.com>,
	Yin Fengwei <fengwei.yin@intel.com>
Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might
 need it
Message-ID: <Zd4HEjS6vpIvwfR9@infradead.org>
References: <20240227024050.244567-1-21cnbao@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240227024050.244567-1-21cnbao@gmail.com>

On Tue, Feb 27, 2024 at 03:40:50PM +1300, Barry Song wrote:
> From: Barry Song <v-songbaohua@oppo.com>
> 
> madvise and some others might need folio_pte_batch to check if a range
> of PTEs are completely mapped to a large folio with contiguous physcial
> addresses. Let's export it for others to use.

It doesn't look exported to me in the patch (and that's a good thing!).

But even for making it non-static you probably want to include that in
the series actually making use of it.

> +extern int folio_pte_batch(struct folio *folio, unsigned long addr,
> +		pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags,
> +		bool *any_writable);

no need for the extern here.