Received-SPF: pass (google.com: domain of linux-kernel+bounces-84055-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 27 Feb 2024 13:28:18 -0800
In-Reply-To: <20240213192340.2023366-1-avagin@google.com>
Precedence: bulk
Mime-Version: 1.0
References: <20240213192340.2023366-1-avagin@google.com>
Message-ID: <170906349657.3809281.8603439312604083486.b4-ty@google.com>
Subject: Re: [PATCH v3] kvm/x86: allocate the write-tracking metadata on-demand
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	Andrei Vagin <avagin@google.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, 
	Zhenyu Wang <zhenyuw@linux.intel.com>, Zhi Wang <zhi.a.wang@intel.com>, 
	Yan Zhao <yan.y.zhao@intel.com>, Yongwei Ma <yongwei.ma@intel.com>
Content-Type: text/plain; charset="utf-8"

Added a few more KVM-GT folks.  FYI, this changes KVM to allocate metadata for
write-tracking on-demand, i.e. when KVM-GT first registers with KVM.  I tested
by hacking in usage of the external APIs, to register/unregister a node on every
vCPU before/after vcpu_run(), so I am fairly confident that it's functionally
correct.  But just in case you see issues in linux-next... :-)

On Tue, 13 Feb 2024 11:23:40 -0800, Andrei Vagin wrote:
> The write-track is used externally only by the gpu/drm/i915 driver.
> Currently, it is always enabled, if a kernel has been compiled with this
> driver.
> 
> Enabling the write-track mechanism adds a two-byte overhead per page across
> all memory slots. It isn't significant for regular VMs. However in gVisor,
> where the entire process virtual address space is mapped into the VM, even
> with a 39-bit address space, the overhead amounts to 256MB.
> 
> [...]

Applied to kvm-x86 mmu, thanks!

[1/1] kvm/x86: allocate the write-tracking metadata on-demand
      https://github.com/kvm-x86/linux/commit/a364c014a2c1

--
https://github.com/kvm-x86/linux/tree/next