Received-SPF: pass (google.com: domain of linux-kernel+bounces-84094-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <e16b9165-2907-48c0-9e34-d0b78b9781f5@intel.com>
Date: Tue, 27 Feb 2024 14:05:16 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/2] x86/resctrl: Simply call convention for MSR update
 functions
Content-Language: en-US
To: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>, "James
 Morse" <james.morse@arm.com>
CC: Thomas Gleixner <tglx@linutronix.de>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, "Yu, Fenghua" <fenghua.yu@intel.com>, "Ingo
 Molnar" <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>, Babu Moger
	<Babu.Moger@amd.com>, <shameerali.kolothum.thodi@huawei.com>, "D Scott
 Phillips OS" <scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>
References: <ZdZPht8hY4J9uIOz@agluck-desk3>
 <20240222185039.72201-1-tony.luck@intel.com>
 <20240222185039.72201-3-tony.luck@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240222185039.72201-3-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHBaLzl4eUZvaWhHMGVDNjEraGRpaXJlZW5ORDZaNkxZcW1ZWldoSy8zc1BQ?=
 =?utf-8?B?ZnNEZnZXd1huRjNXdTFaN2R4ejFjanZ6NEtZcUZFWG1KM1N1YmNmQ1gvZmxI?=
 =?utf-8?B?UVBQMWhuU21paEJDUE1qSUtzSjlyRFZtV1gwSGg4SGUyZ0VHWktGVmdEY25X?=
 =?utf-8?B?bEFQelJEdkVCS1BIeiswZS8xNWNJcCszNW4ybS9yaUZmTGM5bjlXZ2NVdW8r?=
 =?utf-8?B?Z0dsMUJDdzBIUkxyYVF4U1RoU1VLSEVsNS8xeGRvN0xabjhtZ0ZYYWlvZUR3?=
 =?utf-8?B?eFcwK3ZtWXFkZUlsd2ZETDFLVlR1NkVIbG9yYjZpV2hMbFcyV2hRbE16UFJv?=
 =?utf-8?B?MlRyT2QzNFVQTXhaL09ONHdBNGFwQ2U5eTNSa09yT2V4Zkh1RVZEWWFham9Y?=
 =?utf-8?B?Q3piMEpsQUQ4a3J3V2VLTU0yaWtTQXB2eTg4RUZ5N0pQOUpLVENqbmlrZVZa?=
 =?utf-8?B?TENxeWVIN3k0QTVUVXAwdlhqWHdPQjhmbGpySXhxd3dKdlFia2xRVkhaSDUw?=
 =?utf-8?B?MWxIK2VwMTdqdkNCbW1MK01kdmh2WklDNHdhdjl3WmhyRGxFZ3V6TENoQkJh?=
 =?utf-8?B?NHNSdlB1NzlNVXFSNjdraDRFNGdCOWVEQ21GRkxZUWhwK3lJWkZ4VUNnRlZa?=
 =?utf-8?B?dHYzaDhMWUlaNWM5WXZ1ZGlTd2pYNCtPRFEvTVozNFlUSDQxVzF1T01YcGJz?=
 =?utf-8?B?NjRwa2V2a3pjbFQyZ1pkNitVWVFBaisxZDBlMU53SU9RaHQ3NGRtdnoxY2c5?=
 =?utf-8?B?L2RhR1ZNbC8rbDVmT2RicmlHeENFZThKWXdBNkxqSHhXaVp1amJTSVFrMzdm?=
 =?utf-8?B?cnY0aEVub2NQNVZpMGVHSi9PTlhNMG1xa0VSZC9iSjA1c0dxdW5tdlQ3R1hr?=
 =?utf-8?B?K1RsUUdKb1FacTFCcGUwb053VURNNEIwZXdMc01uaDF6OXVjNitOWm5xWHBH?=
 =?utf-8?B?QldUNHJaNXFncVNXUlpmU2NYVStRK3d5a0VJV01vSDdYNSswcytvMzBMNTFX?=
 =?utf-8?B?VjF0YzRIVnZHSmJ1NGRoRW1IeW1RODNsV1h1VERwZTBESENPN1hjdlR4a1lj?=
 =?utf-8?B?Tkp3SHBtenZBUSs3MGQzczlvbmpTeFp1Z2VEcHVNeVZybk5VSDBldUd3MGNn?=
 =?utf-8?B?cmRNaHcxcTRSRXpPZ1NNcmhVd1JyQ0xwY0VyZi9aOFVGZmhiaDlQdmpKTzJa?=
 =?utf-8?B?c3ZncXdwSnR5TFVIeG5GK1gxWkp6YmdNM2c4a2Z2L0N2N1VWMis4WFlRS3Z4?=
 =?utf-8?B?MWl3Z0llQVdTYTB0NjJ6ZzZFTGhjTHR5WmJqa2wyY1JIMENmUlNDcktYMUhF?=
 =?utf-8?B?ajN6K2hBdW54bjkwWVB6bzJrTHJENEZEZ3A1em9iTGg0YXdSNlE5MkswN2VO?=
 =?utf-8?B?cStrVURGZ0VlVUhMYlI1U1J0UkRMbjNUWGJMc0tSRE4wS3lxZ3ZwblI1dnpB?=
 =?utf-8?B?SWVXNStoL1Y5RDRLUEkvcDdJVmt4SjF6Y1pSQWU4ajNSd1duZUdPOGI1enY5?=
 =?utf-8?B?QzdxZm9xVERvT0FuY2lBdCtOTEJudzhrMi9qbTJPdUdvUUVJM1pOMjhrZzZL?=
 =?utf-8?B?Y25wOWdHYnFZaWJheXpzT0hTNkpSYVllRFpqeFZNa080UnE5dWE0aDl6Q3RS?=
 =?utf-8?B?RDA3VzlTbW83eTRib3Q2UWUwdE95alVuU3ZlSGxEc0ZPSndCOUpkbkxMbVlm?=
 =?utf-8?B?QkExbCtaUDFSVXhscTM4c2JwdU5NSExLYUMwakx0bVpEUmxPVGNlcHoybFFS?=
 =?utf-8?B?MkJEeitLWlZBcUg5SkJnQyt6T3VQK2VTRzE5aWUzTEFnK25VOHJvbm9OV3pE?=
 =?utf-8?B?WU5JUHc3cThhMFpMSlpiZDFoTzArVVhDOERrc2N2MkEzQTgwYnkrL3JONkZS?=
 =?utf-8?B?ZFdTR1JjVVFXSTZ6cXZUcXY4aG1MaUhjTlpCc2I3Y3pWYTFWMCtXdUVEOXlh?=
 =?utf-8?B?SHdYNXlSUk1UaEx3TXUvTWFnSUtnem4wbTFFcWgvUlBrOVc0TG9zNzlTSGVx?=
 =?utf-8?B?YmRRUmtTWERmM1BOMVZzWWk2V3VBVkRjVkUrUTZETXNWZklMMW5OTnFMSTJ5?=
 =?utf-8?B?eGVGNVBidmxTVU5BRnpMRmVVWi9yaUJSUjVLd21JYjRBaFNiQ2txT1Z3aE15?=
 =?utf-8?B?REd4aG9HSUU2UFlCQXJCcTNZcXlDRUJDWVlCUlZ4VXU3QnVkVURoZ0NEcnNt?=
 =?utf-8?B?elE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e638578-3652-42fa-4c8e-08dc37e02ef8
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 22:05:18.1247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fi4Br4sLE7bebCS0NX/CoIvt3b/oYUPUob2KOOOHzWyPDjI94C3wVDOkjq/dETRSq0rO8O1ZfTtvC/8rwiBRUdFJk8HhHvYzVbYzpBhXE9I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4622
X-OriginatorOrg: intel.com

Hi Tony,

On 2/22/2024 10:50 AM, Tony Luck wrote:
> The per-resource MSR update functions cat_wrmsr(), mba_wrmsr_intel(),
> and mba_wrmsr_amd() all take three arguments:
> 
>   (struct rdt_domain *d, struct msr_param *m, struct rdt_resource *r)
> 
> But struct msr_param has always contained the rdt_resource, and now
> contains the rdt_domain too.
> 
> Change to just pass struct msr_param as a single parameter. Clean
> up formatting and fix some firtree parameter ordering.

Please stick to imperative tone. For example (feel free to improve):
	struct msr_param contains pointers to both struct rdt_resource
	and struct rdt_domain, thus only struct msr_param is necessary.

	Pass struct msr_param as a single parameter. Clean
	up formatting and fix some fir tree declaration ordering.

The patch looks good to me, thank you.

Reinette