Received-SPF: pass (google.com: domain of linux-kernel+bounces-84096-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <0a633c22-8426-42cf-9572-7812ffc75d0a@intel.com>
Date: Wed, 28 Feb 2024 11:08:38 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCHv8 17/17] ACPI: tables: Print MULTIPROC_WAKEUP when MADT is
 parsed
Content-Language: en-US
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov
	<bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>
CC: "Rafael J. Wysocki" <rafael@kernel.org>, Peter Zijlstra
	<peterz@infradead.org>, Adrian Hunter <adrian.hunter@intel.com>, "Kuppuswamy
 Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>, "Elena
 Reshetova" <elena.reshetova@intel.com>, Jun Nakajima
	<jun.nakajima@intel.com>, Rick Edgecombe <rick.p.edgecombe@intel.com>, Tom
 Lendacky <thomas.lendacky@amd.com>, "Kalra, Ashish" <ashish.kalra@amd.com>,
	"Sean Christopherson" <seanjc@google.com>, Baoquan He <bhe@redhat.com>,
	<kexec@lists.infradead.org>, <linux-coco@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
References: <20240227212452.3228893-1-kirill.shutemov@linux.intel.com>
 <20240227212452.3228893-18-kirill.shutemov@linux.intel.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240227212452.3228893-18-kirill.shutemov@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2hSUDVFbkowOW5FMGsxYkRFTE9mOVViL0dmT2FadWp6eENqdHZHMEl3Sndk?=
 =?utf-8?B?dFkxSHJ6MjR5WmVDS0d2UWIwNFhFdHNteHR5blMrSUJuZi82QjJWWVpIRXkz?=
 =?utf-8?B?cWVudWZMd3UwTUx0aVAzZkNBL1MyQmFlVXVYQVl3d082M3ZLc3hONSs3UytT?=
 =?utf-8?B?NjlOOXlFckZCdzdVYUtaNU9DWDZKSjd5Tmx2ME1VVFdXZ3ZFaW1nV0xWV1lq?=
 =?utf-8?B?MkI5a3lNSmE3TlhpRHFzdTE3YTNMejVpNXlLRjJZTFhESjk0VFJnZG8yL05u?=
 =?utf-8?B?dkNyQ2ZWV1V4Z3VWNmJwTjNyT01HdnV2bHNWNVB5bXE5SHVQRTRId21tdFQ2?=
 =?utf-8?B?emMwNVRONXpndjcrRnl1Nmg2TUdoSkNiRTBTeXJ1clBUYkxHS043WjVhZ2dy?=
 =?utf-8?B?UlNCMG9uL091SnBZcDNqVnJDcytmcm56NTZyL25LSUlmancvakVzbFlZTi9C?=
 =?utf-8?B?T25ONEpkekJKOCsvbXhpZ2xSVmRjdzV3NVUyWTVlVWtJaUFjZDQ4N1hZTUhu?=
 =?utf-8?B?eXlkbUhYQWhkOGUwZVFxOG51Rjg1ZTcrQUdQNE9icTJzOWpmUjZGUW0wS2JN?=
 =?utf-8?B?MTFXNk9VaTZxZWduS2JNSWdQQ2hFcTNPZkJnYjFlMTRvMHg1VHUrcFpkRU5S?=
 =?utf-8?B?WVg1d0tLeHRFYzJsMkk1bklaNklrN3gvbGsxQVAvSndJTnBxdHpsSkdEeHlB?=
 =?utf-8?B?bjJGL09hWHlWQ2RxR3lMRm43dGMvbklaK1hldmV4c05UNno1ckJudXQyMUJI?=
 =?utf-8?B?dDlwUno0UTF0SHdSSStqRGUvVVVqbEsxQjNhUklrTmorV0NjdkFQbkdhd1lS?=
 =?utf-8?B?aGRYR3o3MDZ6U3ExczZGNm1tdTYrZjMzYk9RTy8zZklzK0pJZHlBb0VCSjBF?=
 =?utf-8?B?Vnd6UWRyYU4xZnJLZ3pHcnhYbWVjNjNWK2lsNG53dTd4OFBDOU9TVW1hUWdt?=
 =?utf-8?B?ZFRnRGtHNzFkb0lMdmI2MklGNzhMZzdDVE1zRlpZT05ZSlh4Q0tjeEdKTVlp?=
 =?utf-8?B?eVpRaU5reHNQMXh2Ry9VczhYYkFxTkhncGpCRnNnajcwaUhKbCtUc1dOQzgy?=
 =?utf-8?B?NHFkbVF0OS9aZ3Fsc09zWGtCbTJDblFxY3JYa0NFNDQ2Q1hyT0EyY09ERS9v?=
 =?utf-8?B?RGVEdlBkYVNYTGZlM0NmcjQ0QThSazNTMy9RZUFsM0oxaENOOTc3emFmcGRF?=
 =?utf-8?B?a1VMSHUrRDFzNytoTzBiWWJhMGZiRGNZdkVVb1JsQ0R6cjc5S1hBMFFYNjFt?=
 =?utf-8?B?aXVENW4yeFB4Q0ZYN3ZtUHhSMkJaelZ3V2d5cW5CdkpUekFMczc4ODRzZ3pu?=
 =?utf-8?B?ZHdGY0I4TFNBeEg5NEF0dnFQN1o0bjJ4NndCU3dPZ0dYbXZOY2xNdmFMQmh5?=
 =?utf-8?B?SDFzUjJhVmJRVTh0b1pOVDYvcWpVcUs0a2kzL0s1bXJlOHgrMGNaOHNnMENM?=
 =?utf-8?B?My9maGRiRUdxOGNnb2Q2V2lmUkp6VnBYY0RJVG02UGxDQnhDY3B4UFY1WTJt?=
 =?utf-8?B?TmxRU01tbmN1MHdhVWdZRjZOa0laSzRNMlh1d0F6REFYRkF5eHJaTVQ2aEdu?=
 =?utf-8?B?d0FlWm5nTlllc1BsaHRaeWV0UUF4SDBmbkZxZGhHcERBeCtjTXoxM3dHU1lt?=
 =?utf-8?B?WnExL0RjbTBmY3pYcnd5SGJGSmkrbFZ5NjNETE1BNUg3cjJJa05SbmpnSTVt?=
 =?utf-8?B?UllQb1FMdTZ1bTkwYVY4bW1OZi9UN1RZSWRGUmlTK3U0YVNtUlpVR2I2bXV3?=
 =?utf-8?B?R1FNY01rUzdlcEVwTEg3emM0bGdjdGUyOE5yVU1SK1hoS09QT0lOV2ZTSjFu?=
 =?utf-8?B?cXpXV2ZMNTNXWG1KcjhkeG1EczV6eUxPek0wYy96aEdaL2ZFemVESjJmY01o?=
 =?utf-8?B?NkZER1VkWk5CcEl5bUwzRFBLUTEva1A4NHRiRTYrTVd0TDQvZlFablo4U3Mv?=
 =?utf-8?B?WU9teGZKc1BpblFlaVBGb0VxN1JEOGNHQmFBZ3BSSWFlaGFnSC9CQmRQZFVS?=
 =?utf-8?B?ZDU4ZGN0TGl1WHQ2T1hrVWcrK3VrZWpLS1BSWUx6WExnOGM0RmNCekpEZnBQ?=
 =?utf-8?B?QTJ0aVpIbDdya1lCLzVNWVZWV1UzMEQwQktRRlRpMGs3MnhtTC8veSs1UHN1?=
 =?utf-8?Q?IxAek8LFMrMaz1TsdOszB8x/E?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ce8d1581-0ebd-4eb0-53c5-08dc37e0ae5a
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 22:08:51.8620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PTgD3HSsdYyeiFIyveHSbJp3a0J7Ufqw7K3f8ZRw9I2jbfxgPJCvhJ6RDj+9Cxngo+A7ec5Acj52M8Lpy9LkQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7608
X-OriginatorOrg: intel.com


On 28/02/2024 10:24 am, Kirill A. Shutemov wrote:
> When MADT is parsed, print MULTIPROC_WAKEUP information:
> 
> ACPI: MP Wakeup (version[1], mailbox[0x7fffd000], reset[0x7fffe068])
> 
> This debug information will be very helpful during bring up.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reviewed-by: Baoquan He <bhe@redhat.com>
> ---
>   drivers/acpi/tables.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index b07f7d091d13..c59a3617bca7 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -198,6 +198,20 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>   		}
>   		break;
>   
> +	case ACPI_MADT_TYPE_MULTIPROC_WAKEUP:
> +		{
> +			struct acpi_madt_multiproc_wakeup *p =
> +				(struct acpi_madt_multiproc_wakeup *)header;
> +			u64 reset_vector = 0;
> +
> +			if (p->version >= ACPI_MADT_MP_WAKEUP_VERSION_V1)
> +				reset_vector = p->reset_vector;
> +
> +			pr_debug("MP Wakeup (version[%d], mailbox[%#llx], reset[%#llx])\n",
> +				 p->version, p->mailbox_address, reset_vector);
> +		}
> +		break;
> +

Hmm.. I hate to say, but maybe it is better to put this patch at some 
early place in this series w/o mailbox version and reset_vector, and add 
incremental changes where mailbox/reset_vector is introduced in this series.

The advantage is in this way someone can just backport this patch to the 
old kernel if they care -- this should be part of commit f39642d0dbacd 
("x86/acpi/x86/boot: Add multiprocessor wake-up support") anyway.

But I guess nobody really cares since it just prints some dmesg, and 
nobody really noticed this until this series.

So, up to you, and feel free to add:

Acked-by: Kai Huang <kai.huang@intel.com>