Received-SPF: pass (google.com: domain of linux-kernel+bounces-84116-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <38e1b141-f7ef-40fe-be8a-97d9f9273a8f@gmail.com>
Date: Wed, 28 Feb 2024 00:17:33 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/4] staging: pi433: Remove a duplicated F_OSC define
Content-Language: en-US
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: gregkh@linuxfoundation.org, luca.ceresoli@bootlin.com,
 benjamin.tissoires@redhat.com, elder@linaro.org, robh@kernel.org,
 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240225173341.1278918-1-ikobh7@gmail.com>
 <20240225173341.1278918-2-ikobh7@gmail.com>
 <ZdykDGo9fMw5fEdp@smile.fi.intel.com>
From: Shahar Avidar <ikobh7@gmail.com>
In-Reply-To: <ZdykDGo9fMw5fEdp@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 26/02/2024 16:45, Andy Shevchenko wrote:
> On Sun, Feb 25, 2024 at 07:33:38PM +0200, Shahar Avidar wrote:
>> F_OSC is already defined & only used by rf69.c source file
>> Also fix define comment
> 
> You missed periods at the end of the sentences.

Thank you for noticing.

>> -#define F_OSC	  32000000 /* in Hz */
>> +#define F_OSC	  32000000 /* Hz */
> 
> Instead of having a comment you can
> 
>    #include <linux/units.h>
>    ...
>    #define F_OSC	  (32 * HZ_PER_MHZ)
> 
> which will be more robust code (no need to count 0s).
> 

All comments are fixed in v2 which was just sent.
Please note I sent the updated patchset twice, I forgot to add v2 the 
first time...

-- 
Regards,

Shahar