Received-SPF: pass (google.com: domain of linux-kernel+bounces-84222-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <13ff89af-cee5-4102-be23-1c8ebd51f86d@intel.com>
Date: Wed, 28 Feb 2024 12:30:42 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCHv8 10/17] x86/tdx: Convert shared memory back to private on
 kexec
Content-Language: en-US
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov
	<bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>
CC: "Rafael J. Wysocki" <rafael@kernel.org>, Peter Zijlstra
	<peterz@infradead.org>, Adrian Hunter <adrian.hunter@intel.com>, "Kuppuswamy
 Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>, "Elena
 Reshetova" <elena.reshetova@intel.com>, Jun Nakajima
	<jun.nakajima@intel.com>, Rick Edgecombe <rick.p.edgecombe@intel.com>, Tom
 Lendacky <thomas.lendacky@amd.com>, "Kalra, Ashish" <ashish.kalra@amd.com>,
	"Sean Christopherson" <seanjc@google.com>, Baoquan He <bhe@redhat.com>,
	<kexec@lists.infradead.org>, <linux-coco@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
References: <20240227212452.3228893-1-kirill.shutemov@linux.intel.com>
 <20240227212452.3228893-11-kirill.shutemov@linux.intel.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240227212452.3228893-11-kirill.shutemov@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azJZMUJpN1dtb3lmRjJOeUFKcVFyK3Vmam04QWJSeFlqWDJWcWhmNjMrT2lG?=
 =?utf-8?B?RGo5cjJXVnhqb3FlOVZHWjNGREV6SytkM1NyVlhCd2ZFUVVuc3F4ZFNORmMy?=
 =?utf-8?B?T2FMVTB5dUpIWldUUUtXMm95RkVpNmJPOGhubW0xd0lRdkExWmpaYmRRVXA1?=
 =?utf-8?B?RDY2WFl4RzB5TXNmRlJWdXlTWGIxMWJJOGZSdEN2N1ZBSlNVM2Y3S0Q3Ylht?=
 =?utf-8?B?R2ttRjhpNEc1VzZ3YmVHTk1qay9zVFZDUmF2L0Jad0gyT3NwSU80clVnV1Js?=
 =?utf-8?B?TXBpeUZkUkYyc3hJUnpLeStRR3VGYWpmazh3L0R1NWtxa3hxUE1KaVNHTE8z?=
 =?utf-8?B?Tkdic29ldGY4K01jdVQxcXF0d2RoeGRjZW9xSUlDQkFveWlQeGp4VEVUS290?=
 =?utf-8?B?TE5QaEhKU2J5NlNvc1RRbHZRRUJNTVU0SEJMZXphSkdtR01tM2c2TXNUeFRO?=
 =?utf-8?B?cUo0S0ZlU2lqZUF2K1Q3c1V0YWs2WWRlZzBDTHM4cnArbURUazBQSzdaSm1N?=
 =?utf-8?B?eGZkWnFCSnE4RWxMVGZqU1o0a0FPYjQrNTMvdThPSzJETXNIWVlIajhFRVFs?=
 =?utf-8?B?VU5tcFhjbTBQMmI2OENzbHJ1N2RUOXhVMXZ5akZKRmtYTno2S2tuVnd6K2V5?=
 =?utf-8?B?SzR1K3RjK0FGdW1hVWVpUEM5RnRlK3pScDA0R1FaeDR2RmR1NHprUW81c2RG?=
 =?utf-8?B?cm5iUTlIZ0xNWGpNaXlNQi9pcFp5MFJqVnRxK3RyekNuRnJvL2pFWVhhQzdC?=
 =?utf-8?B?bkJxNnI5Z0NSbDVQTUVGeFRKVWN0Z2cxdFRXUExMVFVra09tc29KUkhLOTFz?=
 =?utf-8?B?Zi9kdlpqcEhyMjR6Q0UzOTUrTTNxUzFQaTdRRXk5dk1semJjNUswdFZldVJt?=
 =?utf-8?B?azRLKzRiTXFnbnl3azhLSklqd2tnZXFGOG9odi80YjRlc0pELzJveU9zTUUz?=
 =?utf-8?B?c09adFk1TTF4d3gxSUtHa054eGs3QmNjWkdjRGFxd0hXZ0R6Z1dSMFNJSWdn?=
 =?utf-8?B?d2ZrWkNlVkhMVmVpd0YzRldiVFh1ejArQkhieHBlMlNIUzkwS0NkT1VVWm5B?=
 =?utf-8?B?bUFpdFdJdmpQVXY1T1VuWkJqYUNhQk4wOS9xbmh3ODNBK0FQQW9YQmhKNzJK?=
 =?utf-8?B?NnNTd2xqc0QrUEt5cDdqclZEWWtzUU5JS0o0U0dTelZDM1RjY1VwRWlEQklO?=
 =?utf-8?B?VkRYcFgyVlczWlhJMlNua0lBV2FUOTlyWFZ0NU1NVmM4WHVHSHdneEVxVWRx?=
 =?utf-8?B?ankxMTAzcW1xMkp6MnhJN20zSkVFeXZWTnFXVUcyV0JTcDczcjhQNFZNSXJV?=
 =?utf-8?B?d2RqcXA0cU80eUpWNWZpcjc0dTI0cGZtcVQ0bjh5am85WmpDVE9uK0xVZ045?=
 =?utf-8?B?TVU0bzFYMTVyMG9maG1FZTlLRjdyc2d1WVVqdlRYMGx4S3U0cmY2dTlBbU9v?=
 =?utf-8?B?dXV2dmttWWdJeXBPeXJCUERoMnhZSmZFUWZKVHNQejNKWlBuNTd6MERneE1N?=
 =?utf-8?B?ZUg4S1pocEJCRVBQaVhHOGFMV0FlSEJLSVdQOGdnbFpKV21ZZk16eXFJSFVo?=
 =?utf-8?B?QjdOOGQ2QnJNVCs5NHdrVHZXb2YxU3llNWN4TUN3RWRYY21BZFdrTjczS1o5?=
 =?utf-8?B?WHdnQXRoYWUzOUowellRdXhWQzFpWmQzU09vN1lJK2tpbWJzSWZIdEc1SmdU?=
 =?utf-8?B?eEhaczB0cXowdUloUHZEN2dxaktzVHg0ayt6WUlKdUJidnR4UUsxREVMU0Y0?=
 =?utf-8?B?VFExQjh1QThHTWNjYkxyd3Vvd2RmcFJqbEVsZEorbDFORFFNeHh3Z1llUmtK?=
 =?utf-8?B?M2pWTEJxemVhT0FGRTd2ZXZXeGY0T0pKUFdsQ2dLTXRxNHlKZDl3RFJVcGEv?=
 =?utf-8?B?azVVditTbm8vSFpBY0RXaHdJRldOM1VsZ3BvNHloLzM3R2RibDNDSUtjMVFD?=
 =?utf-8?B?L1NWUW9kU1hVaGpCVm5QdTMwb05vS2p6eENzdDFuS1VxbzdMdmw0TURTczQ0?=
 =?utf-8?B?NlRZa1VEWTJrZXQ5U2MxNFBQaDF2WEVIQzdiTWN2azFXMUZFNlgxQmNQWDBS?=
 =?utf-8?B?bExFWHlnRS9TdUVuS25nNVpYVU1LK3hhaC9GamlOQWRjb0Rtb2pDc1hqSk94?=
 =?utf-8?Q?91Un6i5xzcMQMg0LadiZI1IuG?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 07e6afa6-551b-466e-eb35-08dc37ec24e2
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 23:30:55.1898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AW/mO1t/mYwr0JvF/B11z+ABeJy+VzqEuH9soRcnhGjRmUJhEl5xLHmSv106XZbq8NlX3PEjqQWhR4MLFILl8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7654
X-OriginatorOrg: intel.com


>   
> +/* Stop new private<->shared conversions */
> +static void tdx_kexec_stop_conversion(bool crash)
> +{
> +	/*
> +	 * Crash kernel reaches here with interrupts disabled: can't wait for
> +	 * conversions to finish.
> +	 *
> +	 * If race happened, just report and proceed.
> +	 */
> +	bool wait_for_lock = !crash;
> +
> +	if (!stop_memory_enc_conversion(wait_for_lock))
> +		pr_warn("Failed to finish shared<->private conversions\n");

"Failed to finish" -> "Failed to stop"?  stop_memory_enc_conversion() 
doesn't actually finish any conversion.

Other than that:

Reviewed-by: Kai Huang <kai.huang@intel.com>