Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2242044rbb; Tue, 27 Feb 2024 16:00:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV68KeeMZToaA8TwPuN9V/O7a1xN8YWlUhrFVlaVLKzZKahXwHWi254A7pbRM/2l4X/nfklh2Af7hMUKJ/88cGIWSYvYO6HAb1mpagbfw== X-Google-Smtp-Source: AGHT+IFLO5miuhxtpTyJ6CMr8HgR5hucBUoi8hUIr/8NetmnZGfefUVjuE4TQccqzCEjzgn+9Sis X-Received: by 2002:a05:6402:e9a:b0:565:af1d:7416 with SMTP id h26-20020a0564020e9a00b00565af1d7416mr7265652eda.5.1709078459632; Tue, 27 Feb 2024 16:00:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709078459; cv=pass; d=google.com; s=arc-20160816; b=0+rJkDHbQOgzZKotOJou0yG7ZPSILyNWsniw2VvS5sRAqk9ldQHkbApfY9OSYyZt0c G8ipXyqgJoboQ06xCFpnXsef1yuqWOn2B2LZD7KWxiTdWP2ThDiN+x0R3zYvlQNQUiuN V414KThQvFBaFbzwYPigD6/p+ki4LaGceEgDcrR+nHWUhVd8AkPNy51hF9AjoFQa80dT dj5H8hUvaL+gv9h40OepuASOVdv9n/8nGEwt8WlTxj7XTmACxUaUAENajylzYm6hjRHK yuE/4Zbdves5rnGcGwRM49Y9s9gao+wvke4Y4OH6dtAwZ9VkmU2+LYPGt5UBYg7SC41P HQHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:to:from:dkim-signature; bh=XjThLvc0bEs0bLv81qQ4QgPb0qI9It17bTsCyGqXnrI=; fh=x4bFVqj5qD52f35ITnpIMR9XPjt+nAjpv5WW2CLFX0Q=; b=cKPwHgKgzVktJAKjJxxnkSautTTty8VhSpLsbee1v9/b5gpSGW/4v5Sq2G5iEyqBI4 HHBZyM7aTP40y7joqTpdd2cCUeiJ56Igyi9l8/BU17hkR1o1kveaQ+eSgSX/qFglqhag 5rt32Gw9NzYfJjOmezONTuy8RwB7tVRGQ+EEd+UlXa6Uld+C96AQVw13flyUNjXb/3g7 s5h4W/kzOw2UxSoDyEAz/S308Iqzl9vZcvrMAhEqDoHfv7xhslpeQmH47Xn71yp3KOjg udDwVXuaejClSqa9dWnU2aZorBvc5obRqKRVWFtQ63DcXmuevWxCKZyFUbKWhra6JYzV Y/KQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IDvdmSUR; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84245-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84245-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id df21-20020a05640230b500b005660742f983si1067288edb.330.2024.02.27.16.00.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 16:00:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84245-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IDvdmSUR; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84245-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84245-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 631B91F23796 for ; Wed, 28 Feb 2024 00:00:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 94AC01EEFC; Wed, 28 Feb 2024 00:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IDvdmSUR" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18C7D381CB; Wed, 28 Feb 2024 00:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709078420; cv=none; b=QuBcEpiFD30RnlzT1Y/+XM3Gcw0RA9r/qypnRmnwIn0Tm7rcDkwMcDAwE8s8F6hE1IkD8TNuKnD5Ee8tBF6nc4WGyVOb/JQQacrRH3TpAT74mMBHVT6N6SRmUMylKTMQTqhbRO6HGvOqOMyc2MOQrtKwLCydzWbqP8c4mWR5xag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709078420; c=relaxed/simple; bh=kTuJBiH0He/AE/VlrZQG9PWPYUT9ap2kxnqVhwAzT6Q=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=Mc3YEn38TDYJ5ACJ1l6HATF+cMnTi+eERJ+R3J92K/LGCoWZUgt7VCUOc7JzEjacxliX5NARoaYKqa6phbu6K9LhXlz3qpG0oMpyHL+e7C5NWiZ7ApRqqKo72FCXng/24POrzfo6ryo0L43TEhD92RIE/7ofZz7eUkt58zQmcew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IDvdmSUR; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709078418; x=1740614418; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=kTuJBiH0He/AE/VlrZQG9PWPYUT9ap2kxnqVhwAzT6Q=; b=IDvdmSUR6kYU4pmPzIpQ9Gf1uab5TOsbW/ZI7gDVahact8+EfyDDokgr xYCMBYhxgQ9EO352jB1riDdxdR1dVThVDlDFdSoI5tqNAOer+ijxKU+Iw cnlzSd2/fWayDHJCClDuFq4+JVaeKKwO14Wz0x/LmxlvWGigROUqt2F/l tY/LWcx0IX6M8MZ097eVa/kxo9RJGpPtwdP0wHuqUjYn7Qf2ik8a2Lbyl 7Tr/EUnPYWEj9dcFXx7XvKvXmlEzt+DafWJk/9t6j8sMApH3fURHmKP0h okB+sq+19R/cIuvFS1ATR8ARJEwRciZ/8zC3sphD6m9Aloa9LzpPJX8XR g==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="25919833" X-IronPort-AV: E=Sophos;i="6.06,189,1705392000"; d="scan'208";a="25919833" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 16:00:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,189,1705392000"; d="scan'208";a="7439162" Received: from linux.intel.com ([10.54.29.200]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 16:00:17 -0800 Received: from debox1-desk4.lan (unknown [10.251.6.149]) by linux.intel.com (Postfix) with ESMTP id 71BFC580B9A; Tue, 27 Feb 2024 16:00:16 -0800 (PST) From: "David E. Box" To: david.e.box@linux.intel.com, rajvi.jingar@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com Subject: [PATCH V2 1/9] platform/x86/intel/sdsi: Set message size during writes Date: Tue, 27 Feb 2024 16:00:08 -0800 Message-Id: <20240228000016.1685518-2-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240228000016.1685518-1-david.e.box@linux.intel.com> References: <20240228000016.1685518-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit New mailbox commands will support sending multi packet writes and updated firmware now requires that the message size be written for all commands along with the packet size. Since the driver doesn't perform writes larger than the packet size, set the message size to the same value. Signed-off-by: David E. Box Reviewed-by: Ilpo Järvinen --- V2 - no changes drivers/platform/x86/intel/sdsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c index 556e7c6dbb05..a70c071de6e2 100644 --- a/drivers/platform/x86/intel/sdsi.c +++ b/drivers/platform/x86/intel/sdsi.c @@ -252,6 +252,7 @@ static int sdsi_mbox_cmd_write(struct sdsi_priv *priv, struct sdsi_mbox_info *in FIELD_PREP(CTRL_SOM, 1) | FIELD_PREP(CTRL_RUN_BUSY, 1) | FIELD_PREP(CTRL_READ_WRITE, 1) | + FIELD_PREP(CTRL_MSG_SIZE, info->size) | FIELD_PREP(CTRL_PACKET_SIZE, info->size); writeq(control, priv->control_addr); -- 2.34.1