Received-SPF: pass (google.com: domain of linux-kernel+bounces-84233-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <10808725-d98b-430b-8c47-4feef8685734@intel.com>
Date: Wed, 28 Feb 2024 12:47:06 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC][PATCH 09/34] x86/cpu: Introduce address configuration
 structure
Content-Language: en-US
To: Dave Hansen <dave.hansen@linux.intel.com>, <linux-kernel@vger.kernel.org>
CC: <kirill.shutemov@linux.intel.com>, <pbonzini@redhat.com>,
	<tglx@linutronix.de>, <x86@kernel.org>, <bp@alien8.de>
References: <20240222183926.517AFCD2@davehans-spike.ostc.intel.com>
 <20240222183938.662DD27C@davehans-spike.ostc.intel.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240222183938.662DD27C@davehans-spike.ostc.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUVUT29mNTFGYThmd2pMTGFGOFp6ZFoySkNCVktiWTY0RWJhZitYWDhpSkNK?=
 =?utf-8?B?VGQxOFlsNmtWTjJkRTJNdVpFemh3dWlHdHNjODRVWURyTm4yVkRNc3BBdjVz?=
 =?utf-8?B?Zkx5Mkc5cVlHVzJ4NWxrcXVXVmw4VUtSYXBsZ3VORE9TZEpXMHJQZjRacEpt?=
 =?utf-8?B?Z2RxRzhCVDBIOFRvMDdvK3BCUzBCVHdHcXU1bWxXZ0FBc1FsNFAxNTZ5OFlO?=
 =?utf-8?B?R3pxTFlTZUM1OW9TbzZ0cjNMN0dhNWdSRnBXMEZMUFozc1ZteHRXckxmL1kv?=
 =?utf-8?B?a1pWVUR1aWFwZDFMZkpTNTlwMFJWcWNlNm8yN0ZVZDRWWHVGQUsvMEo1azlU?=
 =?utf-8?B?RHd0SU56UDdWaW8rZHAvRGtTK2ZGemt2bmlnbXQrKy9xZUlnOXQ0YURZdVM4?=
 =?utf-8?B?UHdoK2ptVlhzTDlIYVRwd2dPc0Q3WTU5ZFpDUzdDbXRLSXhTUTYxd0t3NWRw?=
 =?utf-8?B?ZHNHYjdIVkRMN0d0dFNMb1Fick9lRHZZWEw1MGJIcVZoZmJ3TG9xbTRJTXE5?=
 =?utf-8?B?SGxqWGF2Lzc4NEVDK1Nramw2YytIQm5OQTFLOUFzT2lDZmRZcVludElZTmw2?=
 =?utf-8?B?c3Mrbk95bFRGRFI1UWUwcng4K05aNHZRdFJuMHhIOWdtM2JrMWNWT3VuNDBw?=
 =?utf-8?B?VnZScTJwc1BRNmNscTdUTExpMTQzQ3loVE1FV256WUhFZHh6KzNjQzRvQ0Z0?=
 =?utf-8?B?T3F2SWlKTnB4VW5pcnVYOEp1VGtBYTZ2MzhXWHRyRnh6alFCWjFKMm9zK2JB?=
 =?utf-8?B?ZVBoTTBMNld3RmhnR043eTY3L0ZtNFdxUTFaM1FuT1FPVlNpUEZJTXFxUjJB?=
 =?utf-8?B?VW9FUkRDZG9ZbkFML3FSbnFHZjcwT3ZMWmFONTRzTDVwWkhPUWJqdWgyTHIw?=
 =?utf-8?B?eDVIK3V2NzdhL1A4UEVXQzgrMFhjRnVLNWpNM04wOUVtMG85dXp4UXBjcnFQ?=
 =?utf-8?B?c1Bob2UzbFZnb1NjZE9PL2VwdS9INW9MV2ZoVDlzbXBmYklWbjFSNkJDMDlV?=
 =?utf-8?B?Y2M1b3IrRlZiMmt5VndxWVZqVkNGY3JzZ3FXNVQ0Zi9LVU5yYjhpRnpDK3lo?=
 =?utf-8?B?NGhMMk5KMHVsZGtKWmtyd1lCaVA3R2kxeGdXRElydW02Y1htbzdtMDFzVnkz?=
 =?utf-8?B?MnVaaXhHNFR5UmdRU1lqR1JkcXk2NHNuaUFvVkVtUmNhR2VGbDAxb0JjT2kw?=
 =?utf-8?B?WXVtSHVSTEp0Z3ZnSThiMVhuQnZRaGlWeXRBV3dzVzBrM2lFM3lQaW1FeGtN?=
 =?utf-8?B?UHhMajlPUEJxMnNObEhEam03NTJnU3l0TDg1eWZBT2dZWHAwZitsOGs2cGZp?=
 =?utf-8?B?WnFqYm52ZXlack5hRURYMmE1ZDRVck50RHAySUZGYW1Vc0dxSkRMTGNILzNa?=
 =?utf-8?B?OXA3bVMwNUViNXBYTExweW5TU3RTNXNlUFpQcE1YNVlaNzlnMnllc2FMNFB6?=
 =?utf-8?B?V0QvL1lzek5SWWZEZENYL2JaRUpnMGJYQW9QVUYvZ2ZkOTdBZ2pVUGhRblhj?=
 =?utf-8?B?M3Q3N2Y3MThHcnI5bzloc3h4Q04yR1dhbi9PcE5YMVJlMFQ4alMzKzZUZHNI?=
 =?utf-8?B?eW9BcFBvam5rZFYraERUdmtDVDNRQTkvZk52cnZGd2xtdk5ldlg5MEsxZVVT?=
 =?utf-8?B?Wjd2TlBSOXF1N253SUJsWDYxVkJSZHdBV3hvSk1TbkJLM084MDI5OHhYSUs5?=
 =?utf-8?B?eEtpTTQ4eDh6bGJ4Vmc5Um1uR29YbitldGJ5VTNoYXY5ZmJlYzJkZ0FrNWV1?=
 =?utf-8?B?WjNrSjlRQjdvL1BCc0xaTHhzeFBNemczSUhGSEhRbWNSRk9rbi81Mzlqb3JE?=
 =?utf-8?B?SEhVa3VxZlBMNDhsell0Y3ZRTkdtRnYvVk5BcDJWQ0pEWkN2ZmZHeUxPeUFH?=
 =?utf-8?B?MHQzNUxmeUhZcHowSTlpb2tpcS9BVjAvRUdiUlZ1VFF4QjVjV0EwOC9CUmlz?=
 =?utf-8?B?Z0tvbjE2dHZrSXhCM0hySVdqd3lpbDV3d0hEb1lVUFpvRG9rbW5STWFDRE9O?=
 =?utf-8?B?Y282ZjNVU21ZVmhSQVU3aUFDYlJNN1IvRFAxd0xhNjdoemlSdE52Z1JJV1Yw?=
 =?utf-8?B?T0hzNHY3K2NNK3lHOEl3MlBVaUFETkxpK2syckRvMzJjZjlHUDluUERtMGti?=
 =?utf-8?Q?C2a3eEHllSq1ZgWdxq25gemq/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a4f3091-b997-4b6b-2c99-08dc37ee6d0a
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 23:47:15.2212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9APNFOcUoYyLbci3Qof7DxhShCZyst2dDN5Pm8XvimIk7MokP0YhxbG24kTBWnpLFt050B7NLkFxZQWRBGuggw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5307
X-OriginatorOrg: intel.com


On 23/02/2024 7:39 am, Dave Hansen wrote:
> 
> From: Dave Hansen <dave.hansen@linux.intel.com>
> 
> Right now, 'boot_cpu_data' is established in a very ad hoc way.  Random
> bits of the initialization code write random things to it, either
> blowing away state or tweaking it as they see fit.  It's madness.
> 
> Add some more structure to the process.
> 
> Introduce an "address configuration" structure just for the boot CPU.
> This will be used to establish system-wide address space configuration.
> It is written while bringing up the boot CPU and then read *ONCE* to
> establish the configuration.
> 


 From the above description, ...

> +struct x86_addr_config bsp_addr_config;
> +

.. this can be __ro_after_init?

Maybe I am missing something, but if it cannot be annotated with 
__ro_after_init here, IMHO it would be helpful to call out in the changelog.