Received-SPF: pass (google.com: domain of linux-kernel+bounces-84259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <987a671f-bacf-4c44-a48d-97ab74397628@linuxfoundation.org>
Date: Tue, 27 Feb 2024 17:08:54 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in
 Intel CAT selftest
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>, shuah@kernel.org,
 fenghua.yu@intel.com, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org, ilpo.jarvinen@linux.intel.com,
 Shuah Khan <skhan@linuxfoundation.org>
References: <cover.1708072203.git.maciej.wieczor-retman@intel.com>
 <f8886683-4f24-47ce-a0c6-ef28466bfec9@intel.com>
 <685828ed-06d2-4a2c-9911-05145e55ea1a@linuxfoundation.org>
 <48dab897-162d-4075-baa9-f5391a23d31d@intel.com>
 <a8f1f104-c5c1-400c-873e-99b01cde1d88@linuxfoundation.org>
 <beuizmgezzcnd3f74nsmigfn7n5emj43pxaqtyki7bjgj4nqn5@ldpqu65vaunu>
From: Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <beuizmgezzcnd3f74nsmigfn7n5emj43pxaqtyki7bjgj4nqn5@ldpqu65vaunu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2/26/24 02:28, Maciej Wieczor-Retman wrote:
> Hi Shuah,
> 
> On 2024-02-23 at 15:37:11 -0700, Shuah Khan wrote:
>>
>> Hi Reinette,
>>
>> Okay ran a quick test. Why does this test leave "/sys/fs/resctrl"
>> mounted when it exits. Can we fix this to unmount before the test
>> exits?
> 
> I also wasn't able to reproduce this unmounting issue:
> - with unmounted resctrl before test:
> 
> 	[/root]# ls /sys/fs/resctrl/
> 	[/root]#
> 	[/root]# ./resctrl_tests -t L3_NONCONT_CAT
> 	TAP version 13
> 	# Pass: Check kernel supports resctrl filesystem
> 	# Pass: Check resctrl mountpoint "/sys/fs/resctrl" exists
> 	# resctrl filesystem not mounted
> 	# dmesg: [   12.502941] resctrl: L3 allocation detected
> 	# dmesg: [   12.507134] resctrl: MB allocation detected
> 	# dmesg: [   12.511315] resctrl: L3 monitoring detected
> 	1..1
> 	# Starting L3_NONCONT_CAT test ...
> 	# Mounting resctrl to "/sys/fs/resctrl"
> 	# Write schema "L3:1=3f" to resctrl FS
> 	# Write schema "L3:1=f0f" to resctrl FS # write() failed : Invalid argument
> 	# Non-contiguous CBMs not supported and write of non-contiguous CBM failed as expected
> 	ok 1 L3_NONCONT_CAT: test
> 	# Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
> 	[/root]# ls /sys/fs/resctrl/
> 	[/root]#
> 
> And with mounted before test:
> 
> 	[/root]# ls /sys/fs/resctrl/
> 	[/root]#
> 	[/root]# mount -t resctrl resctrl /sys/fs/resctrl
> 	[/root]# ls /sys/fs/resctrl/
> 	cpus  cpus_list  info  mode  mon_data  mon_groups  schemata  size  tasks
> 	[/root]# ./resctrl_tests -t L3_NONCONT_CAT
> 	TAP version 13
> 	# Pass: Check kernel supports resctrl filesystem
> 	# Pass: Check resctrl mountpoint "/sys/fs/resctrl" exists
> 	# resctrl filesystem is mounted
> 	# dmesg: [   12.502941] resctrl: L3 allocation detected
> 	# dmesg: [   12.507134] resctrl: MB allocation detected
> 	# dmesg: [   12.511315] resctrl: L3 monitoring detected
> 	1..1
> 	# Starting L3_NONCONT_CAT test ...
> 	# Mounting resctrl to "/sys/fs/resctrl"
> 	# Write schema "L3:1=3f" to resctrl FS
> 	# Write schema "L3:1=f0f" to resctrl FS # write() failed : Invalid argument
> 	# Non-contiguous CBMs not supported and write of non-contiguous CBM failed as expected
> 	ok 1 L3_NONCONT_CAT: test
> 	# Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
> 	[/root]# ls /sys/fs/resctrl/
> 	[/root]#
> 
> Looking at the code there is an unmounting function called after each test (at
> the end of run_single_test() inside of test_cleanup()). The non-contiguous test
> also doesn't write any data into a temp file so no additional cleanup is
> necessary.
> 


Looks fine. Thanks for the clarification.

thanks,
-- Shuah