Received-SPF: pass (google.com: domain of linux-kernel+bounces-84263-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240227212244.262710-1-chris.packham@alliedtelesis.co.nz> <20240227212244.262710-4-chris.packham@alliedtelesis.co.nz>
In-Reply-To: <20240227212244.262710-4-chris.packham@alliedtelesis.co.nz>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 28 Feb 2024 02:12:05 +0200
Message-ID: <CAHp75VdXfCp1FRd6JKTB==MkywjPQCvQru=Y02bjSn5nu-WGFA@mail.gmail.com>
Subject: Re: [PATCH v2 3/4] ARM: dts: marvell: Add 7 segment LED display on x530
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: andy@kernel.org, geert@linux-m68k.org, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, 
	gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, 
	ojeda@kernel.org, tzimmermann@suse.de, javierm@redhat.com, robin@protonic.nl, 
	lee@kernel.org, pavel@ucw.cz, devicetree@vger.kernel.org, 
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 27, 2024 at 11:22=E2=80=AFPM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
>
> The Allied Telesis x530 products have a 7 segment LED display which is
> used for node identification when the devices are stacked. Represent
> this as a gpio-7seg device.

Please, be consistent with naming and references. I think the
compatible / driver name are the only two that should be used.

This also needs an Ack from the respective maintainer (I don't know
who that is, you might find in MAINTAINERS, though).

--=20
With Best Regards,
Andy Shevchenko