Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2285447rbb; Tue, 27 Feb 2024 17:52:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXalP4qrTX6zr751hNYxNMmdHv5T0uG/+c9V4Qp3ufaXbCC1fB7hqpG6WEBazNN+xPFBBe0C7Y5qKE+i3JxlSaobo6Eu2r+ntMmaw7hZQ== X-Google-Smtp-Source: AGHT+IE8b8VkC7WdQux9lx7FSRNVk2bu6MQF9lD/EB7lj77FSYRxFzGZe3YM4lEqMu+ZanyfgTm0 X-Received: by 2002:a05:620a:1a93:b0:787:c0b9:26b7 with SMTP id bl19-20020a05620a1a9300b00787c0b926b7mr5076011qkb.0.1709085137671; Tue, 27 Feb 2024 17:52:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709085137; cv=pass; d=google.com; s=arc-20160816; b=Jyt2YugbtGJyYUZKqvRAgaiW/F+VUwiRVv5bQ4ntvu2JdUkjr5+hzTL9M0YGXH1V5l i6CRrXTbTohVL2vQc/QCnuZlMaW8QDAydt63oCN8XzDP89Y/aMKY08nQ4dvqB94FPFCd OAh+I6e+BpHpya6x5hQhyH39NzHeSpnHKnl1AGZ2BUMY5gUiArCoiELg8KzMGUoLRLd7 37XfewEOy25K73jAQDFQ5NGLc+N4SAObzz0jl+uiJO8NkvtvaZo2JXZ/nchM6cuhupDf eihCjGk01m2d1ozFoGnjyBsU5cXkuhU7UwCyDCyOuCR9mMBOcRR811ylUPDeiGxirrj5 ZG8g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=XcHGPZYzBpq2QPUs+Yyildk8kJr9r60XyojA5HGHCec=; fh=u9X9DnBzad2/hW9UktgjcjUq5Pm6N0LpYHTO29KSrmE=; b=gVPdk/uzhVEb1lSDw849Fx6GNMW0VIOvmo+IPG0d5SItFfAqtsCBgr49mnS8EWZsPe BPaDKlgcrqr9gnf4CUeBOMBxl6NO9EZFKAoUhV4cz1k7iMJcK72BRNjZ6hYLk3tWSnNg kRNVWSPLT73wto3tNm64QrFRDLQEdyRNuqr6J5OaaNwlINjaq+GVgp2iGbOIlnxFKGF4 6rz9+VIPkW28yvKzWhiwD8oD3+lNSVWkZKuKwLywlu/niSSIF2AD7fExl5efyospLldQ 7uhUcaA6zVud9M5cuO6982yUxSmRaiiWrZXqsokZPQHE+E5uQ5PCYa0ATamg0h73BtEn n++g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=kylinos.cn); spf=pass (google.com: domain of linux-kernel+bounces-84382-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84382-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t6-20020a05620a034600b0078794b6bc75si8547794qkm.101.2024.02.27.17.52.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 17:52:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84382-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=kylinos.cn); spf=pass (google.com: domain of linux-kernel+bounces-84382-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84382-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6D9481C22D10 for ; Wed, 28 Feb 2024 01:52:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C8FDB1D53C; Wed, 28 Feb 2024 01:44:51 +0000 (UTC) Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BC5F4400 for ; Wed, 28 Feb 2024 01:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709084691; cv=none; b=Td/gVadVheAXtT7+zbufhlJ9OFF9ejNdO1tDgNLO4hrmAS7OpT7b6w510xOzo5vfKXYEQ6EAZ4MXRC9Qa4rTmrNPwF4XBT0h0kLDd7fbFJiN+OnP0NIKMYZ+QYNiauZwnxlnS1CHeRBkAj+fdAs0N2Iqy9u5u3T1RzmeTC3Ke1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709084691; c=relaxed/simple; bh=8ZheHfrSU54qvFXbtTA6yJgjr8hUzFqP9Qq4JNTJYXk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=q8gNBBKyuyAs2pAROhqJ3AUxTqsnDxMIiDitemEHBFDvUqfyGulQsVpkgVzz12n0Q/WeBbtg7Sb7KxMEXEQ82PLD9qUVNmXYvvY/QcdYZOAFPDTCqFi++Wr0kuQUe8OS8CRPGSKegA5WNkW1ox1bV+NR5E7lgZojo+eobAdan+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: e372564b6c6346f5a530e4e7c953ba67-20240228 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:88b45a86-72ae-420f-8cae-71d289904034,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.37,REQID:88b45a86-72ae-420f-8cae-71d289904034,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6f543d0,CLOUDID:494be480-4f93-4875-95e7-8c66ea833d57,B ulkID:240228094440JA95B6XN,BulkQuantity:0,Recheck:0,SF:66|38|24|17|19|44|1 02,TC:nil,Content:0,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC: nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: e372564b6c6346f5a530e4e7c953ba67-20240228 X-User: yaolu@kylinos.cn Received: from localhost.localdomain [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1595601688; Wed, 28 Feb 2024 09:44:37 +0800 From: Lu Yao To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lu Yao Subject: [PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions Date: Wed, 28 Feb 2024 09:44:35 +0800 Message-Id: <20240228014435.7234-1-yaolu@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer. Signed-off-by: Lu Yao --- drivers/gpu/drm/amd/amdgpu/si.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index a757526153e5..455d49f7bd9c 100644 --- a/drivers/gpu/drm/amd/amdgpu/si.c +++ b/drivers/gpu/drm/amd/amdgpu/si.c @@ -2032,8 +2032,8 @@ static int si_common_early_init(void *handle) adev->pcie_wreg = &si_pcie_wreg; adev->pciep_rreg = &si_pciep_rreg; adev->pciep_wreg = &si_pciep_wreg; - adev->uvd_ctx_rreg = si_uvd_ctx_rreg; - adev->uvd_ctx_wreg = si_uvd_ctx_wreg; + adev->uvd_ctx_rreg = &si_uvd_ctx_rreg; + adev->uvd_ctx_wreg = &si_uvd_ctx_wreg; adev->didt_rreg = NULL; adev->didt_wreg = NULL; -- 2.25.1