Received-SPF: pass (google.com: domain of linux-kernel+bounces-84385-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240227024050.244567-1-21cnbao@gmail.com> <Zd4HEjS6vpIvwfR9@infradead.org>
 <CAGsJ_4xTtLzUKSY7EzEK0Ho61mWH35kHkidBRpjLd+_3_yOaUQ@mail.gmail.com>
In-Reply-To: <CAGsJ_4xTtLzUKSY7EzEK0Ho61mWH35kHkidBRpjLd+_3_yOaUQ@mail.gmail.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Wed, 28 Feb 2024 09:46:21 +0800
Message-ID: <CAK1f24mN2jTuhhAq-KAZczdp9OPf90b5JRNiyszWNRt+n0aK=g@mail.gmail.com>
Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might
 need it
To: Barry Song <21cnbao@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>, akpm@linux-foundation.org, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org, Barry Song <v-songbaohua@oppo.com>, 
	Ryan Roberts <ryan.roberts@arm.com>, David Hildenbrand <david@redhat.com>, 
	Yin Fengwei <fengwei.yin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 28, 2024 at 3:02=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrot=
e:
>
> On Wed, Feb 28, 2024 at 5:00=E2=80=AFAM Christoph Hellwig <hch@infradead.=
org> wrote:
> >
> > On Tue, Feb 27, 2024 at 03:40:50PM +1300, Barry Song wrote:
> > > From: Barry Song <v-songbaohua@oppo.com>
> > >
> > > madvise and some others might need folio_pte_batch to check if a rang=
e
> > > of PTEs are completely mapped to a large folio with contiguous physci=
al
> > > addresses. Let's export it for others to use.
> >
> > It doesn't look exported to me in the patch (and that's a good thing!).
> >
> > But even for making it non-static you probably want to include that in
> > the series actually making use of it.
>
> at least two parallel jobs[1][2] (maybe more ) need it right now.

+1

After kernel support for anonymous multi-size THP, PTE-mapped THP will
no longer be the exception. IMO, folio_pte_batch() is widely useful for che=
cking
whether we're mapping all subpages of the large folio or not.

Thanks,
Lance

> Getting this one pulled in early
> will help build a common base for them and avoid duplicates&conflicts in =
them.
>
> [1] https://lore.kernel.org/linux-mm/20240118111036.72641-7-21cnbao@gmail=
com/
> [2] https://lore.kernel.org/linux-mm/20240225123215.86503-1-ioworker0@gma=
il.com/
> >
> > > +extern int folio_pte_batch(struct folio *folio, unsigned long addr,
> > > +             pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags,
> > > +             bool *any_writable);
> >
> > no need for the extern here.
>
> Yes. this has been moved to internal.h as "static inline" in v2:
> https://lore.kernel.org/linux-mm/20240227104201.337988-1-21cnbao@gmail.co=
m/
>
> Thanks
> Barry